Re: [Postfixadmin-devel] Return value of model/* classes

[Christian B. <pos...@cb...>]

Hello,

Am Samstag, 18. Dezember 2010 schrieb Rudi Floren:
> Between the models and the cli are the shells. In these classes we
> can change the 0, 1 problem.
> When i created the classes i orientated at the unix/linux format. 0
> ok 1-n failure code.

Good motivation, but in PHP more code uses true/false ;-)

I changed UserHandler and parts of AliasHandler to true/false, and also
updated the CLI - everything should still work as expected.
I'will change the remaining *Handlers when time permits (unless someone 
beats me, of course ;-)

Two questions regarding the CLI: 

1) When I do an invalid action (for example trying to create an already 
existing mailbox), I get an error message, but $? is still 0. Is this 
something I broke while switching to true/false or is that a bug in the 
CLI code? (and: how to fix it?)

2) Is there some way to have less duplicated code in the shells/* ?
For example, shells/alias.php and shells/domain.php have 400 common 
lines and only 100 lines specific to one of these files.


Regards,

Christian Boltz
-- 
> /etc/sysconfig/powersave/cpufreq contains the line:
> # the next lover CPU frequency. Increasing this value lowers the
             ^^^^^
we should keep that one ;)
[Michael Gross in https://bugzilla.novell.com/show_bug.cgi?id=183704]