[ postfixadmin-Bugs-3086899 ] vacation.pl typo in debug logging

[SourceForge.net <no...@so...>]

Bugs item #3086899, was opened at 2010-10-13 22:38
Message generated for change (Settings changed) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3086899&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Johan Meiring (jmeiring)
Assigned to: Nobody/Anonymous (nobody)
Summary: vacation.pl typo in debug logging

Initial Comment:
Typo in debug logging

Patch as follows:
mailhost:/var/spool/vacation# diff -u vacation.pl.orig vacation.pl
--- vacation.pl.orig    2010-10-13 22:12:03.000000000 +0200
+++ vacation.pl 2010-10-13 22:35:49.000000000 +0200
@@ -325,7 +325,7 @@
 # Recipient has vacation
     if ($rv == 1) {
         $realemail = $email;
-        $logger->debug("Found '\$email'\ has vacation active");
+        $logger->debug("Found \'$email\' has vacation active");
     } else {
         my $vemail = $email;
         $vemail =~ s/\@/#/g;


----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2010-10-14 01:55

Message:
Thanks for your bugreport! This bug qualifies for the "stange quoting of
the year" award ;-)

Unfortunately the first backslash disabled expansion of $email, so "Found
'$email' ..." was literally logged. Obviously not really useful ;-)

The backslashes are not really needed - «'» has no special meaning
inside of «"» AFAIK. Therefore I removed the backslashes in the line you
mentioned and also some lines below.

Commited to SVN trunk r875. If we decide to do a 2.3.3 release, it will
also contain this fix.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3086899&group_id=191583