|
From: SourceForge.net <no...@so...> - 2010-09-11 23:25:20
|
Bugs item #3027375, was opened at 2010-07-09 15:09 Message generated for change (Comment added) made by christian_boltz You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3027375&group_id=191583 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: v2.3.1 >Status: Closed >Resolution: Fixed Priority: 9 Private: No Submitted By: Christian Boltz (christian_boltz) Assigned to: Nobody/Anonymous (nobody) Summary: users/edit-alias does not verify alias targets Initial Comment: Looks like users/edit-alias does not verify the alias targets (or the verification is broken) - it just accepted "foo" as alias target... (2.3 has the same bug, therefore no regression and no reason to delay the 2.3.1 release ;-) ---------------------------------------------------------------------- >Comment By: Christian Boltz (christian_boltz) Date: 2010-09-12 01:25 Message: Fixed in trunk (r862) also. Still with the "ugly" solution because it was simple to merge, but I at least added a TODO note to my local copy ;-) ---------------------------------------------------------------------- Comment By: Christian Boltz (christian_boltz) Date: 2010-08-01 23:25 Message: This bug has a very interesting solution: It's fixed by adding $error = 0; before checking the alias targets. With $error uninitialized, $error += 1 is still === 0 - at least PHP thinks so... Lection learned: always initialize your variables! Fixed in the 2.3 branch (SVN r850). The not-so-good news is that some internals of edit-alias aren't too nice - for example, $goto[] can contain an element with empty string. I added a check for that in the 2.3 branch, but we should use a better solution (avoid empty elements in $goto) in trunk ;-) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=3027375&group_id=191583 |
