|
From: Christian B. <pos...@cb...> - 2010-05-17 23:40:22
|
Hello,
Am Montag, 17. Mai 2010 schrieb David Goodwin:
> > not yet merged and/or to be discussed:
> > - r805 - debian/* - normes or GingerDog, can you merge this part,
> > please? I don't want to change stuff that I don't understand ;-)
>
> Just blindly merge it - I think only normes really understands it.
The best solution would be if normes does this part of the merge.
-> normes? ;-)
> > - r800, r806, r821 - Squirrelmail Plugin
>
> please do.
OK
> > - r811, r812 - Squirrelmail Plugin / Zend - not sure if we really
> > should include the whole Zend framework in the tarball, it's
> > laaaaaarge and only useful for squirrelmail users.
> > I'd vote for a "Requires: Zend" in the documentation.
>
> This is tempting. At the moment it should be an svn:external - and
> perhaps we can view that as just being useful for development.
OK, then I won't include Zend in the 2.3 branch.
I would even remove the svn:external from trunk - I don't see a real
advantage compared to having it in the PHP include_path or symlinked.
OTOH, the svn:external slows down several svn commands...
> > - r815: the change in users/index.php makes access to users/ too
> > easy if someone forgot to logout (security by obscurity, but
> > still...)
>
> Don't understand this ^^^ comment, can you elabourate/
old users/index.php:
header("Location: login.php")
new (r815) users/index.php:
header("Location: main.php")
Why I don't like this change: If someone forgot to logout and just went
to another site, the login cookie stays valid. Let's also assume he
leaves his computer and someone else wants to configure his mailbox
under users/.
Old behaviour: login form is shown
New behaviour: instant access to the (still logged in) mailbox
Therefore I'd prefer to revert to the old behaviour. I know that it's
somewhat security by obscurity (one can still directly go to
users/main.php), but that's very different from actively being pushed
into the foreign mailbox.
> > - r817 - ADDITIONS/cyrus (config file path?)
config file path changed to /etc/mail/postfixadmin/cyrus.conf + merged
to 2.3 branch
> > - r819 - maildir path hook (BTW: the example function should be
> > moved to config.inc.php)
>
> Where is/was it -
in functions.inc.php - I just moved it to config.inc.php.
> but I think I'd agree... it would make it more
> obvious to a sysadmin what's going on.
>
> Sorry for being relatively silent lately - life is busy.
You don't need to tell me that ;-)
The good news: If I get it right, merging (except the debian/ stuff)
should be complete - we are near the 2.3.1 release :-)
@everybody: Please checkout the 2.3 branch from SVN and check if
everything works. Especially check if everything listed in the
CHANGELOG.txt works ;-)
Regards,
Christian Boltz
--
<suseROCKs> henne: [...] Can you link me to any documentation [...]?
<henne> suseROCKs: brain://henne/hardware/touchsmart
<suseROCKs> Firefox: Oops! There appears to be no brain:// associated
with henne
[from #opensuse-project]
|
