[ postfixadmin-Bugs-2958684 ] $CONF['admin_email'] ignored in most cases
Brought to you by:
christian_boltz,
gingerdog
|
From: SourceForge.net <no...@so...> - 2010-03-02 04:52:36
|
Bugs item #2958684, was opened at 2010-02-25 23:49 Message generated for change (Comment added) made by tabmowtez You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2958684&group_id=191583 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 1 Private: No Submitted By: Christian Boltz (christian_boltz) Assigned to: Nobody/Anonymous (nobody) Summary: $CONF['admin_email'] ignored in most cases Initial Comment: [13:42] <mrfrenzy> in the configfile it says // This will be used to send emails from to create mailboxes. [13:42] <mrfrenzy> $CONF['admin_email'] [13:42] <mrfrenzy> however, when I create mailboxes the welcome mail is sent with my username as sender [13:44] <cboltz> indeed. a quick grep shows that it is only used by broadcast-message.php [13:44] <cboltz> the question is which behaviour is better [13:44] <cboltz> a) always use the admin_email sender [13:44] <cboltz> b) drop admin_email and use the admin username [13:44] <cboltz> what would you prefer? ;-) [13:45] <mrfrenzy> it really isn't that important, aslong as the instructions in the config filer are correct [13:46] <mrfrenzy> however. I do think there might be reasons you don't want to tell the users what username your adminuser has [13:46] <cboltz> good argument ;-) [13:47] <cboltz> I'll paste the above lines in the bugtracker... [13:47] <mrfrenzy> I really love this irc based bugtracker submission engine :P ---------------------------------------------------------------------- Comment By: Tabmow (tabmowtez) Date: 2010-03-02 15:52 Message: Quick change in create-mailbox.php should fix this. --- create-mailbox.php 2009-04-07 05:54:11.000000000 +1000 +++ /usr/local/www/postfixadmin/create-mailbox.php 2010-03-02 15:48:26.000000000 +1100 @@ -230,7 +230,7 @@ if ($fMail == "on") { $fTo = $fUsername; - $fFrom = $SESSID_USERNAME; + $fFrom = $CONF['admin_email']; $fHeaders = "To: " . $fTo . "\n"; $fHeaders .= "From: " . $fFrom . "\n"; Might be possible to add another config option and being able to define an address as well? Possible a per domain address? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2958684&group_id=191583 |