|
From: SourceForge.net <no...@so...> - 2009-07-30 07:35:26
|
Bugs item #2829452, was opened at 2009-07-30 06:06 Message generated for change (Comment added) made by gingerdog You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2829452&group_id=191583 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: v 2.3 >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Ryow (ryowsuzuki) Assigned to: Nobody/Anonymous (nobody) Summary: backup.php sometimes needs directory_separator Initial Comment: Hi developers. I did backup but the content of sql file was php errors, saying, upload_tmp_dir setting is "/var/lib/php/tmp" and backup.php tried to open "/var/lib/php/tmppostfixadmin-20090730-19251.sql", witch is out of open_basedir setting "/var/lib/php/tmp". ini_get('upload_tmp_dir') doesn't have a last slash in my environment, but backup.php just attaches a file name to the upload_tmp_dir without slash. I just fixed to work in 57 to 59 like below. $path = (ini_get('upload_tmp_dir') != '') ? ini_get('upload_tmp_dir') : '/tmp'; // '/tmp/' -> '/tmp' $filename = "postfixadmin-" . date ("Ymd") . "-" . getmypid() . ".sql"; $backup = $path . DIRECTORY_SEPARATOR . $filename; // added a DIRECTORY_SEPARATOR I hope this bugfix will be applied in the next release. Best regards ---------------------------------------------------------------------- >Comment By: GingerDog (gingerdog) Date: 2009-07-30 07:35 Message: patch merged; thank you. see changeset 697 ---------------------------------------------------------------------- Comment By: GingerDog (gingerdog) Date: 2009-07-30 07:35 Message: Thanks for the bug report; we believe this has been fixed in subversion. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2829452&group_id=191583 |
