|
From: SourceForge.net <no...@so...> - 2009-04-18 07:35:07
|
Patches item #2721439, was opened at 2009-03-30 01:07 Message generated for change (Comment added) made by jan-kruis You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2721439&group_id=191583 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Vacation Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Jan Kruis (jan-kruis) Assigned to: Nobody/Anonymous (nobody) Summary: use vacation.pl for multiple choice of reply Initial Comment: adding choice of reply -type of reply is store in table vacation in new record type -delay between reply is store in table vacation in new record delay choice of reply -once -autoreply - interval reply Choice can be set by admin or user ( only by pfa not by squirrelmail) option is controle by config.inc.php ---------------------------------------------------------------------- Comment By: Jan Kruis (jan-kruis) Date: 2009-04-18 09:34 Message: Hi David Thx for the info. But how abaut the records i add to the table in the database Jan ---------------------------------------------------------------------- Comment By: GingerDog (gingerdog) Date: 2009-04-18 09:04 Message: Hi Jan, Yes - you can edit diff/patch files - just try and make sure it remains valid. Your diff file _should_ contain the new files as well - if it doesn't, try doing 'svn add file.php' and try and re-create the diff then. Thanks for the hard work :) David. ---------------------------------------------------------------------- Comment By: Jan Kruis (jan-kruis) Date: 2009-04-18 02:06 Message: Hi guys, I think it ready. I will test it for two more days. A question. I have given the command svn diff > diff_file to generate a path file but can I edit this file, to leave out my config.inc.php stuff out. and who must i send the new 2 php to your which i added to this project. (just a patchs) which are edit-userscontrol-domain.php and templates/vacation.php also what kind of file do you need for de modifaction in the database table. my svn version is 629 at this moment. Regrads Jan Kruis ---------------------------------------------------------------------- Comment By: Jan Kruis (jan-kruis) Date: 2009-04-13 21:33 Message: I will try to implement this request ---------------------------------------------------------------------- Comment By: Charles (libertytrek) Date: 2009-04-13 13:03 Message: > Making the reply-interval configurable per user is a good feature and will > be merged after the 2.3 release. Will there be an Admin option to disallow Users from setting/changing this interval if desired? Many sites (mine for one) will want to set this policy site-wide... ---------------------------------------------------------------------- Comment By: Christian Boltz (christian_boltz) Date: 2009-04-13 12:08 Message: I only had a very quick look on your changes. Some notes: Making the reply-interval configurable per user is a good feature and will be merged after the 2.3 release. Merging the vacation template for users and admins into one file is also a good idea. Vacation start and stop date is indeed a different feature. I'd say it should be implemented after merging your changes (to avoid merge conflicts). We once used *.tpl for the template files and switched to *.php to make the PHP code inaccessible from the outside. (*.tpl can usually be downloaded as plain text.) Finally a question: Which version (or SVN revision) of postfixadmin did you use as base for your changes? Knowing this would make merging easier - however if you don't remember, I can reconstruct it from the $Id lines in the files. (It would be even better if you can provide a patch instead of the changed files. If you did your changes against a SVN checkout, just run "svn diff".) ---------------------------------------------------------------------- Comment By: Jan Kruis (jan-kruis) Date: 2009-04-07 22:08 Message: hi, I have a question ? Because in your earlier replay you have told I'll see if I can find the discussion(s), and create a formal enhancement request to track it. What happens with this modification ? Will it be used or ... ? These are actually two modifications: modification 1 To reduce the two templates for setting the vacation edit-vacation.php and user-vacation.php to only one vacation.php which checks from which module ( admin or user) it is called. Because the two older templates did use a lot of same code. modification 2 Adding the option to make a choice of reply. If the choice is once it act as vacation normale should work. If the choice is autoreply there is a value in config.inc.php which set the delay time between two emails from one sender to prevent the vacation.pl from replaying from a possible autoreplay email. The admin as well as the user can make the choice of replay. Depending on the settings in the config file. in the table vacation i add two records type and delay and in the table vacation-notification i add the record notified_at. In the config.inc.php file you can set these options allow or not the multiple-choice or reply allow or not the multiple-choice or reply for users ---------------------------------------------------------------------- Comment By: Jan Kruis (jan-kruis) Date: 2009-03-30 23:50 Message: Hi Guys, Hmmm... I'm confused too I know I recall discussion a while back about some new functionality, that would not only allow the user to set the frequency, but would allow the Admin from PREVENTING users from doing this, if the Site had a certain policy they wanted to enforce site-wide. ===> See function vacation & use of config.inc.php Did this get lost? Also, I think in the same discussion, we talked about the possibility of setting Start/Stop dates, so you could actually schedule your vacation message ahead of time and have it auto-start/end at the desired times. what has this to do with this patch the vacation.php template file can by used by edit-vacation and user-vacation so only have to modifed one file. In the config.inc.php file i added some value which give contole over vacation.php if a user can change type of replay and the time delay. Regards Jan ---------------------------------------------------------------------- Comment By: Charles (libertytrek) Date: 2009-03-30 16:14 Message: Ok, thanks, good to know I'm not going senile! ;) I'll see if I can find the discussion(s), and create a formal enhancement request to track it. Thanks! ---------------------------------------------------------------------- Comment By: GingerDog (gingerdog) Date: 2009-03-30 14:32 Message: libertytrek - yes, I vaguely remember such conversations; I'm happy to merge such features once 2.3 is out. (Speaking of which it's probably time for another rc release) ---------------------------------------------------------------------- Comment By: Charles (libertytrek) Date: 2009-03-30 12:43 Message: Hmmm... I'm confused. I know I recall discussion a while back about some new functionality, that would not only allow the user to set the frequency, but would allow the Admin from PREVENTING users from doing this, if the Site had a certain policy they wanted to enforce site-wide. Did this get lost? Also, I think in the same discussion, we talked about the possibility of setting Start/Stop dates, so you could actually schedule your vacation message ahead of time and have it auto-start/end at the desired times. Or am I just crazy? ---------------------------------------------------------------------- Comment By: Jan Kruis (jan-kruis) Date: 2009-03-30 01:19 Message: edit-vacation.php and user/vacation.php use the new template/vacation.php BTW is it a idea to change the extensie to tpl for the template file ( we noe have two vacation.php file ??) regrades Jan Kruis ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2721439&group_id=191583 |
