[Postfixadmin-devel] xmlrpc.php, tests/* and some possible bugs

[Christian B. <pos...@cb...>]

Hello,

I played a bit with the tests/ directory and found some possible bugs.

a) xmlrpc.php
session_start results in a "session already started" notice - common.php
already starts the session

b) model/UserHandler.php
db_log is called with the undefined variable $USERID_USERNAME - 
$username should work

c) tests/RemoteTest.php
- there should be a better way than hardcoding $server_url (using 
  $CONF?)
- the ro...@ex... test mailbox should should have a valid maildir 
  set - otherwise edit_mailbox won't allow any changes for it

A patch for those issues is attached. I didn't commit it yet because I'm 
not sure if my changes do what you (GingerDog) wanted the code to do.

Even with this patch, some problems remain:

---------------------------------------------------------------------------------------------------
Postfixadmin XMLRPC Unit Tests
string(342) "
Notice: Undefined variable: domain in ../model/AliasHandler.php on line 157

Notice: Undefined variable: domain in ../model/AliasHandler.php on line 157
<?xml version="1.0" encoding="UTF-8"?>
<methodResponse><params><param><value><boolean>1</boolean></value></param></params></methodResponse>
"
Exception 1!
Unexpected exception of type [Zend_XmlRpc_Client_FaultException] with message [Failed to parse response] in 
[/usr/share/php5/Zend/XmlRpc/Client.php line 349]
Exception 2!
Unexpected exception of type [Zend_XmlRpc_Client_FaultException] with message [Failed to parse response] in 
[/usr/share/php5/Zend/XmlRpc/Client.php line 349]
Exception 3!
Unexpected exception of type [Zend_XmlRpc_Client_FaultException] with message [Failed to parse response] in 
[/usr/share/php5/Zend/XmlRpc/Client.php line 349]
FAILURES!!!
Test cases run: 4/4, Passes: 11, Failures: 0, Exceptions: 3
---------------------------------------------------------------------------------------------------

Note: I use error_reporting = E_ALL, and I recommend to use this setting 
on every development system. 

IMHO run.php should ini_set() it to be really sure we catch all undefined 
variables etc. which won't cause noticable errors ("just" strange bugs)
otherwise.


Regards,

Christian Boltz
-- 
I tip my hat to the creators of the SomeFool virus, for actually (albeit
temporarily and minimally) affecting my Linux experience. However, if
that's the most damage I can get by running viruses with Wine under a
dummy account, then it's clear that the Wine developers have a long way
to go before Wine is truly Windows compatible.
[http://os.newsforge.com/article.pl?sid=05/01/25/1430222&from=rss]