Re: [Postfixadmin-devel] SF.net SVN: postfixadmin:[512] trunk/delete.php

[Christian B. <pos...@cb...>]

Hello,

Am Montag, 26. Januar 2009 schrieb David Goodwin:
> Christian Boltz wrote :
> > Am Montag, 12. Januar 2009 schrieb Gin...@us...:
> > > Revision: 512
> > >
> > > delete.php: this probably allows you to delete domains
> > >
> > > Modified: trunk/delete.php
> > >
> > > +elseif ($fTable == "alias_domain")
> > > +{
> > > +   authentication_require_role('global-admin');
> >
> > Is there a special reason why you limited deletion of alias domains
> > to superadmins?
> >
> > Every domain admin is allowed to create alias domains (given he has
> > at least 2 domains ;-) - so he should also be allowed to delete
> > domain aliases again. (A check if both involved domains are owned
> > by the admin is of course necessary.)
>
> I wasn't sure how to tell if a non-global admin owned a domain.. so I
> just went with the easy option.

What about   
    list_domains_for_admin ($fUsername)
or   
    check_owner ($username, $domain)
? ;-)

Your easy option has the disadvantage that a domain admin can't delete 
the alias domains he created before...


Regards,

Christian Boltz
-- 
         .:  Schneewittchen & die Pfälzer Waldconnection  :.
        Ein polit-kabarettistisches Märchenstück mit viel Musik
  gesungen & gespielt von Mitgliedern der Landjugend RheinhessenPfalz
18.1.2009 Berlin - 6.2.2009 Neustadt - Infos: www.LJ-RheinhessenPfalz.de