|
From: SourceForge.net <no...@so...> - 2009-01-27 23:28:23
|
Bugs item #2541610, was opened at 2009-01-28 10:28 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2541610&group_id=191583 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Vacation Group: SVN (please specify revision!) Status: Open Resolution: None Priority: 5 Private: No Submitted By: Tabmow (tabmowtez) Assigned to: Nobody/Anonymous (nobody) Summary: Admin remove vacation does not clear vacation_notifcation Initial Comment: Hi, I have found a bug (courtesy of Echo_Fox from #FreeBSDHelp on EFNet) that has to do with the edit-vacation.php script. When an admin removes a user vacation message it does not clear the vacation_notification table. So when a user re-enters vacation mode the people that have already been notified will not receive an e-mail. The patch is below inline: --- edit-vacation.php.orig 2009-01-28 09:47:42.000000000 +1100 +++ edit-vacation.php 2009-01-28 09:48:03.000000000 +1100 @@ -118,7 +118,7 @@ $db_false = db_get_boolean(false); // retain vacation message if possible - i.e disable vacation away-ness. $result = db_query ("UPDATE $table_vacation SET active = $db_false WHERE email='$fUsername'"); - + $result = db_query ("DELETE FROM $table_vacation_notification WHERE on_vacation='$fUsername'"); $result = db_query ("SELECT * FROM $table_alias WHERE address='$fUsername'"); if ($result['rows'] == 1) { ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2541610&group_id=191583 |
