Re: [Postfixadmin-devel] SF.net SVN: postfixadmin:[506] trunk/upgrade.php

[David G. <da...@co...>]

> 
> > @@ -156,8 +156,8 @@
> > -                '{UTF-8}'           => '/*!40100 CHARACTER SET utf8   COLLATE utf8_unicode_ci */', 
> > -                '{LATIN1}'          => '/*!40100 CHARACTER SET latin1 COLLATE latin1_swedish_ci */', 
> > +                '{UTF-8}'           => '/*!40100 CHARACTER SET utf8 */', 
> > +                '{LATIN1}'          => '/*!40100 CHARACTER SET latin1 */',
> 
> Do you really think COLLATE can cause problems?

Well... people who had their default collation/character set, set to
uft8 had problems. 

> 
> IMHO it causes more problems if we do not explicitely set it because we 
> then get a "random" (as in "MySQL default on this system") collation. 
> I doubt that this is positive ;-)

Is it a problem if it's set to e.g utf-8? I get the impression that
the distros are moving towards this as a default.

> 
> > @@ -306,7 +306,7 @@
> > -    ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_general_ci TYPE=InnoDB ...
> > +    ) ENGINE=InnoDB DEFAULT CHARSET=utf8 TYPE=InnoDB ...
> 
> Sidenote: CHARSET=utf8 (and COLLATE) should be replaced with {UTF-8}
> 

I don't think I fully understand the difference between the two! It's
so much easier with PostgreSQL!

> > @@ -772,7 +772,6 @@
> > -        ALTER TABLE `$table_vacation_notification` DROP FOREIGN KEY `vacation_notification_pkey` 
> 
> This ALTER TABLE was there for a reason (probably because some version
> of the vacation_notification table had such a primary key).
> 
> I'd like to reintroduce it with the ignore_errors flag set, so that
> the key is deleted if it exists. Any objections?

Not really. I had one user who was seeing problems when it was trying
to remove the key (and it didn't already exist). I presumed it was not
necessary, and could be removed.

I think I'd rather upgrade.php stay as it is - as I have some small
amount of belief that it now works for everyone. At least no one else
has reported bugs with it!

David.
-- 
David Goodwin 

[ david at codepoets dot co dot uk ]
[ http://www.codepoets.co.uk       ]