Re: [Postfixadmin-devel] SF.net SVN: postfixadmin:[506] trunk/upgrade.php

[Christian B. <pos...@cb...>]

Hello,

(just going through some commits and updating the changelog)

Am Sonntag, 4. Januar 2009 schrieb Gin...@us...:
> Revision: 506

> 1) remove explicit collation settings; 
> 2) remove vacation_notification_pkey drop thing 

> Modified: trunk/upgrade.php

> @@ -156,8 +156,8 @@
> -                '{UTF-8}'           => '/*!40100 CHARACTER SET utf8   COLLATE utf8_unicode_ci */', 
> -                '{LATIN1}'          => '/*!40100 CHARACTER SET latin1 COLLATE latin1_swedish_ci */', 
> +                '{UTF-8}'           => '/*!40100 CHARACTER SET utf8 */', 
> +                '{LATIN1}'          => '/*!40100 CHARACTER SET latin1 */',

Do you really think COLLATE can cause problems?

IMHO it causes more problems if we do not explicitely set it because we 
then get a "random" (as in "MySQL default on this system") collation. 
I doubt that this is positive ;-)

> @@ -306,7 +306,7 @@
> -    ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_general_ci TYPE=InnoDB ...
> +    ) ENGINE=InnoDB DEFAULT CHARSET=utf8 TYPE=InnoDB ...

Sidenote: CHARSET=utf8 (and COLLATE) should be replaced with {UTF-8}

> @@ -772,7 +772,6 @@
> -        ALTER TABLE `$table_vacation_notification` DROP FOREIGN KEY `vacation_notification_pkey` 

This ALTER TABLE was there for a reason (probably because some version
of the vacation_notification table had such a primary key).

I'd like to reintroduce it with the ignore_errors flag set, so that
the key is deleted if it exists. Any objections?


Regards,

Christian Boltz
-- 
         .:  Schneewittchen & die Pfälzer Waldconnection  :.
        Ein polit-kabarettistisches Märchenstück mit viel Musik
  gesungen & gespielt von Mitgliedern der Landjugend RheinhessenPfalz
18.1.2009 Berlin - 6.2.2009 Neustadt - Infos: www.LJ-RheinhessenPfalz.de