|
From: SourceForge.net <no...@so...> - 2008-11-12 23:01:49
|
Bugs item #2015707, was opened at 2008-07-11 08:04 Message generated for change (Comment added) made by christian_boltz You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2015707&group_id=191583 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Interface (example) Group: v 2.2 >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: create-mailbox operation does not show password in op result Initial Comment: create-mailbox operation does not show password in op result when $CONF['generate_password']=='YES' --- create-mailbox.php (revision 401) +++ create-mailbox.php (working copy) @@ -278,22 +278,6 @@ */ $tDomain = $fDomain; - if ($CONF['generate_password'] == "YES") - { - $tMessage .= " / $fPassword)</br />"; - } - else - { - if ($CONF['show_password'] == "YES") - { - $tMessage .= " / $fPassword)</br />"; - } - else - { - $tMessage .= ")</br />"; - } - } - $tQuota = $CONF['maxquota']; if ($fMail == "on") @@ -328,6 +312,23 @@ } } + + if ($CONF['generate_password'] == "YES") + { + $tMessage .= " / $fPassword)</br />"; + } + else + { + if ($CONF['show_password'] == "YES") + { + $tMessage .= " / $fPassword)</br />"; + } + else + { + $tMessage .= ")</br />"; + } + } + } } ---------------------------------------------------------------------- >Comment By: Christian Boltz (christian_boltz) Date: 2008-11-13 00:01 Message: Thanks for the report and the patch which pointed out that $tMessage is overwritten instead of merged. Fixed in SVN r481 - show password if $CONF['generate_password'] == 'YES' - do not show password if it was _not_ autogenerated and $CONF['show_password'] == 'NO' ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2008-08-28 18:32 Message: Logged In: NO so, here is patch for this problem: --- create-mailbox.php 2008-07-23 14:41:45.000000000 +0300 +++ create-mailbox-corrected.php 2008-08-28 19:31:13.000000000 +0300 @@ -319,9 +319,9 @@ if (create_mailbox_subfolders($fUsername,$fPassword)) { - $tMessage = $PALANG['pCreate_mailbox_result_success'] . "<br />($fUsername"; + $tMessage = $PALANG['pCreate_mailbox_result_success'] . "<br />($fUsername" . $tMessage; } else { - $tMessage = $PALANG['pCreate_mailbox_result_succes_nosubfolders'] . "<br />($fUsername"; + $tMessage = $PALANG['pCreate_mailbox_result_succes_nosubfolders'] . "<br />($fUsername" . $tMessage; } } ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=2015707&group_id=191583 |
