[ postfixadmin-Patches-2026435 ] Fix footer.php

[SourceForge.net <no...@so...>]

Patches item #2026435, was opened at 2008-07-24 06:24
Message generated for change (Settings changed) made by gingerdog
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2026435&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Invalid
Priority: 5
Private: No
Submitted By: Tabmow (tabmowtez)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix footer.php

Initial Comment:
This is a patch for footer.php so it correctly states when a user is not logged in or not.

--- footer.php.orig     2008-07-24 16:21:30.000000000 +1000
+++ footer.php  2008-07-24 16:21:38.000000000 +1000
@@ -6,6 +6,9 @@
 if(isset($_SESSION['sessid']['username'])) {
     printf($PALANG['pFooter_logged_as'], authentication_get_username());
 }
+else {
+    printf('Not logged in');
+}
 ?>
    |   
 <a target="_blank" href="http://postfixadmin.sf.net/update-check.php?version=<?php print $version; ?>"><?php print $PALANG['check_update']; ?></a>

Before this patch, if you were logged in as a user and then logged out the footer would still say you were logged in as the last user.

Regards,

Terry

----------------------------------------------------------------------

Comment By: Tabmow (tabmowtez)
Date: 2008-07-24 15:47

Message:
Logged In: YES 
user_id=1840699
Originator: YES

Hmms, weird i cannot re-produce the problem now after going back to
2.2.1.1. 
Basically what was happening is that variable wasn't getting cleared on
session_destroy i believe.
Hence why i was seeing the last logged in user even though i was logged
out.

Even with this problem not being evident anymore it still makes sense to
say that no-one is logged in rather than just being blank? Not sure with
this one, i was reproducing it earlier before i lodged the bug. Although i
have since cleared my cache etc. from Firefox so maybe it had to do with
that.

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2008-07-24 14:39

Message:
Logged In: YES 
user_id=593261
Originator: NO

I can't reproduce the described behaviour (testing with SVN version, but
this part of the code didn't change for a long time AFAIK).

Maybe your browser cache contains the outdated version? Please try
clearing the cache after logout just to be sure. If this doesn't help,
detailed steps to reproduce the bug would be helpful - what exactly do you
do after clicking the "logout" menu item?

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2008-07-24 09:00

Message:
Logged In: YES 
user_id=1761957
Originator: NO

Terry - I don't see how that helps to fix the reported problem. Perhaps
I'm being stupid. If they were being told they were logged in when they
weren't, they still will be with this patch applied.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=2026435&group_id=191583