[ postfixadmin-Patches-1995478 ] postfixadmin-2.2.0 fetchmail ssl option

[SourceForge.net <no...@so...>]

Patches item #1995478, was opened at 2008-06-16 22:21
Message generated for change (Comment added) made by christian_boltz
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=1995478&group_id=191583

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Stefan Breitegger (tuxstef)
Assigned to: Nobody/Anonymous (nobody)
Summary: postfixadmin-2.2.0 fetchmail ssl option

Initial Comment:
Suggenstion to click enable ssl option without extra options enabled for fetchmail.

----------------------------------------------------------------------

>Comment By: Christian Boltz (christian_boltz)
Date: 2008-06-30 00:03

Message:
Logged In: YES 
user_id=593261
Originator: NO

To add the ssl field in MySQL:

ALTER TABLE `fetchmail` ADD `ssl` TINYINT( 1 ) UNSIGNED NOT NULL DEFAULT
'0' AFTER `protocol` ;

GingerDog: What's the query needed for PgSQL?

----------------------------------------------------------------------

Comment By: Christian Boltz (christian_boltz)
Date: 2008-06-26 23:01

Message:
Logged In: YES 
user_id=593261
Originator: NO

I converted the patch to unified format for better readability and also
fixed some line positions.

Notes:
- yes, adding the column should has to be a new function in upgrade.php
  (the patch got the wrong line in upgrade.php anyway, so I replaced this
part 
  with a ToDo comment)
- I decided to rename the field from "ssla" to "ssl" - sounds better ;-)
- what's the reason for adding
    defaults
        smtphost mail.test.tld
  to the generated fetchmailrc?
- most language files need to be updated after applying the patch.
Gingerdog, run
  ./language-update.sh --patch  (in the languages directory) to do this.
File Added: fetchmail-ssloption.unified.diff

----------------------------------------------------------------------

Comment By: GingerDog (gingerdog)
Date: 2008-06-17 23:27

Message:
Logged In: YES 
user_id=1761957
Originator: NO

Hi,
Thanks for the patch; I think the change to upgrade.php really needs to
occur in it's own distinct upgrade function (and there probably needs to be
one for postgresql and mysql).

Hopefully i'll fix this and merge it shortly.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=937966&aid=1995478&group_id=191583