Re: [Postfixadmin-devel] 2.2?

[Christian B. <pos...@cb...>]

Hello,

Am Mittwoch, 23. April 2008 schrieb David Goodwin:
> 2.2.0rc5 packages/downloads are available on sf.net
>
> I'd like to think we'll soon have a 2.2.0 release! Does anyone know
> of any blockers? Can some of you try testing it please?

I installed it on a production server (which was using an early svn 
version before) and instantly found a blocker bug: common.php redirects 
to setup.php if config.inc.php doesn't exist or $CONF['configured'] is 
FALSE.
There's nothing wrong with that - unless you include() upgrade.php, 
which include()s common.php in setup.php ;-)  The result was a nice 
redirect loop from and to setup.php.

Good news: I already fixed this in SVN some hours ago (r343).


I also entered some possible enhancements for the colored markers to the 
tracker - for post-2.2.


> (rc4 didn't include mysql table creation for new installs, which was
> a slight flaw!)

Are you sure? I doubt ;-)

The tables are created in upgrade_5_mysql, which is basically a copy of 
SVN r1 DATABASE_MYSQL.TXT. (Yes, it is intentional that there are some 
ALTER statements before - they cover pre-sourceforge SVN r1 changes.)

And yes, I just tested this with a completely fresh install on a fresh 
database without any existing tables, while having upgrade_1_mysql 
completely commented out.


To be exact, upgrade_2_pgsql should be renamed to upgrade_5_pgsql (I 
assume you used SVN r1 as base?)


I just found out that create mailbox and create admin don't enforce the 
min_password_length - but this isn't a blocker for 2.2. We should 
probably fix this by merging create and edit (see fetchmail for an 
example) after 2.2 is out.


BTW: Don't forget to change the "check for updates" URL when creating 
the 2.2 tarball ;-)

Apropos... - http://postfixadmin.sourceforge.net/update-check.php 
results in a 404 :-(  I have created one that at least redirects to the 
home page - please run SVN up on the webspace (and implement 
update-check.php if you have some time).


Regards,

Christian Boltz
-- 
wer Windows in irgendeiner Form verwendet (ausser
als abschreckendes Beispiel) ist selbst schuld.
[Carsten Becher in suse-linux]