|
From: SourceForge.net <no...@so...> - 2008-04-03 22:24:01
|
Bugs item #1908127, was opened at 2008-03-05 17:30 Message generated for change (Settings changed) made by christian_boltz You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=1908127&group_id=191583 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Interface (example) Group: v 2.1 >Status: Closed Resolution: Out of Date Priority: 5 Private: No Submitted By: Nobody/Anonymous (nobody) Assigned to: Nobody/Anonymous (nobody) Summary: unable to add multiple recipients to an alias Initial Comment: When attempting to add multiple recipients to an alias, the addresses are listed as invalid. I think this is due to adding the \r\n to the text upon submit. I'll work on fixing it in the next couple days and submit a patch if I can. ---------------------------------------------------------------------- Comment By: Christian Boltz (christian_boltz) Date: 2008-04-04 00:09 Message: Logged In: YES user_id=593261 Originator: NO Yes, your patch looks correct - and the SVN version already has the same ;-) I recommend to use the latest SVN revision - it has much more bugs fixed and is currently at 2.2RC state, so it should be nearly production ready (minus the known blocker bugs, but these will not hit you if you have already created the database). ---------------------------------------------------------------------- Comment By: Samuel Abreu de Paula (cartz) Date: 2008-04-03 20:21 Message: Logged In: YES user_id=817632 Originator: NO > If you have a specific reason to stick with 2.1, please tell me. Maybe you > have just found a bug or problem nobody reported yet... I've suffer from the same problem lately, and the reason i stick on 2.1 is (From http://postfixadmin.sourceforge.net/): "Download - Stable release The latest stable release is 2.1.0. You can download it here" I came here to submit this bug, but found this report and im just commenting here. My patch for this is: --- edit-alias.php.bkp 2008-04-03 15:14:29.000000000 -0300 +++ edit-alias.php 2008-04-03 15:21:15.000000000 -0300 @@ -76,11 +76,11 @@ $tMessage = $PALANG['pEdit_alias_goto_text_error1']; } - $goto = preg_replace ('/\\\r\\\n/', ',', $fGoto); - $goto = preg_replace ('/\r\n/', ',', $fGoto); - $goto = preg_replace ('/[\s]+/i', '', $goto); - $goto = preg_replace ('/\,*$/', '', $goto); - $array = preg_split ('/,/', $goto); + $goto = preg_replace ('/\\\r\\\n/', ',', $fGoto); + $goto = preg_replace ('/\r\n/', ',', $goto); + $goto = preg_replace ('/[\s]+/i', '', $goto); + $goto = preg_replace ('/,*$|^,*/', '', $goto); + $goto = preg_replace ('/,,*/', ',', $goto); for ($i = 0; $i < sizeof ($array); $i++) { if (in_array ("$array[$i]", $CONF['default_aliases'])) continue; ---------------------------------------------------------------------- Comment By: Christian Boltz (christian_boltz) Date: 2008-03-06 01:00 Message: Logged In: YES user_id=593261 Originator: NO > Forgot to mention that this has been fixed in the SVN version (2.2). Why don't you update to 2.2 then? It has lots of bugs fixed (see svn log), and backporting all those fixes to 2.1 will basically result in the 2.2 release. OK, you will miss some new features, but still. The current version also includes upgrade.php which does the necessary database changes for existing 2.1 installations. Don't get me wrong - I really like contributions. But I don't see a point in providing patches against 2.1. IMHO, it is nearly impossible to maintain 2.1 because lots of code duplication (yes, I did the cleanup and merge, so I really know what I'm talking about) and, additionally, lack of time. If you want to spend your time on postfixadmin, please work on the current version. I'm quite sure it has some bugs left - fixing those has a greater value :-) If you have a specific reason to stick with 2.1, please tell me. Maybe you have just found a bug or problem nobody reported yet... BTW: Please login to sourceforge before posting. This makes things easier (for example, you will get a mail when a tracker item you opened is updated) and also gives you some kudos for the time you invested ;-) ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2008-03-05 17:31 Message: Logged In: NO Forgot to mention that this has been fixed in the SVN version (2.2). ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=937964&aid=1908127&group_id=191583 |
