#247 Domain drop down broken as domain admin in 1059

Dale Blount

The domain drop down is empty and this shows up in syslog when logged in as a domain admin and "Domain list" is clicked.

PHP Notice: Undefined index: domain in /srv/http/postfixadmin-svn-1059/list-domain.php on line 119

Let me know if I should stop reporting things in the SVN version. I saw a lot of bug reports fixed in SVN since 2.3.3 and no new releases so I'm trying to run SVN.


  • Christian Boltz

    Christian Boltz - 2011-05-22

    Please continue to report bugs in the SVN version - for example, this bug is new to me because I usually test as superadmin ;-) (If you have some PHP knownledge: we also accept patches of course, but we are also happy to "just" get bugreports ;-)

    The reason for not doing a release is that SVN currently doesn't have the quality we want to have for a release. IMHO it's useable (well, as soon as someone fixes this bug) even in production, but there are still several small bugs left that prevent a release.

  • Christian Boltz

    Christian Boltz - 2011-05-22
    • priority: 5 --> 7
  • Dale Blount

    Dale Blount - 2011-05-23

    Possibly related to this bug: the drop down on the "Domain List" page as superadmin lists admin login addresses and not domains.

  • Dale Blount

    Dale Blount - 2011-06-16

    <supa_user> as far as bug 3305307 goes - what is it supposed to do?
    <cboltz> the expected behaviour when logged in as superadmin is:
    <cboltz> display the list of admins, and then limit the domain list to domains that are available to this admin
    <cboltz> (something like "simulate login as admin@customerdomain.com")
    <cboltz> when logged in as domain admin, that behaviour is pointless
    <cboltz> 2.3.x displays a list of domains in the dropdown, but does nothing when you select one
    <cboltz> I tend to hide the dropdown for domain admins
    <supa_user> what if they have several domains?
    <cboltz> that's better than different behaviour for superadmins and domain admins
    <supa_user> or is that not possible?
    <cboltz> the domains are still displayed in the page body
    <cboltz> even if the dropdown isn't there
    <supa_user> the dropdown could be limited to their domains though, right?
    <cboltz> login as superadmin and check what the dropdown does
    <cboltz> (hint: it contains a list of _admins_, not domains - and that is something that is not useful/allowed for domain admins)
    <cboltz> I'd say options are
    <cboltz> a) hide the dropdown for domain admins
    <cboltz> b) only list one admin username: the currently logged

  • Christian Boltz

    Christian Boltz - 2011-07-25

    I just commited your fix from the huge cleanup patch to SVN trunk r1128 :-)

  • Christian Boltz

    Christian Boltz - 2011-07-25
    • status: open --> closed-fixed

Log in to post a comment.