#227 Vacation dates not working

Vacation (31)

The SQL that checks to make sure the vacation is between the start and stop dates is only in one of 3 queries. Here's the patch (against rev 757, but I see the fix isn't in 882 either) to add the SQL conditions to the other two queries.

I'm not sure if this is the most efficient solution, though. Perhaps this logic shouldn't be in the queries at all, and instead maybe the find_real_address() should return the entire record, and have the date range checking done at the end of the script in the main program?

- Colin


  • Colin Viebrock

    Colin Viebrock - 2011-01-06

    Diff to fix date-range checks

  • Christian Boltz

    Christian Boltz - 2011-02-27

    Thanks for the bugreport and your patch!

    I commited it to SVN r970 - and added a TODO note that we should use a function instead of 3 copies of the same query ;-)

  • Christian Boltz

    Christian Boltz - 2011-02-27
    • status: open --> closed-accepted

Log in to post a comment.