#216 vacation.pl typo in debug logging

closed-fixed
nobody
None
5
2010-10-13
2010-10-13
No

Typo in debug logging

Patch as follows:
mailhost:/var/spool/vacation# diff -u vacation.pl.orig vacation.pl
--- vacation.pl.orig 2010-10-13 22:12:03.000000000 +0200
+++ vacation.pl 2010-10-13 22:35:49.000000000 +0200
@@ -325,7 +325,7 @@
# Recipient has vacation
if ($rv == 1) {
$realemail = $email;
- $logger->debug("Found '\$email'\ has vacation active");
+ $logger->debug("Found \'$email\' has vacation active");
} else {
my $vemail = $email;
$vemail =~ s/\@/#/g;

Discussion

  • Christian Boltz

    Christian Boltz - 2010-10-13

    Thanks for your bugreport! This bug qualifies for the "stange quoting of the year" award ;-)

    Unfortunately the first backslash disabled expansion of $email, so "Found '$email' ..." was literally logged. Obviously not really useful ;-)

    The backslashes are not really needed - «'» has no special meaning inside of «"» AFAIK. Therefore I removed the backslashes in the line you mentioned and also some lines below.

    Commited to SVN trunk r875. If we decide to do a 2.3.3 release, it will also contain this fix.

     
  • Christian Boltz

    Christian Boltz - 2010-10-13
    • status: open --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks