#207 Vacation removal doesn't clear out old notifications

open
nobody
Vacation (31)
5
2013-12-01
2010-08-18
No

When you turn off vacation, PFA doesn't remove the list of people who were notified. The next time you enable vacation, those people won't receive the new notifications.

The solution (I think) is to clear the list of notifications each time vacation is enabled. Here's a patch to do that against SVN rev. 856.

Discussion

  • Christian Boltz

    Christian Boltz - 2010-08-22

    I just had a quick look at the code - there's already a DELETE query in line 121 (2.3 branch) / line 126 (trunk) that should in theory do that.
    Your bugreport shows that practise seems to be different ;-) - we'll have to check that...

     
  • maharaja

    maharaja - 2011-06-20

    other possible solutions include:

    1. re-notify if notified_at < activefrom
    2. use vacation.pl to delete all vacation_notified entries where notified_at < activefrom

    btw - this should happen even if interval = 0 !

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks