#189 edit-alias.php backwards in_array arguments

Core (82)

144 if(in_array($orig_alias_list, $fAddress)) {

should be

144 if(in_array($fAddress, $orig_alias_list)) {

and seems to still be this way in the current SVN version. [r816, ln140]

Also, there seems to be a flaw in the logic of this file where if special_alias_control = NO the mailbox alias is removed, but is only restored if alias_control_admin = NO as well which essentially ~does~ let the domain admin control the default mailbox alias by virtue of it being removed if they do not add it back manually.

Lines relevant to the above are 73 and 142 in v2.3, 68 and 138 in SVN r816


  • Christian Boltz

    Christian Boltz - 2010-05-16

    The in_array issue was fixed in SVN r818.

  • Christian Boltz

    Christian Boltz - 2010-05-18
    • priority: 5 --> 7
  • Christian Boltz

    Christian Boltz - 2010-06-22

    logic flaw fixed in SVN r835 - the correct $CONF option is alias_control_admin.
    (special_alias_control handles the $CONF default_aliases like webmaster@ etc.)

    I'll also backport the fix to the 2.3 branch for the upcoming 2.3.1 release.

  • Christian Boltz

    Christian Boltz - 2010-06-22
    • status: open --> closed-fixed

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

No, thanks