#182 Generated passwords are all lowercase and ignore passlength

v_2.3
closed-fixed
nobody
Core (82)
5
2011-04-10
2010-02-25
No

Autogenerated passwords are all lowercase and 8 characters long regardless of $CONF['min_password_length'].
Attached patch creates a password equal in lenght to min_password_length, using numbers, upper and lowercase letters.

Discussion

  • Pierre Fagrell

    Pierre Fagrell - 2010-02-25

    improved generate_password function

     
  • Pierre Fagrell

    Pierre Fagrell - 2010-02-25
    • milestone: --> v_2.3
     
  • Christian Boltz

    Christian Boltz - 2010-03-02

    Thanks for the patch. Unfortunately I get an error message when applying it:
    patch: **** unexpected end of file in patch at line 49
    Can you please re-attach it in unified format (diff -u)?

    BTW: I'd prefer to make the parameter of generate_password optional instead of changing each file that calls it, but that are details ;-)

     
  • Christian Boltz

    Christian Boltz - 2011-04-10
    • status: open --> closed-fixed
     
  • Christian Boltz

    Christian Boltz - 2011-04-10

    I finally found some time to manually apply your patch.

    I also did some small modifications to your code to avoid the additional parameter (generate_password() can read $CONF itself) and replaced $i with usage of strlen().

    Commited to SVN r1026 (trunk) and r1027 (2.3 branch).

     
  • Pierre Fagrell

    Pierre Fagrell - 2011-04-10

    Thanks!

    I never got around to resubmitting the patch, and since it was working I had forgotten about this until today.

     
  • Pierre Fagrell

    Pierre Fagrell - 2011-04-10
    • status: closed-fixed --> open-fixed
     
  • Christian Boltz

    Christian Boltz - 2011-04-10
    • status: open-fixed --> closed-fixed
     

Log in to post a comment.