Update of /cvsroot/popfile/engine/Services
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv6690/Services
Modified Files:
Tag: b0_22_2
IMAP.pm
Log Message:
Major changes:
* refactored the code and created a new module that contains all the IMAP-client code. This makes the IMAP stuff much simpler to maintain.
* added a method that will use only one connection to keep all our folders under control. This new mode is now the default.
* did much work on the IMAP tests. coverage for the client module: 86%, for the IMAP module itself: 58%.
TODO:
* port this to cvs HEAD
* document installation of the new module.
* add yet more tests.
* test in the wild
Index: IMAP.pm
===================================================================
RCS file: /cvsroot/popfile/engine/Services/IMAP.pm,v
retrieving revision 1.9.4.5
retrieving revision 1.9.4.6
diff -C2 -d -r1.9.4.5 -r1.9.4.6
*** IMAP.pm 5 Nov 2007 09:34:25 -0000 1.9.4.5
--- IMAP.pm 11 Nov 2007 16:42:54 -0000 1.9.4.6
***************
*** 2,6 ****
--- 2,8 ----
package Services::IMAP;
use POPFile::Module;
+ use Services::IMAP::Client;
@ISA = ("POPFile::Module");
+ use Carp;
# ----------------------------------------------------------------------------
***************
*** 8,12 ****
[...2353 lines suppressed...]
+ else {
+ $self->log_( 0, "Could not LOGIN." );
+ $self->{imap_error} = 'NO_LOGIN';
+ }
+ }
+ else {
+ $self->log_( 0, "Could not CONNECT to server." );
+ $self->{imap_error} = 'NO_CONNECT';
+ }
+ }
+ else {
+ $self->log_( 0, 'Could not create IMAP object!' );
+ $self->{imap_error} = 'NO_OBJECT';
+ }
+
+ return;
+ }
+
+
+ 1;
|
