From: <jgr...@us...> - 2003-02-27 00:55:28
|
Update of /cvsroot/popfile/engine/UI In directory sc8-pr-cvs1:/tmp/cvs-serv29404/UI Modified Files: HTML.pm Log Message: Fix bug where you couldn't delete magnets with special characters in them; lesson is that you should not call url_encode on form values because the browser will do the URL encoding for you; add the start of a test suite for HTML.pm that does some simple tests on url_encode Index: HTML.pm =================================================================== RCS file: /cvsroot/popfile/engine/UI/HTML.pm,v retrieving revision 1.94 retrieving revision 1.95 diff -C2 -d -r1.94 -r1.95 *** HTML.pm 27 Feb 2003 00:40:15 -0000 1.94 --- HTML.pm 27 Feb 2003 00:55:24 -0000 1.95 *************** *** 1400,1404 **** $body .= "<input type=\"hidden\" name=\"bucket\" value=\"$bucket\" />\n"; $body .= "<input type=\"hidden\" name=\"dtype\" value=\"$type\" />\n"; ! $body .= "<input type=\"hidden\" name=\"dmagnet\" value=\"" . url_encode($self, "$validatingMagnet") . "\" />\n"; $body .= "<input type=\"hidden\" name=\"session\" value=\"$self->{session_key}\" />\n"; $body .= "</form>\n</td>\n"; --- 1400,1404 ---- $body .= "<input type=\"hidden\" name=\"bucket\" value=\"$bucket\" />\n"; $body .= "<input type=\"hidden\" name=\"dtype\" value=\"$type\" />\n"; ! $body .= "<input type=\"hidden\" name=\"dmagnet\" value=\"$validatingMagnet\" />\n"; $body .= "<input type=\"hidden\" name=\"session\" value=\"$self->{session_key}\" />\n"; $body .= "</form>\n</td>\n"; |