[popfile-commit] engine/Proxy POP3.pm,1.117,1.118

[naoki i. <am...@us...>]

Update of /cvsroot/popfile/engine/Proxy
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv9657/Proxy

Modified Files:
	POP3.pm 
Log Message:
Change Log

1. Added new subroutine

  Classifier/Bayes.pm
    is_admin_session    check if the session is admin's

2. Use db_()->quote instead of hardcoded single quotes ("'")

  Classifier/Bayes.pm

3. Fixed almost of the test scripts to pass

  Classifier/Bayes.pm
  Classifier/MailParse.pm

  POPFile/History.pm

  Proxy/POP3.pm

  UI/HTML.pm
  UI/HTTP.pm

  tests/TestBayes.tst
  tests/TestBayesScript.tst
  tests/TestConfiguration.tst
  tests/TestHTML.script
  tests/TestHTML.tst
  tests/TestHistory.tst
  tests/TestMailParse.tst
  tests/TestMailParse015.clr
  tests/TestMailParse019.clr
  tests/TestNihongo002.wrd
  tests/TestNihongo008.wrd
  tests/TestNihongo016.wrd
  tests/TestNihongo017.wrd
  tests/TestNihongo021.qrn

4. Added new tests for the new subroutines

  tests/TestBayes.tst
    get_user_id_from_session
    get_user_name_from_session
    create_user (with cloning)
    initialize_users_password
    change_users_password
    get_user_name_from_id
    is_admin_session

5. Added new tests for the Japanese parsers (internal/MeCab)

  tests/TestMailParse.tst

6. make test now outputs the test results in STDERR instead of STDOUT
7. Snip long results

  tests.pl 


Current state of the test suite:

    TestBayesScript                 PASS
    TestBayes                       PASS
    TestConfiguration               PASS *
    TestHistory                     PASS *
    TestHTML                        PASS *
    TestHTTP                        PASS
    TestIMAP               not tested yet
    TestInsertScript                PASS
    TestLogger                      PASS
    TestMailParse                   PASS
    TestModule                      PASS
    TestMQ                          PASS
    TestMutex                       PASS
    TestPipeScript                  PASS
    TestPOP3                fail (horribly)
    TestProxy                       PASS
    TestWordMangle                  PASS
    TestXMLRPC                      PASS (but child process does not terminate)

    * :  needs to add tests for multi user support

TODO

1. multi user mode tests are needed

  tests/TestConfiguration
  tests/TestHistory
  tests/HTML

Index: POP3.pm
===================================================================
RCS file: /cvsroot/popfile/engine/Proxy/POP3.pm,v
retrieving revision 1.117
retrieving revision 1.118
diff -C2 -d -r1.117 -r1.118
*** POP3.pm	30 Mar 2008 10:22:37 -0000	1.117
--- POP3.pm	5 Apr 2008 16:50:45 -0000	1.118
***************
*** 748,752 ****
      if ( $name eq 'pop3_configuration' ) {
          if ( defined($$form{pop3_port}) ) {
!             if ( ( $$form{pop3_port} >= 1 ) && ( $$form{pop3_port} < 65536 ) ) {
                  $self->config_( 'port', $$form{pop3_port} );
                  $status_message = sprintf( $$language{Configuration_POP3Update}, $self->config_( 'port' ) );
--- 748,752 ----
      if ( $name eq 'pop3_configuration' ) {
          if ( defined($$form{pop3_port}) ) {
!             if ( ( $$form{pop3_port} =~ /^\d+$/ ) && ( $$form{pop3_port} >= 1 ) && ( $$form{pop3_port} < 65536 ) ) {
                  $self->config_( 'port', $$form{pop3_port} );
                  $status_message = sprintf( $$language{Configuration_POP3Update}, $self->config_( 'port' ) );
***************
*** 792,796 ****
  
          if ( defined($$form{sport}) ) {
!             if ( ( $$form{sport} >= 1 ) && ( $$form{sport} < 65536 ) ) {
                  $self->config_( 'secure_port', $$form{sport} );
                  $status_message .= sprintf( $$language{Security_SecurePortUpdate}, $self->config_( 'secure_port' ) );
--- 792,796 ----
  
          if ( defined($$form{sport}) ) {
!             if ( ( $$form{sport} =~ /^\d+$/ ) && ( $$form{sport} >= 1 ) && ( $$form{sport} < 65536 ) ) {
                  $self->config_( 'secure_port', $$form{sport} );
                  $status_message .= sprintf( $$language{Security_SecurePortUpdate}, $self->config_( 'secure_port' ) );