Anyone responsible for committing skins?

Dan Martin
2003-02-20
2003-02-24
  • Dan Martin

    Dan Martin - 2003-02-20

    I've noticed the skins I've put in Patches aren't getting commited.  Should I not be posting them to Patches?  With John stating that the next release may come as early as next week, I'm getting nervous that Lavish and Sleet won't make it.  Especially since they are getting left out of the changes being made to the skins.

     
    • Stanley Krute

      Stanley Krute - 2003-02-20

      Hi Dan

      Sorry about the delay on these.

      I wanted to get to them tonite, but
      I need to do some sleep cycles.

      I've asked David to update them to
      his latest P2 work if he has a chance
      in the next few hours.

      Otherwise I'll do it when I awake.

      /stan

       
      • Stanley Krute

        Stanley Krute - 2003-02-20

        I've sleep-cycled, and am working on
        Sleet now.

        /stan

         
        • Dan Martin

          Dan Martin - 2003-02-20

          Great, thanks Stan.

           
          • Stanley Krute

            Stanley Krute - 2003-02-20

            Hi Dan

            Before I could finish, vrwhoooomshhhh !
            David got most of this done. He's added
            the new accessibility and normalization
            fixes, and worked on validation. I've forwarded
            his tweaks of the files on to you; lemme know
            if you don't receive them.

            Regarding Lavish:

            There are some validation issues remaining
            in Lavish that you will probably want to fix
            yourself. If not, David or I could do it.
            David will be posting a list shortly, if he
            hasn't already.

            Regarding Sleet:

            There are some minor validation
            and browser compatibility issues.

            [a]  hover -- Many skins use this. It's
            not part of CSS-1. It's okay in CSS-2.
            Most browsers support it.

            [b] cursor -- Not part of CSS-1. It's okay in CSS-2.
            Many browsers support it.

            [c] border-collapse -- Not part of CSS-1. It's okay
            in CSS-2. Some browsers support it. Netscape 6.1,
            which I don't have installed, implements it 'poorly',
            according to Top Style Pro 3.

            [d] pointer -- IE 5x does not see this as a valid value
            for cursor. It's quite kosher other than that.

            I think these are all eminently ignorable, and thus
            recommend putting the Sleet into CVS. Unless
            someone screams "nomigawdno", that's what
            I'll do in a wee bit.

            /stan

             
            • David Smith

              David Smith - 2003-02-20

              Actually, a list isn't terribly useful without the file (cause it uses line numbers), and the file is too big to be posting here.  Check <http://www.datasync.com/~dsmith/PopFile/bobbytest-buckets.html> and click on the CSS-1 link at the bottom for the errors.  The updated CSS is at <http://www.datasync.com/~dsmith/PopFile/skins/Lavish.css>

               
              • Dan Martin

                Dan Martin - 2003-02-20

                Hmm, can't view the result from work.  Noticed there's no border-collapse.   I guess I'll find out tonight if you found a work-around.

                 
                • David Smith

                  David Smith - 2003-02-20

                  I didn't do anything with border-collapse.  It's still there in the .shell class.  I did very little in workarounds.  Mainly just tidied it up a little when I went through it, and updated the names.  I didn't want to do anything that would mess with the construction of the layout.

                   
            • Dan Martin

              Dan Martin - 2003-02-20

              It sadly occurs to me that I don't think I validated Lavish.  *raps own knuckles*  I'll clean it up tonight.

              Some issues with CSS-1 vs CSS-2 I don't *personally* see a problem with.  If a browser doesn't honor my cursor style it's not hurting a thing.  Same for hover. 

              Pointer...did I really leave that in there?  Ugh. 

              But, the biggest issue is the border collapse.  Without that statement, these skins look like junk.  And I cannot find a single way around using border-collapse:collapse;.  I've pulled my hair out over that issue.  Love to see an alternative.

              I'll try to clean it up and post it tonight when I get home from work.  Thanks for the help guys.

              -Dan

               
              • Stanley Krute

                Stanley Krute - 2003-02-21

                Hi Dan

                I brought up the little CSS-2-ish nits left
                in Sleet.css (after David tweeked it for
                validation and his fixes) not for them to be
                changed, nor the similar elements in
                Lavish, but just to be thorough.

                /stan
                yep, he's got the anal compulsive thorough thing going on

                 
    • John Graham-Cumming

      Me or stanle_krute.

      I had not done it yet because I had been busy getting other code written and wanted to take some time to look at them because they included GIFs.   I simply haven't looked yet just to make sure that they weren't enormous!

      John.

       
      • Dan Martin

        Dan Martin - 2003-02-20

        The biggest one is 6.75k zipped - not big by my standards, but I suppose it's in the eye of the beholder.

        I know you're all very busy, and I don't mean to pressure you.  Heck, I can't even keep up with all the development on this project.  John, I think when you see Popfile with the Sleet skin, you'll understand my excitement to see it available to the general public, and as an example for other skinners.

         
    • Dan Martin

      Dan Martin - 2003-02-21

      I've posted in Patches a new version of Lavish that validates by the W3C validator.  The only complaint the validator still has is:

      Line : 159 font-family: You are encouraged to offer a generic family as a last alternative

      Um, to be honest I really don't know what they want me to do to fix that.  Obviously this "encouragement" isn't a show stopper, but if it concerns you, tell me what to do about it.

       
      • David Smith

        David Smith - 2003-02-21

        Basicly just put "serif" or "sans-serif" at the end of the font-family list.  If you're using stuff like verdena or ariel, use sans-serif. For Times and courier, use serif.

         
      • Stanley Krute

        Stanley Krute - 2003-02-21

        Hey Dan

        I'm merging your validating version
        with David's kitchen-sink version.

        /stan

         
        • Dan Martin

          Dan Martin - 2003-02-21

          Excellent.  I'm not even sure where to begin with that, so I'm glad you are.  :)

           
        • Stanley Krute

          Stanley Krute - 2003-02-21

          Okey-doke. I've got a merge.

          I've posted it to
          http://SpamTraps.com/validation/skins/Lavish.css

          I've also posted a couple of HTML snapshots:

          http://SpamTraps.com/validation/History_30.html
          http://SpamTraps.com/validation/Buckets_15.html

          The CSS passes the w3c validator.

          Questions for Dan:

          [1] The menubar is wider than the content area
          beneath it. Is that what you'd like ? Or would
          you like me to trim it to the content area's width ?
          Or something else ?

          [2] Do you want to do any further tweaking
          to the skin yourself ? 

          /stan

           
          • Stanley Krute

            Stanley Krute - 2003-02-23

            Hi Dan

            I don't know if you saw these two questions
            Re: Lavish:

            [1] The menubar is wider than the content area
            beneath it. Is that what you'd like ? Or would
            you like me to trim it to the content area's width ?
            Or something else ?

            [2] Do you want to do any further tweaking
            to the skin yourself ?

            If I don't hear anything, I'll just assume the
            answers are yes, no, no, no, and add
            Lavish to CVS as is.

            /stan

             
            • Stanley Krute

              Stanley Krute - 2003-02-24

              Lavish, with David's P3 accessibility tweaks,
              and a few tweaks by me for clearing CSS
              validator warnings, is now in CVS.

              Stan

               
              • Dan Martin

                Dan Martin - 2003-02-24

                Great.  Thanks Stan and David for all your hard work.

                 
      • Stanley Krute

        Stanley Krute - 2003-02-21

        Hi Dan

        In tr.rowOdd, you define background-color twice:

          background-color: #101010;
          background-color: transparent;

        Which would you like ?

        /stan

         
        • Dan Martin

          Dan Martin - 2003-02-21

          >In tr.rowOdd, you define background-color twice:
          Wow, how'd that get past the validator?  It's supposed to be #101010.  Imagine I was doing repeated pasting of the transparent color for the validator.  Sorry about that.

           
          • Stanley Krute

            Stanley Krute - 2003-02-22

            Hi Dan

            > It's supposed to be #101010.

            Thanks !

            /stan

             

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks