This pertains to Michael's "Hide Button" enhancement to the single message page.
I've been testing it with my own skin that is still under development and I notice that the version of it that I have does not replace the colors with the default color for text on this page as supplied in style.css but arbitrarily assigns the color black.
Michael, has this been changed in a later version that I don't have or is it something that your code is incapable of handling?
--
Jim
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Now when you turn colors on Single Message View, the text now matches whatever the skin says it should be--rather than hard coding black. I have tested it with all of the existing skins and it works fine with all of them. (Note, any skins that use their own HTML won't pick up these changes if you use this directory as your default directory.) There aren't that many skins that currently have their own HTML; three if I am not mistaken.
Feedback is welcome, of course.
As you probably know, if you want this to apply to all skins, you should:
1. Save a copy of your existing C:\Program Files\POPFile\skins\default (Windows of course) directory and
2. Place the downloaded file there.
Alternatively, you can just place this folder in your skins directory under any name you choose--but it will not affect any other skins in that case.
For those that care, there is very little code necessary to accomodate different browsers to make this work.
When do you think you'll have something to share of the skin you've been working on?
Michael
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
"When do you think you'll have something to share of the skin you've been working on?"
I'm wanting to revamp the central band of the Buckets page as a part of this skin but that is out of the question right now since there is still code embedded within the Perl portion. I suppose that I can finish polishing the more basic features and then share the result fairly soon.
I've been busy with other matters such as preventing the loss of messages that Cyrus considers to be duplicates but that I do not. There are two cases that I've been looking at. In the first case the message is sent to me up to three different ways (two different lists and direct). In this case it is just a matter that the copy that Cyrus was passing through could not be predicted so my filtering to discard what I can identify as a duplicate caused me to delete what turned out to be the only copy I got (just believe me -- its true). In this case I simply changed my mail client's filtering rules. In the second case the basic headers are the same including the Message-ID but the bodies of the messages bear no relationship to each other. This problem is caused by something that my ISP is doing in the name of service to its clients. I'm still fighting this battle. This is a more important issue than the skin development.
Thank you, Michael, for sharing your latest. I will be looking at it soon.
--
Jim
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
"I'm wanting to revamp the central band of the Buckets page as a part of this skin but that is out of the question right now since there is still code embedded within the Perl portion."
Could you be a bit more specific here? Exactly which part of the html is still embedded?
Manni
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Now that we have two links to that thread, did anybody actually read what Sam had to say? It's true, a template variable will pull in the bar chart, but this variable gets its input from the bar chart template.
Manni
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I am not completely sure I understood what Sam said, but he seemed to have said that the table data is already output with the bar chart. But I think what Jim wants is to modify the display of the data. So building that output would have to be moved out of Perl and into the template.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
The display of the data? The table is in the corpus-page template. The bar chart come from the bar-chart-widget template. Of course, the formatting of the numbers in done in the perl, but the template system couldn't handle that anyway.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Ok. If the construction of that table is in the corpus-page template then we are back to the original question I asked on that other thread. Where are the tables created that display the individual bucket names, message counts, message percentages, false positives, and false negatives? It looked (and still does) to me like the entire table is just poured into place in one "swell foop!" I understood John to be saying that it indeed is a single entity rather than being handled in a loop within the template.
In the skin I'm developing I really want to get ahold of the individual items that are displayed in that table and in the table to the right of it.
I have not yet gotten to the bar charts. I suspect that they will not be a problem for me.
--
Jim
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I'm sorry. I'm a bit handicapped right now because I'm away from my computer; I don't have a text editor, I don't have Perl, heck, I don't even have POPFile here.
The stuff you asked for lives in bar-chart-widget.thtml. I tried to make the widget as flexible as possible, that's why we don't have a fixed number of columns in there. Look at the 'bar_loop_series' loop and things should become a little more clear.
Manni
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I see a <tr> </tr> pair for the <th> </th> pairs but I see nothing for what should be <td> </td> pairs. In other words, I see the headers and the bar chart but not the table of data.
--
Jim
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
An observation regarding your latest update to view-page: The words that are normally colored appear to be bold while the remaining words do not. Aside from that, I don't see a problem.
--
Jim
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I didn't make any changes to the font weight. When I look at the current shipping Default skin, it shows text like so:
<b><font color="darkcyan">Read</font></b> and <b><font color="black">respond</font></b> to this message at: <br><b><font color="darkcyan">https</font></b>://<b><font color="darkcyan">sourceforge<b><font color="black">.net</font></b></font></b>/<b><font color="darkcyan">forum</font></b>/message.<b><font color="darkcyan">php</font></b>?<b><font color="purple">msg</font></b>_id=3060244<br>By: <b><font color="black">jelang</font></b><br><br>An <b><font color="darkcyan">observation</font></b> <b><font color="darkcyan">regarding</font></b> your <b><font color="darkcyan">latest</font></b> <b><font color="black">update</font></b> to <b><font color="black">view</font></b>-<b><font color="green">page</font></b>: The <b><font color="darkcyan">words</font></b> that are<br><b><font color="red">normally</font></b> <b><font color="purple">colored</font></b> <b><font color="purple">appear</font></b> to be <b><font color="darkcyan">bold</font></b> <b><font color="darkcyan">while</font></b> the <b><font color="green">remaining</font></b> <b><font color="darkcyan">words</font></b> do not. <b><font color="black">Aside</font></b> <b><font color="green">from</font></b><br>that, I <b><font color="green">don't</font></b> <b><font color="darkcyan">see</font></b> a <b><font color="darkcyan">problem</font></b>.
Unless something in my install has been corupted, the bold is just the way the current product is built. Personally, I think that works well with the color/on color/off feature I built so that even in B&W there is some contrast between classified text and unclassified text.
Do you not see the bold in your other skins?
Michael
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Excellent, Jim. Thanks for confirming that things are working as I thought. You use Linux correct? I only ask because I'd like to have an idea of where it's been tested.
Michael
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Not only am I running Linux but I also have copied your modified view-page into "my" skin that is still under construction and it works fine there. Don't worry. If I keep it in that skin I'll certainly give you credit for it.
--
Jim
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I've posted a new version of the hide color feature which addresses two sporadic problems that I discovered. I have tested in Firefox 1.0.2, and Mozilla 1.7.5, and IE 6.029x. The code is now also significantly simplier and does no browser or client sniffing.
For those that haven't followed, this change creates two buttons in the Single Message View: Hide Color and Show Color. The first changes all the text to the skin's default text color and the second restores bucket-color coding. I find this very useful becuase sometimes I want to see the bucket color coding, but often I don't and it is just too hard to read the message with it in the way.
I would appreciate any Mac and Linux users testing it and letting me know the results.
Regards,
Michael
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I'm not sure what you mean--but the idea is now that "Hide" copies the text color from whatever skin you are using and applies it to all text so that you don' t see the bucket-color-coding. In this case, the skin defines the text as white on a blue background--I didn't create the skin. My initial implementation hardcoded the color of the body text which wasn't very good for several standard skins so I enhanced it to work with any skin.
Michael
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
FYI, I am using your 03-25 version of view-page.thtml and I find that the hide colors button works with Opera 7.54, Firefox 1.02, and Mozilla 1.7.2 but it does nothing with Konqueror 3.3.0. FWIW, Konqueror also uses black for text that is not associated with any bucket instead of the default color in my skin.
I am getting the impression that in several respects Konqueror is not a well behaved browser. This is not the only place it has jumped up and bit me with regards to the skin I'm working on.
BTW anyone, how would I go about getting screen shots on a Linux system?
--
Jim
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
This pertains to Michael's "Hide Button" enhancement to the single message page.
I've been testing it with my own skin that is still under development and I notice that the version of it that I have does not replace the colors with the default color for text on this page as supplied in style.css but arbitrarily assigns the color black.
Michael, has this been changed in a later version that I don't have or is it something that your code is incapable of handling?
--
Jim
I have not addressed that yet, Jim. It is a problem for many skins and that is the next thing I want to change. I'll keep you posted.
Michael
Jim,
You inspired me.
You can now download http://www.thebiermans.net/popfile/default.zip
Now when you turn colors on Single Message View, the text now matches whatever the skin says it should be--rather than hard coding black. I have tested it with all of the existing skins and it works fine with all of them. (Note, any skins that use their own HTML won't pick up these changes if you use this directory as your default directory.) There aren't that many skins that currently have their own HTML; three if I am not mistaken.
Feedback is welcome, of course.
As you probably know, if you want this to apply to all skins, you should:
1. Save a copy of your existing C:\Program Files\POPFile\skins\default (Windows of course) directory and
2. Place the downloaded file there.
Alternatively, you can just place this folder in your skins directory under any name you choose--but it will not affect any other skins in that case.
For those that care, there is very little code necessary to accomodate different browsers to make this work.
When do you think you'll have something to share of the skin you've been working on?
Michael
"When do you think you'll have something to share of the skin you've been working on?"
I'm wanting to revamp the central band of the Buckets page as a part of this skin but that is out of the question right now since there is still code embedded within the Perl portion. I suppose that I can finish polishing the more basic features and then share the result fairly soon.
I've been busy with other matters such as preventing the loss of messages that Cyrus considers to be duplicates but that I do not. There are two cases that I've been looking at. In the first case the message is sent to me up to three different ways (two different lists and direct). In this case it is just a matter that the copy that Cyrus was passing through could not be predicted so my filtering to discard what I can identify as a duplicate caused me to delete what turned out to be the only copy I got (just believe me -- its true). In this case I simply changed my mail client's filtering rules. In the second case the basic headers are the same including the Message-ID but the bodies of the messages bear no relationship to each other. This problem is caused by something that my ISP is doing in the name of service to its clients. I'm still fighting this battle. This is a more important issue than the skin development.
Thank you, Michael, for sharing your latest. I will be looking at it soon.
--
Jim
"I'm wanting to revamp the central band of the Buckets page as a part of this skin but that is out of the question right now since there is still code embedded within the Perl portion."
Could you be a bit more specific here? Exactly which part of the html is still embedded?
Manni
Manni, look at this thread:
https://sourceforge.net/forum/forum.php?thread_id=1237658&forum_id=248759
--
Jim
This was explained in the UI forum:
https://sourceforge.net/forum/forum.php?thread_id=1237658&forum_id=248759
Oops, didn't see Jim's response.
No problem, Joseph. I'm just pleased that I was able to use Manni's search tool to find the thread successfully. Thanks, Manni.
--
Jim
My pleasure, Jim.
Now that we have two links to that thread, did anybody actually read what Sam had to say? It's true, a template variable will pull in the bar chart, but this variable gets its input from the bar chart template.
Manni
I am not completely sure I understood what Sam said, but he seemed to have said that the table data is already output with the bar chart. But I think what Jim wants is to modify the display of the data. So building that output would have to be moved out of Perl and into the template.
The display of the data? The table is in the corpus-page template. The bar chart come from the bar-chart-widget template. Of course, the formatting of the numbers in done in the perl, but the template system couldn't handle that anyway.
"The table is in the corpus-page template."
Ok. If the construction of that table is in the corpus-page template then we are back to the original question I asked on that other thread. Where are the tables created that display the individual bucket names, message counts, message percentages, false positives, and false negatives? It looked (and still does) to me like the entire table is just poured into place in one "swell foop!" I understood John to be saying that it indeed is a single entity rather than being handled in a loop within the template.
In the skin I'm developing I really want to get ahold of the individual items that are displayed in that table and in the table to the right of it.
I have not yet gotten to the bar charts. I suspect that they will not be a problem for me.
--
Jim
I'm sorry. I'm a bit handicapped right now because I'm away from my computer; I don't have a text editor, I don't have Perl, heck, I don't even have POPFile here.
The stuff you asked for lives in bar-chart-widget.thtml. I tried to make the widget as flexible as possible, that's why we don't have a fixed number of columns in there. Look at the 'bar_loop_series' loop and things should become a little more clear.
Manni
Further explanation of what I'm talking about.
Here is the relevant code as I see it in the corpus-page template:
<td class="settingsPanel" valign="top" width="40%" align="center">
<h2 class="buckets"><TMPL_VAR NAME="Localize_Bucket_EmailsClassifiedUpper"></h2>
<table summary="">
<tr>
<th class="bucketsLabel" scope="col" align="left">
<TMPL_VAR NAME="Localize_Bucket">
</th>
<th>
</th>
<th class="bucketsLabel" scope="col" align="right">
<TMPL_VAR NAME="Localize_Bucket_ClassificationCount">
</th>
<th class="bucketsLabel" scope="col" align="right">
<TMPL_VAR NAME="Localize_Bucket_ClassificationFP">
</th>
<th class="bucketsLabel" scope="col" align="right">
<TMPL_VAR NAME="Localize_Bucket_ClassificationFN">
</th>
</tr>
<TMPL_VAR NAME="Corpus_Bar_Chart_Classification">
</table>
</td>
<td class="settingsPanel" width="40%" valign="top" align="center">
<h2 class="buckets"><TMPL_VAR NAME="Localize_Bucket_WordCounts"></h2>
<table summary="">
<tr>
<th class="bucketsLabel" scope="col" align="left">
<TMPL_VAR NAME="Localize_Bucket">
</th>
<th>
</th>
<th class="bucketsLabel" scope="col" align="right">
<TMPL_VAR NAME="Localize_Bucket_WordCount">
</th>
</tr>
<TMPL_VAR NAME="Corpus_Bar_Chart_Word_Counts">
</table>
</td>
I see a <tr> </tr> pair for the <th> </th> pairs but I see nothing for what should be <td> </td> pairs. In other words, I see the headers and the bar chart but not the table of data.
--
Jim
An observation regarding your latest update to view-page: The words that are normally colored appear to be bold while the remaining words do not. Aside from that, I don't see a problem.
--
Jim
Jim,
I didn't make any changes to the font weight. When I look at the current shipping Default skin, it shows text like so:
<b><font color="darkcyan">Read</font></b> and <b><font color="black">respond</font></b> to this message at: <br><b><font color="darkcyan">https</font></b>://<b><font color="darkcyan">sourceforge<b><font color="black">.net</font></b></font></b>/<b><font color="darkcyan">forum</font></b>/message.<b><font color="darkcyan">php</font></b>?<b><font color="purple">msg</font></b>_id=3060244<br>By: <b><font color="black">jelang</font></b><br><br>An <b><font color="darkcyan">observation</font></b> <b><font color="darkcyan">regarding</font></b> your <b><font color="darkcyan">latest</font></b> <b><font color="black">update</font></b> to <b><font color="black">view</font></b>-<b><font color="green">page</font></b>: The <b><font color="darkcyan">words</font></b> that are<br><b><font color="red">normally</font></b> <b><font color="purple">colored</font></b> <b><font color="purple">appear</font></b> to be <b><font color="darkcyan">bold</font></b> <b><font color="darkcyan">while</font></b> the <b><font color="green">remaining</font></b> <b><font color="darkcyan">words</font></b> do not. <b><font color="black">Aside</font></b> <b><font color="green">from</font></b><br>that, I <b><font color="green">don't</font></b> <b><font color="darkcyan">see</font></b> a <b><font color="darkcyan">problem</font></b>.
Unless something in my install has been corupted, the bold is just the way the current product is built. Personally, I think that works well with the color/on color/off feature I built so that even in B&W there is some contrast between classified text and unclassified text.
Do you not see the bold in your other skins?
Michael
"Do you not see the bold in your other skins?"
The normal color coding makes Bold/Standard relatively insignificant so I had not noticed it.
Thank you for explaining your rationale. It makes sense and since I now know that, I have no issue with that feature.
--
Jim
Excellent, Jim. Thanks for confirming that things are working as I thought. You use Linux correct? I only ask because I'd like to have an idea of where it's been tested.
Michael
Yes, Michael. I do use Linux.
--
Jim
Not only am I running Linux but I also have copied your modified view-page into "my" skin that is still under construction and it works fine there. Don't worry. If I keep it in that skin I'll certainly give you credit for it.
--
Jim
I've posted a new version of the hide color feature which addresses two sporadic problems that I discovered. I have tested in Firefox 1.0.2, and Mozilla 1.7.5, and IE 6.029x. The code is now also significantly simplier and does no browser or client sniffing.
Code: http://www.thebiermans.net/popfile/default.zip
Example: http://www.thebiermans.net/popfile/example.htm
For those that haven't followed, this change creates two buttons in the Single Message View: Hide Color and Show Color. The first changes all the text to the skin's default text color and the second restores bucket-color coding. I find this very useful becuase sometimes I want to see the bucket color coding, but often I don't and it is just too hard to read the message with it in the way.
I would appreciate any Mac and Linux users testing it and letting me know the results.
Regards,
Michael
Michael:
> Example: http://www.thebiermans.net/popfile/example.htm
with those bucket colors and white text on a dark blue background I can see why you need the HIDE/SHOW buttons :-)
Regards ... Alec
I'm not sure what you mean--but the idea is now that "Hide" copies the text color from whatever skin you are using and applies it to all text so that you don' t see the bucket-color-coding. In this case, the skin defines the text as white on a blue background--I didn't create the skin. My initial implementation hardcoded the color of the body text which wasn't very good for several standard skins so I enhanced it to work with any skin.
Michael
Michael,
FYI, I am using your 03-25 version of view-page.thtml and I find that the hide colors button works with Opera 7.54, Firefox 1.02, and Mozilla 1.7.2 but it does nothing with Konqueror 3.3.0. FWIW, Konqueror also uses black for text that is not associated with any bucket instead of the default color in my skin.
I am getting the impression that in several respects Konqueror is not a well behaved browser. This is not the only place it has jumped up and bit me with regards to the skin I'm working on.
BTW anyone, how would I go about getting screen shots on a Linux system?
--
Jim