Upgraded fine on XP. I didn't do much testing though.
We need a more complete release notes this time. Even though code wise, this is a minor update, this is our 1.0 release, we should point out the known issues, required Perl modules, etc. I will go through the old ones and put something together.
Are we using the most recent PDK? Any chance they have improved PerlTray so we don't freeze anymore? That would be a nice thing to avoid for a 1.0 release.
The release notes could use a link to the wiki for setting up IMAP with PF. It certainly is not straight forward especially if you don't know anything about IMAP in the first place. With Gmail now supporting IMAP, there are going to be a lot of new POPFile IMAP users especially with the 1.0 release hopefully getting us some notice.
I am playing with IMAP a little and for the first time using PF IMAP. I haven't actually used PF much lately at all since I use Gmail so much so being able to use it with Gmail will be great. Getting back into the PF UI after so long, I can see a lot of things that need improving that I probably overlooked before.
Reclassifying a message in PF's UI does not move the message on the IMAP server. That should be very clearly pointed out somewhere people will read since that is not obvious. In the UI would actually be best, but at this stage in the release that can wait till 1.1. We need to update the documentation on IMAP since the new and improved IMAP is sort of the key feature of 1.0. Right now all the stuff is in experimental modules. I thought we decided it wasn't experimental anymore. We should include a link to some IMAP instructions in the release notes, but I think we should move them out of the experimental section (or as a short term solution, at least have an initial IMAP landing page that is). I also am unsure what IMAP page would be best to link to.
I think it would be a good idea to suggest that people using the IMAP module run PF without the trayicon. PF freezes will be a lot less noticeable with IMAP because you won't see the cannot connect messages from your mail client.
If delaying this release a bit won't bother anyone, I would like to see about getting some of the skin updates from HEAD. Not template changes, but I did make some improvements to the CSS. If I remember correctly, the changes should be mostly backward compatible or easily fixed. Looking a bit better for 1.0 would be nice. I was saving them for the 0.23 release, but I think 1.0 is important enough. I will look at that today and see how easy it will be. Any thoughts about changing the default skin? Default isn't exactly very pretty.
We could also drop the soon to be unsupported (ugly) skins that were voted out and Klingon language file now. We were already planning that for 0.23 and getting rid of them would improve the impression 1.0 gives people.
Releasing on a Friday probably isn't good for getting the release noticed by the most people. This is really just a minor update (though a good one), but a 1.0 release is an important milestone for any project. I think a Monday release would get more attention.
I should have brought all this up earlier, but we have not had a release lately go out with so few RCs and didn't expect it to move so fast.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I'm not sure because it's a major release and they appear to have changed perlapp (on which perltray is built) a lot. Once I can get the thing to install (installer is crashing on my machine) I'll let you know.
John.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
PerlTray now invokes the new TimeChange() callback whenever the system clock changes. This is important because changes to the system clock does not change the expiration time for any running timers.
The ToolTip() callback was broken in PDK 6.0.2. The documented behavior has been restored. (#42035 ).
The Execute() function used to fail when Win32::OLE was used in a PerlTray application. This has been fixed by making sure that PerlTray always runs code in a single threaded apartment (#45885 ).
It used to be impossible to die() or exit() from inside a Download(), PopupMenu() or ToolTip() callback. These exceptions are no longer trapped and ignored, but will shut down the application now (#43802 ).
Make sure I have the correct Cross Platform Perl Modules. I changes DBD:SQLite to DBD:SQlite2 which I think is correct.
I added a little bit about what PF is to the top of the file. I got it from the our SF.net project summary:
"POPFile is an email classification tool with a Naive Bayes classifier, POP3, SMTP, NNTP proxies and IMAP filter and a web interface. It runs on most platforms and with most email clients."
I added this to the Trayicon text:
"Due to this issue, we suggest users of the IMAP module disable the trayicon since a freeze may go unnoticed more easily than when using a mail client to make POP3 connections."
Do any of the improvements listed in this paragraph apply to all users or is it all just Japanese improvements:
"Other Nihongo changes: performance improvement in analyzing e-mails; the encoded attatchment file names are now decoded; fixed a bug that some e-mail addresses have not been treated as e-mail address; fixed a bug that the history table of the UI have not been showed correctly when invalid characters were used in From, To and Cc headers in Nihongo mode; fixed a bug that shortening Subjects in the history table have not been compatible with Japanese texts."
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
>> Do any of the improvements listed in this paragraph apply to all users or is it all just Japanese improvements: <<
Some of them apply to all users.
So I want to update the section to the following:
Other Nihongo changes: fixed a bug that the history table of the UI
have not been showed correctly when invalid characters were used in
From, To and Cc headers in Nihongo mode; fixed a bug that shortening
Subjects in the history table have not been compatible with Japanesea
texts.
And add a new section:
5. Other improvements
Performance improvement in analyzing e-mails.
The encoded attachment file names are now decoded.
Fixed a bug that some e-mail addresses have not been treated as
e-mail address.
Naoki
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Now that I've got the latest Perl and PDK I've quickly made an RC3 which is just RC3 with the latest exectuables. This is only interesting to Windows folks.
This is not intended to be a real RC, just there if people want to check out the very latest stuff on Windows and see if PerlTray is behaving better, etc.
John.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
If I start PF normally (with no trayicon) I get "The device does not recognize the command" when I try to access the UI. I don't know if that is PF partly working or what. PF does not appear to be running in Task Manager.
Using the Message Capture Utility with the trayicon disabled, it runs but I get this message during PF startup:
ERROR: POPFile needs Perl module POSIX, please install it.
Then I get a bunch of these, though that may be normal:
Use of uninitialized value in string eq at C:\PROGRA~1\POPFile/UI/HTML.pm line 1823.
And finally using Message Capture again with the trayicon turned on:
Can't locate Tie/Hash.pm in @INC (@INC contains: C:\PROGRA~1\POPFile C:/PROGRA~1/POPFile/lib .) at C:/PROGRA~1/POPFile/lib/POSIX.pm line 73.
BEGIN failed--compilation aborted at C:/PROGRA~1/POPFile/lib/POSIX.pm line 73.
Compilation failed in require at C:\PROGRA~1\POPFile/POPFile/MQ.pm line 65.
BEGIN failed--compilation aborted at C:\PROGRA~1\POPFile/POPFile/MQ.pm line 65.
Compilation failed in require at C:\PROGRA~1\POPFile/POPFile/Loader.pm line 392.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Odd. It works on my machine, of course, because I've got the entire Perl setup there. Thanks for taking the time to test this.
The installer doesn't seem to mention installing POSIX anywhere. I think I'll have to wait for Brian to chime in on this, since we've needed the POSIX module for a long time and we must have been installing it up until now.
John.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
>> The installer doesn't seem to mention installing POSIX anywhere <<
Most of the minimal Perl is handled in the installer-SecMinPerl-body.nsh file.
>> I think I'll have to wait for Brian to chime in on this <<
I suspect the problem is that build 822 has some subtle differences from the previous build. This happens quite often. Sometimes files are in different places and sometimes the dependencies change so extra components need to be included.
I will not be able to upgrade to 822 until this evening (too busy with "real life" things this afternoon).
Brian
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
POSIX looks like it's in the same place as before, but I haven't work on the installer in a _long time_. If it had moved, wouldn't I have got an error?
John.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
>> If it had moved, wouldn't I have got an error? <<
Not necessarily. There have been a few cases in the past where a file was split into two parts so the NSIS compiler was quite happy to build the installer but at runtime Perl complained about the missing functions.
Brian
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I checked in the last of the planned skin changes. Please take a look through them and see if you notice anything that looks funny.
Brian, deal with the deleted skins in whatever way you think is best or easiest. The skins will still work relatively well until we release HEAD (formerly the 0.23 branch). We don't HAVE to get rid of them from existing installs now, but we should eventually. But the changes I did were a bit more than I had planned so there will be some very minor issues with the unupdated skins.
The removed skins:
klingon
prjbluegrey
prjsteelbeach
tinydefault
lrclaptop
The last two are so similar to SmallDefault we could just convert people over to SmallDefault. But it is probably easier just to switch everyone back to Default and let them change so whatever you think.
You will also need to deal with the newly added skins:
coolmint
ocean
John, if you want to do an RC without the code for dealing with the skin removals and additions, people can still check out the skin updates. Some of them I rushed a bit so I am not 100% confident in them. I found I had not updated all the skins for 0.23 since I was hoping for a few more to be voted off.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Folks,
Looks like the last RC is good, can people tell me what OSes they've tested on and whether they think it's a go.
John.
Hi John,
I tested on Ubuntu Gutsy and Suse 9.3.
Go!
Manni
Upgraded fine on XP. I didn't do much testing though.
We need a more complete release notes this time. Even though code wise, this is a minor update, this is our 1.0 release, we should point out the known issues, required Perl modules, etc. I will go through the old ones and put something together.
Are we using the most recent PDK? Any chance they have improved PerlTray so we don't freeze anymore? That would be a nice thing to avoid for a 1.0 release.
The release notes could use a link to the wiki for setting up IMAP with PF. It certainly is not straight forward especially if you don't know anything about IMAP in the first place. With Gmail now supporting IMAP, there are going to be a lot of new POPFile IMAP users especially with the 1.0 release hopefully getting us some notice.
I am playing with IMAP a little and for the first time using PF IMAP. I haven't actually used PF much lately at all since I use Gmail so much so being able to use it with Gmail will be great. Getting back into the PF UI after so long, I can see a lot of things that need improving that I probably overlooked before.
Reclassifying a message in PF's UI does not move the message on the IMAP server. That should be very clearly pointed out somewhere people will read since that is not obvious. In the UI would actually be best, but at this stage in the release that can wait till 1.1. We need to update the documentation on IMAP since the new and improved IMAP is sort of the key feature of 1.0. Right now all the stuff is in experimental modules. I thought we decided it wasn't experimental anymore. We should include a link to some IMAP instructions in the release notes, but I think we should move them out of the experimental section (or as a short term solution, at least have an initial IMAP landing page that is). I also am unsure what IMAP page would be best to link to.
I think it would be a good idea to suggest that people using the IMAP module run PF without the trayicon. PF freezes will be a lot less noticeable with IMAP because you won't see the cannot connect messages from your mail client.
If delaying this release a bit won't bother anyone, I would like to see about getting some of the skin updates from HEAD. Not template changes, but I did make some improvements to the CSS. If I remember correctly, the changes should be mostly backward compatible or easily fixed. Looking a bit better for 1.0 would be nice. I was saving them for the 0.23 release, but I think 1.0 is important enough. I will look at that today and see how easy it will be. Any thoughts about changing the default skin? Default isn't exactly very pretty.
We could also drop the soon to be unsupported (ugly) skins that were voted out and Klingon language file now. We were already planning that for 0.23 and getting rid of them would improve the impression 1.0 gives people.
Releasing on a Friday probably isn't good for getting the release noticed by the most people. This is really just a minor update (though a good one), but a 1.0 release is an important milestone for any project. I think a Monday release would get more attention.
I should have brought all this up earlier, but we have not had a release lately go out with so few RCs and didn't expect it to move so fast.
These are all good thoughts. I'll take a look at the Perl/PDK versions.
I'm happy to have the skins brought down from HEAD and drop the ugly skins. Got time to do that?
I agree about pointing to the IMAP pages in the release notes.
John.
If you can wait till Monday, I am pretty sure I can find the time. I will do what I can today so we have more time to make sure its correct.
I can wait.
I just upgraded to the latest Perl (build 822 vs. build 820) and I'm now buying the upgrade of the PDK to 7.0 from 6.0.
John.
Can you tell if they changed anything in PerlTray?
I'm not sure because it's a major release and they appear to have changed perlapp (on which perltray is built) a lot. Once I can get the thing to install (installer is crashing on my machine) I'll let you know.
John.
The release notes say:
--- PerlTray
PerlTray now invokes the new TimeChange() callback whenever the system clock changes. This is important because changes to the system clock does not change the expiration time for any running timers.
The ToolTip() callback was broken in PDK 6.0.2. The documented behavior has been restored. (#42035 ).
The Execute() function used to fail when Win32::OLE was used in a PerlTray application. This has been fixed by making sure that PerlTray always runs code in a single threaded apartment (#45885 ).
It used to be impossible to die() or exit() from inside a Download(), PopupMenu() or ToolTip() callback. These exceptions are no longer trapped and ignored, but will shut down the application now (#43802 ).
http://aspn.activestate.com/ASPN/docs/PDK/7.0/Release.html
John.
Here is a new draft of the Release Notes:
http://popfile.jciv.com/v1.0.0.change.txt
Make sure I have the correct Cross Platform Perl Modules. I changes DBD:SQLite to DBD:SQlite2 which I think is correct.
I added a little bit about what PF is to the top of the file. I got it from the our SF.net project summary:
"POPFile is an email classification tool with a Naive Bayes classifier, POP3, SMTP, NNTP proxies and IMAP filter and a web interface. It runs on most platforms and with most email clients."
I added this to the Trayicon text:
"Due to this issue, we suggest users of the IMAP module disable the trayicon since a freeze may go unnoticed more easily than when using a mail client to make POP3 connections."
Do any of the improvements listed in this paragraph apply to all users or is it all just Japanese improvements:
"Other Nihongo changes: performance improvement in analyzing e-mails; the encoded attatchment file names are now decoded; fixed a bug that some e-mail addresses have not been treated as e-mail address; fixed a bug that the history table of the UI have not been showed correctly when invalid characters were used in From, To and Cc headers in Nihongo mode; fixed a bug that shortening Subjects in the history table have not been compatible with Japanese texts."
Thanks for the release notes updates. The Japanese changes are Japanese only.
John.
>> Do any of the improvements listed in this paragraph apply to all users or is it all just Japanese improvements: <<
Some of them apply to all users.
So I want to update the section to the following:
Other Nihongo changes: fixed a bug that the history table of the UI
have not been showed correctly when invalid characters were used in
From, To and Cc headers in Nihongo mode; fixed a bug that shortening
Subjects in the history table have not been compatible with Japanesea
texts.
And add a new section:
5. Other improvements
Performance improvement in analyzing e-mails.
The encoded attachment file names are now decoded.
Fixed a bug that some e-mail addresses have not been treated as
e-mail address.
Naoki
Now that I've got the latest Perl and PDK I've quickly made an RC3 which is just RC3 with the latest exectuables. This is only interesting to Windows folks.
http://getpopfile.org/popfile-1.0.0RC3.zip
http://getpopfile.org/popfile-1.0.0RC3-windows.zip
This is not intended to be a real RC, just there if people want to check out the very latest stuff on Windows and see if PerlTray is behaving better, etc.
John.
RC3 doesn't work.
If I start PF normally (with no trayicon) I get "The device does not recognize the command" when I try to access the UI. I don't know if that is PF partly working or what. PF does not appear to be running in Task Manager.
Using the Message Capture Utility with the trayicon disabled, it runs but I get this message during PF startup:
ERROR: POPFile needs Perl module POSIX, please install it.
Then I get a bunch of these, though that may be normal:
Use of uninitialized value in string eq at C:\PROGRA~1\POPFile/UI/HTML.pm line 1823.
And finally using Message Capture again with the trayicon turned on:
Can't locate Tie/Hash.pm in @INC (@INC contains: C:\PROGRA~1\POPFile C:/PROGRA~1/POPFile/lib .) at C:/PROGRA~1/POPFile/lib/POSIX.pm line 73.
BEGIN failed--compilation aborted at C:/PROGRA~1/POPFile/lib/POSIX.pm line 73.
Compilation failed in require at C:\PROGRA~1\POPFile/POPFile/MQ.pm line 65.
BEGIN failed--compilation aborted at C:\PROGRA~1\POPFile/POPFile/MQ.pm line 65.
Compilation failed in require at C:\PROGRA~1\POPFile/POPFile/Loader.pm line 392.
Odd. It works on my machine, of course, because I've got the entire Perl setup there. Thanks for taking the time to test this.
The installer doesn't seem to mention installing POSIX anywhere. I think I'll have to wait for Brian to chime in on this, since we've needed the POSIX module for a long time and we must have been installing it up until now.
John.
>> The installer doesn't seem to mention installing POSIX anywhere <<
Most of the minimal Perl is handled in the installer-SecMinPerl-body.nsh file.
>> I think I'll have to wait for Brian to chime in on this <<
I suspect the problem is that build 822 has some subtle differences from the previous build. This happens quite often. Sometimes files are in different places and sometimes the dependencies change so extra components need to be included.
I will not be able to upgrade to 822 until this evening (too busy with "real life" things this afternoon).
Brian
Fair enough.
POSIX looks like it's in the same place as before, but I haven't work on the installer in a _long time_. If it had moved, wouldn't I have got an error?
John.
>> If it had moved, wouldn't I have got an error? <<
Not necessarily. There have been a few cases in the past where a file was split into two parts so the NSIS compiler was quite happy to build the installer but at runtime Perl complained about the missing functions.
Brian
Ah.
I see the issue. Looks like there's a new dependency on Tie::Hash from POSIX.
John.
I'm going to add documentation to the wiki on the weekend. I'll give you a url when I'm done.
Manni
OK, I guess I'm done.
http://popfile.sourceforge.net/wiki/experimentalmodules:imapinstructions
Should get people started.
Manni
OK.
With that is everyone now ready for me to make another RC?
John.
I am working on the last skins now. Will be done very soon.
I checked in the last of the planned skin changes. Please take a look through them and see if you notice anything that looks funny.
Brian, deal with the deleted skins in whatever way you think is best or easiest. The skins will still work relatively well until we release HEAD (formerly the 0.23 branch). We don't HAVE to get rid of them from existing installs now, but we should eventually. But the changes I did were a bit more than I had planned so there will be some very minor issues with the unupdated skins.
The removed skins:
klingon
prjbluegrey
prjsteelbeach
tinydefault
lrclaptop
The last two are so similar to SmallDefault we could just convert people over to SmallDefault. But it is probably easier just to switch everyone back to Default and let them change so whatever you think.
You will also need to deal with the newly added skins:
coolmint
ocean
John, if you want to do an RC without the code for dealing with the skin removals and additions, people can still check out the skin updates. Some of them I rushed a bit so I am not 100% confident in them. I found I had not updated all the skins for 0.23 since I was hoping for a few more to be voted off.
>> Brian, deal with the deleted skins in whatever way you think is best or easiest <<
OK, now that you've finished I'll get all of your changes from CVS and start updating the installer.
Which skin should be used as the default for a clean install?
Are we still going to distribute the klingon language file? (I've not yet checked to see if it is still in CVS).
Brian