Background for Kim: We think the genotype management page needs a bit of text to explain what one does there, because right now it's not super-clear that it's essential for, but only a stop on the way to, curating phenotypes.
Some of the specifics will depend on the outcome of [curation-tool:#826], after Kim & Antonia chat.
If there's a way to supersede the existing "add a genotype" interface for all cases, then yes, go with "Search genotypes" for the left-hand box header (the one currently labeled "Actions").
If it turns out that we have to keep the current "add a genotype" interface (for genotypes with two or more different alleles of the same gene), we'll keep the link on the genotype management page, but try to flag it as something people won't often need to use (link text "Advanced genotype addition" or something to that effect). Might also need a slightly different box header. I'll follow up here or in a new ticket if it comes to that.
That makes sense for now I think, doesn't it? It still has "add a genotype" in there. I'll talk to Antonia soon about the ideas for rearranging the page and then get back to this.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Background for Kim: We think the genotype management page needs a bit of text to explain what one does there, because right now it's not super-clear that it's essential for, but only a stop on the way to, curating phenotypes.
Some of the specifics will depend on the outcome of [curation-tool:#826], after Kim & Antonia chat.
If there's a way to supersede the existing "add a genotype" interface for all cases, then yes, go with "Search genotypes" for the left-hand box header (the one currently labeled "Actions").
If it turns out that we have to keep the current "add a genotype" interface (for genotypes with two or more different alleles of the same gene), we'll keep the link on the genotype management page, but try to flag it as something people won't often need to use (link text "Advanced genotype addition" or something to that effect). Might also need a slightly different box header. I'll follow up here or in a new ticket if it comes to that.
Related
Curation tool: #826
A take-home message --
For now, try this for a top-level summary (below the big "Genotypes for: PMID:nnn" header, above both boxes):
"Search, view, and edit genotypes for phenotype annotation in this session"
Specific things about the "Genotypes used in this session" box:
Add text in box, above genotype table: Click a name or description to view and edit genotype details.
Remove "View ..." link (redundant with hyperlinked name and description)
Add a new link to "Add a phenotype" (goes to same place as "Add a new phenotype for this genotype ..." on a genotype page)
I've added that.
I've made those changes too.
Could you have a look and let me know if you'd like fonts, positions or the text changed?
That makes sense for now I think, doesn't it? It still has "add a genotype" in there. I'll talk to Antonia soon about the ideas for rearranging the page and then get back to this.
changes so far look good - thanks
Can this one close?
I think so -- specific requested changes have been done, and further restructuring can go in a new ticket.
Diff: