Menu ▾ ▴

potential error in Clipper::FixupFirstLefts3()

Discussion Forum
Jan
2017-02-20
2017-02-20

  • Jan

    Jan - 2017-02-20

    Hi,
    Thanks for a great package.
    There is a compile warning that may indicate a typo/mistake:
    in the for loop body of FixupFirstLefts3()
    OutRec outRec = m_PolyOuts[i];
    OutRec     firstLeft = ParseFirstLeft(outRec->FirstLeft);
    if (outRec->Pts && outRec->FirstLeft == OldOutRec)
    outRec->FirstLeft = NewOutRec;
    the local variable firstLeft is initialized, but not referenced. That appears weird as it is return of ParseFirstLeft().
    hope you find time to look into this,
    thanks,
    Jan

    EDIT: It is probably the result of not testing if NewOutRec contains the polygon.
    So I can comment out the line declaring firstLeft, probably.

     

    Last edit: Jan 2017-02-20

  • Angus Johnson

    Angus Johnson - 2017-02-27

    Hi Jan. This was fixed in rev. 498