#2 Don't override CFLAGS in sdl/ and sdl2/

[sergio-br2]

You should use += in CFLAGS and SLFLAGS, instead of =, so the system can use its own default flags in the case of packaging (deb packages for example).

You should not override the compiler used (let the user / packaging guy choose between gcc or clang). CC = gcc and LD = gcc should be removed.

[sergio-br2]

ugh, I removed CC=gcc and got this undefined reference:

cc -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -O -Wall sdl2-config --cflags -I../../source -I../../sourcex -I../../resource -I../../freebios -I../../dependencies/minizip -o Build/PokeMini_BG6.o -c ../../resource/PokeMini_BG6.c
ld -o PokeMini Build/PokeMini_SDL2.o Build/KeybMapSDL2.o Build/ExportBMP.o Build/ExportWAV.o Build/freebios.o Build/PMCommon.o Build/PokeMini.o Build/Multicart.o Build/Hardware.o Build/Video.o Build/Video_x1.o Build/Video_x2.o Build/Video_x3.o Build/Video_x4.o Build/Video_x5.o Build/Video_x6.o Build/CommandLine.o Build/MinxCPU.o Build/MinxCPU_XX.o Build/MinxCPU_CE.o Build/MinxCPU_CF.o Build/MinxCPU_SP.o Build/MinxTimers.o Build/MinxIO.o Build/MinxIRQ.o Build/MinxPRC.o Build/MinxColorPRC.o Build/MinxLCD.o Build/MinxAudio.o Build/UI.o Build/Joystick.o Build/Keyboard.o Build/unzip.o Build/ioapi.o Build/PokeMini_ColorPal.o Build/PokeMini_Font12.o Build/PokeMini_Icons12.o Build/PokeMini_BG2.o Build/PokeMini_BG3.o Build/PokeMini_BG4.o Build/PokeMini_BG5.o Build/PokeMini_BG6.o -O sdl2-config --libs -lm -lz
ld: Build/PMCommon.o: undefined reference to symbol 'strcpy@@GLIBC_2.2.5'
//lib/x86_64-linux-gnu/libc.so.6: error adding symbols: DSO missing from command line
make[1]: *** [PokeMini] Error 1

[JustBurner]

Ok, now the new makefile should handle the flags properly.
If you want optimizations or stripping you need to supply the flags yourself.
Also linking is changed from LD into CC (ran into linking issues when using the linker directly).