From: <iro...@us...> - 2009-10-21 03:59:24
|
Revision: 168 http://pojomatic.svn.sourceforge.net/pojomatic/?rev=168&view=rev Author: iroberts Date: 2009-10-21 03:59:18 +0000 (Wed, 21 Oct 2009) Log Message: ----------- Misc cleanups Modified Paths: -------------- trunk/PojomaticAll/Pojomatic/src/main/java/org/pojomatic/Pojomatic.java trunk/PojomaticAll/Pojomatic/src/main/java/org/pojomatic/annotations/DefaultPojomaticPolicy.java trunk/PojomaticAll/Pojomatic/src/main/java/org/pojomatic/annotations/PojomaticPolicy.java trunk/PojomaticAll/Pojomatic/src/main/java/org/pojomatic/internal/OverridableMethods.java trunk/PojomaticAll/Pojomatic/src/main/java/org/pojomatic/internal/PojomatorImpl.java Modified: trunk/PojomaticAll/Pojomatic/src/main/java/org/pojomatic/Pojomatic.java =================================================================== --- trunk/PojomaticAll/Pojomatic/src/main/java/org/pojomatic/Pojomatic.java 2009-10-21 00:02:46 UTC (rev 167) +++ trunk/PojomaticAll/Pojomatic/src/main/java/org/pojomatic/Pojomatic.java 2009-10-21 03:59:18 UTC (rev 168) @@ -54,7 +54,7 @@ */ public class Pojomatic { - private static SelfPopulatingMap<Class<?>, Pojomator<?>> POJOMATORS = + private final static SelfPopulatingMap<Class<?>, Pojomator<?>> POJOMATORS = new SelfPopulatingMap<Class<?>, Pojomator<?>>() { @Override @SuppressWarnings("unchecked") Modified: trunk/PojomaticAll/Pojomatic/src/main/java/org/pojomatic/annotations/DefaultPojomaticPolicy.java =================================================================== --- trunk/PojomaticAll/Pojomatic/src/main/java/org/pojomatic/annotations/DefaultPojomaticPolicy.java 2009-10-21 00:02:46 UTC (rev 167) +++ trunk/PojomaticAll/Pojomatic/src/main/java/org/pojomatic/annotations/DefaultPojomaticPolicy.java 2009-10-21 03:59:18 UTC (rev 168) @@ -2,7 +2,7 @@ import java.util.Collections; import java.util.EnumSet; -import java.util.Set; +import java.util.Set;import java.util.Arrays; import org.pojomatic.Pojomatic; import org.pojomatic.internal.PropertyRole; @@ -68,9 +68,7 @@ private DefaultPojomaticPolicy(PropertyRole... roles) { Set<PropertyRole> roleSet = EnumSet.noneOf(PropertyRole.class); - for (PropertyRole role: roles) { - roleSet.add(role); - } + roleSet.addAll(Arrays.asList(roles)); this.roles = Collections.unmodifiableSet(roleSet); } Modified: trunk/PojomaticAll/Pojomatic/src/main/java/org/pojomatic/annotations/PojomaticPolicy.java =================================================================== --- trunk/PojomaticAll/Pojomatic/src/main/java/org/pojomatic/annotations/PojomaticPolicy.java 2009-10-21 00:02:46 UTC (rev 167) +++ trunk/PojomaticAll/Pojomatic/src/main/java/org/pojomatic/annotations/PojomaticPolicy.java 2009-10-21 03:59:18 UTC (rev 168) @@ -1,5 +1,6 @@ package org.pojomatic.annotations; +import java.util.Arrays; import java.util.Collections; import java.util.EnumSet; import java.util.Set; @@ -79,9 +80,7 @@ private PojomaticPolicy(PropertyRole... roles) { Set<PropertyRole> roleSet = EnumSet.noneOf(PropertyRole.class); - for (PropertyRole role: roles) { - roleSet.add(role); - } + roleSet.addAll(Arrays.asList(roles)); this.roles = Collections.unmodifiableSet(roleSet); } Modified: trunk/PojomaticAll/Pojomatic/src/main/java/org/pojomatic/internal/OverridableMethods.java =================================================================== --- trunk/PojomaticAll/Pojomatic/src/main/java/org/pojomatic/internal/OverridableMethods.java 2009-10-21 00:02:46 UTC (rev 167) +++ trunk/PojomaticAll/Pojomatic/src/main/java/org/pojomatic/internal/OverridableMethods.java 2009-10-21 03:59:18 UTC (rev 168) @@ -82,8 +82,8 @@ pakage = method.getDeclaringClass().getPackage(); } - String name; - Package pakage; + final String name; + final Package pakage; @Override public int hashCode() { Modified: trunk/PojomaticAll/Pojomatic/src/main/java/org/pojomatic/internal/PojomatorImpl.java =================================================================== --- trunk/PojomaticAll/Pojomatic/src/main/java/org/pojomatic/internal/PojomatorImpl.java 2009-10-21 00:02:46 UTC (rev 167) +++ trunk/PojomaticAll/Pojomatic/src/main/java/org/pojomatic/internal/PojomatorImpl.java 2009-10-21 03:59:18 UTC (rev 168) @@ -262,8 +262,8 @@ private final Class<? extends PojoFormatter> pojoFormatterClass; private static class FormattablePropertyElement { - private PropertyElement propertyElement; - private PropertyFormatter propertyFormatter; + private final PropertyElement propertyElement; + private final PropertyFormatter propertyFormatter; public FormattablePropertyElement( PropertyElement propertyElement, PropertyFormatter propertyFormatter) { This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |