[Pojomatic-commits] SF.net SVN: pojomatic:[100] trunk/Pojomatic/src/test/java/org/pojomatic/ internal/PojomatorImplTest.java

[<iro...@us...>]

Revision: 100
          http://pojomatic.svn.sourceforge.net/pojomatic/?rev=100&view=rev
Author:   iroberts
Date:     2009-04-06 04:51:35 +0000 (Mon, 06 Apr 2009)

Log Message:
-----------
shut up PMD

Modified Paths:
--------------
    trunk/Pojomatic/src/test/java/org/pojomatic/internal/PojomatorImplTest.java

Modified: trunk/Pojomatic/src/test/java/org/pojomatic/internal/PojomatorImplTest.java
===================================================================
--- trunk/Pojomatic/src/test/java/org/pojomatic/internal/PojomatorImplTest.java	2009-04-06 04:50:51 UTC (rev 99)
+++ trunk/Pojomatic/src/test/java/org/pojomatic/internal/PojomatorImplTest.java	2009-04-06 04:51:35 UTC (rev 100)
@@ -68,7 +68,7 @@
 
   @Test public void testPropertyEquals() {
     String s1 = "hello";
-    String s2 = new String(s1); // ensure we are using .equals, and not ==
+    String s2 = copyString(s1); // ensure we are using .equals, and not ==
 
     assertTrue(OBJECT_PROPERTY_POJOMATOR.doEquals(new ObjectProperty(s1), new ObjectProperty(s2)));
     assertFalse(OBJECT_PROPERTY_POJOMATOR.doEquals(
@@ -89,13 +89,17 @@
 
   @Test public void testObjectArrayPropertyEquals() {
     String s1 = "hello";
-    String s2 = new String(s1);
+    String s2 = copyString(s1);
     assertTrue(STRING_ARRAY_PROPERTY_POJOMATOR.doEquals(
       new StringArrayProperty(s1, "goodbye"), new StringArrayProperty(s2, "goodbye")));
     assertFalse(STRING_ARRAY_PROPERTY_POJOMATOR.doEquals(
       new StringArrayProperty(s1, "goodbye"), new StringArrayProperty("goodbye", s1)));
   }
 
+  private String copyString(String s1) {
+    return new String(s1); //NOPMD - we mean to make a copy
+  }
+
   @Test public void testPrimitiveArrayEquals() throws Exception {
     final ObjectProperty nullProperty = new ObjectProperty(null);
     final ObjectProperty objectArrayProperty = new ObjectProperty(new String[] {"foo"});


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.