Re: [podwiki] ::Formatter::pod_link()

[Thomas L. <to...@co...>]

On Fri, Apr 30, 2004 at 08:47:07AM -0500, David A. Bright wrote:
> > finally I found a conflict. the pod_link() method which I changed
> > recently, is in used differently, sometimes as method, sometimes as
> > function:
> 
> OK, I think I have this resolved now. It is always called as method. Now that
> it is consistent, I don't have to have the funky local definitions in the
> individual formatters that do the relay to SUPER::pod_link.

ok, good :)
 
> By the way, I wasn't sure whether to put all the "standard" formatters in the
> Formatter.pm module or put them into separate modules in Podwiki/Formatter (as
> is Tiki). Obviously, I ended up with them inside Formatter, but that does make
> some things a little less consistent (like the registration code). Do you have
> any opinions on that issue? I could pretty easily be swayed either direction.

Yes, I thought about this too, I think it's better to have them
separated. That way you can have separate cvs log entries and cvs
revisions per module and that's what people (and developers) usually
expect to look for a certain module (e.g. if someone finds an error
in one of them).

So, I decided to separate them, and I made it. In addition I added a
standard disclaimer to each sourcefile.

I am not sure about the copyright issue. The disclaimer itself always
refers to my Copyright on PodWiki in its own. If in some cases the
copyright differs from that, I added an "Additional copyright" section
telling that you have the copyright there, e.g. Formatter.pm or Tiki.pm.
Please review what I've done, I'm not sure if it's ok or correct.



regards, Tom

-- 
 Thomas Linden   (http://www.daemon.de/)  tom at co dot daemon dot de
 $_=`perl -v`;s;^.*ll;;s;$^=unpack"u", "'8V]D;')E<```";s;\W;;gs;$/=7*
 ($^=~s;.;;g);%^=map{$_=>1}split//,lc;$_=join$\, (sort keys(%^))[map{
 ord($_)-$/}split//,'1I7E13?@E:7C1A7C=1:35<7C'];s"0(.)" \U$1"g;print;