Re: [pocl-devel] PoCL 1.6 RC1

[Hartmann, O. <oha...@wa...>]

On Thu, 3 Dec 2020 01:27:54 +0000
"Michal Babej (TAU)" <mic...@tu...> wrote:

> Hello all,
> 
> LLVM 11.0 was released, so it's time for a new PoCL release.
> I've created RC1:
> 
> https://github.com/pocl/pocl/releases/tag/v1.6-RC1
> 
> Please test and report your results here:
> https://github.com/pocl/pocl/wiki/Release-testing-of-pocl-1.6
> 
> Regards,
> -- mb
> 

Hello,

there seems a problem with lib/CL/devices/cpuinfo.c.

Compiling the release of POCL 1.6 fails with a "undefined reference", host is
FreeBSD 12-STABLE, amd64, (FreeBSD 12.2-STABLE #53 r368766: Fri Dec 18 18:34:25 CET 2020 amd64),
utilizing LLVM11.

The code seems to lack some necessary type definitions:

--- lib/CL/devices/cpuinfo.c.orig       2020-12-16 14:02:13.000000000 +0100
+++ lib/CL/devices/cpuinfo.c.patched    2020-12-19 10:21:52.546664000 +0100
@@ -415,8 +415,8 @@
    */
   if (!device->vendor_id)
     {
-      f = fopen (pci_bus_root_vendor_file, "r");
-      num_read = fscanf (f, "%x", &device->vendor_id);
+      FILE *f = fopen (pci_bus_root_vendor_file, "r");
+      int num_read = fscanf (f, "%x", &device->vendor_id);
       fclose (f);
       /* no error checking, if it failed we just won't have the info */
     }

Kind regards

O. Hartmann

p.s. It is a pity that cpuinfo.c and so POCL 1.6 is still narrowed down to Linux ...