|
From: Glenn Randers-P. <gl...@co...> - 2007-10-04 12:23:03
|
Libpng-1.2.21 and libpng-1.0.29 have been released and are available at ftp://ftp.simplesystems.org/pub/png/src and at http://libpng.sf.net Fixed various mistakes reported by George Cook and Jeff Phillips: logical vs bitwise NOT in pngrtran.c, bug introduced in 1.2.19 16-bit cheap transparency expansion, bug introduced in 1.2.19 errors with sizeof(unknown_chunk.name), bugs introduced in 1.2.19 <= compare with unsigned var in pngset.c, should be ==. Removed some extraneous typecasts. Fixed potential out-of-bounds read in png_handle_pCAL(), png_handle_sCAL(), png_push_read_tEXt(), png_handle_iTXt(), and png_handle_ztXt() ("flayer" results reported by Tavis Ormandy). Remove some PNG_CONST declarations from pngwutil.c to avoid compiler warnings Revised makefiles to update libpng.pc properly. Glenn |
|
From: <ma...@on...> - 2007-10-04 14:36:53
|
2007/10/4, Glenn Randers-Pehrson <gl...@co...>: > Libpng-1.2.21 and libpng-1.0.29 have been released and are available at > ftp://ftp.simplesystems.org/pub/png/src > and at > http://libpng.sf.net http://libpng.sf.net still has 1.2.20/1.0.28 Best Martin |
|
From: Dimitri <di...@tr...> - 2007-10-04 19:07:48
|
Glenn Randers-Pehrson wrote:
> Libpng-1.2.21 and libpng-1.0.29 have been released and are available at
> [...]
> Fixed various mistakes reported by George Cook and Jeff Phillips:
> logical vs bitwise NOT in pngrtran.c, bug introduced in 1.2.19
> [...]
I think lines 581-582 of pngrtran.c should be:
png_ptr->flags &= ~PNG_FLAG_ROW_INIT;
instead of:
png_ptr->flags &= !(PNG_FLAG_ROW_INIT);
png_ptr->flags &= ~PNG_FLAG_ROW_INIT;
--
Dimitri
|
|
From: Yves P. <yve...@ca...> - 2007-10-04 19:29:31
|
On 4 oct. 07, at 21:07, Dimitri wrote: > I think lines 581-582 of pngrtran.c should be: > png_ptr->flags &= ~PNG_FLAG_ROW_INIT; > instead of: > png_ptr->flags &= !(PNG_FLAG_ROW_INIT); I quickly checked other uses of PNG_FLAG_*: everything looks fine. For the sake of esthetics and uniformity, I'd remove superfluous parenthesis around PNG_FLAG_* constants in pngset.c... Best regards, and many thanks for the hard work, Yves ____________________________________________________________ Dr. Yves Piguet, CEO yve...@ca... Calerga Sarl http://www.calerga.com 35, av. de la Chabliere Home of Sysquake CH 1004 Lausanne # Sysquake 3.6 released! # |
|
From: Glenn Randers-P. <gl...@gm...> - 2007-10-04 20:50:51
|
Libpng-1.2.22beta1 is available at ftp://ftp.simplesystems.org/pub/png-group/src and at http://libpng.sf.net On 10/4/07, Yves Piguet <yve...@ca...> wrote: > On 4 oct. 07, at 21:07, Dimitri wrote: > > > I think lines 581-582 of pngrtran.c should be: > > png_ptr->flags &= ~PNG_FLAG_ROW_INIT; > > instead of: > > png_ptr->flags &= !(PNG_FLAG_ROW_INIT); Fixed in libpng-1.2.22beta1. I thought I had fixed it in libpng-1.2.21 but evidently made a cut-and-paste error. > > I quickly checked other uses of PNG_FLAG_*: everything > looks fine. Thanks > > For the sake of esthetics and uniformity, I'd remove > superfluous parenthesis around PNG_FLAG_* constants in > pngset.c... Done in libpng-1.2.22beta1 |