From: <gl...@co...> - 2010-08-23 21:30:13
|
It would require PNG_USER_DLLFNAME_POSTFIX to be defined in either case, but now I see that that would not be correct. The existing arrangement is OK. Glenn ----- Original Message ----- From: "Simon-Pierre Cadieux" <sim...@me...> To: png...@li... Sent: Monday, August 23, 2010 4:28:32 PM Subject: Re: [png-mng-implement] Fwd: libpng issue [definition of PNG_USER_PRIVATEBUILD] I am not sure I understand what difference that would make. The second block will define PNG_LIBPNG_DLLFNAME_POSTFIX based on PNG_USER_DLLFNAME_POSTFIX whereas the first one verifies that if PNG_USER_DLLFNAME_POSTFIX is defined PNG_USER_PRIVATEBUILD must also defined. Simon-Pierre On 8/23/2010 2:37 PM, Glenn Randers-Pehrson wrote: > I think that in scripts/pngwin.rc these two blocks should > be swapped, so that the test for PNG_USER_PRIVATEBUILD > will occur no matter whether only PNG_USER_DLLFNAME_POSTFIX > or only PNG_LIBPNG_DLLFNAME_POSTFIX, or both, is passed in: > > #if defined(PNG_USER_DLLFNAME_POSTFIX)&& !defined(PNG_USER_PRIVATEBUILD) > # error "PNG_USER_PRIVATEBUILD must be defined as a string describing the\ > custom changes made to the library." > #endif > > /* Prioritize PNG_USER_x over PNG_LIBPNG_x */ > #ifdef PNG_USER_DLLFNAME_POSTFIX > # undef PNG_LIBPNG_DLLFNAME_POSTFIX > # define PNG_LIBPNG_DLLFNAME_POSTFIX PNG_USER_DLLFNAME_POSTFIX > #endif > > Glenn > > ------------------------------------------------------------------------------ > Sell apps to millions through the Intel(R) Atom(Tm) Developer Program > Be part of this innovative community and reach millions of netbook users > worldwide. Take advantage of special opportunities to increase revenue and > speed time-to-market. Join now, and jumpstart your future. > http://p.sf.net/sfu/intel-atom-d2d > _______________________________________________ > png-mng-implement mailing list > png...@li... > https://lists.sourceforge.net/lists/listinfo/png-mng-implement > ------------------------------------------------------------------------------ Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future. http://p.sf.net/sfu/intel-atom-d2d _______________________________________________ png-mng-implement mailing list png...@li... https://lists.sourceforge.net/lists/listinfo/png-mng-implement |