#82 png 1.8.13 does not build against png 1.6.42

[Thomas Klausner]

png 1.6.42 removed PNG_IGNORE_ADLER32 in https://github.com/pnggroup/libpng/pull/514
which leads to

pngcrush.c: In function 'main':
pngcrush.c:5523:46: error: 'PNG_IGNORE_ADLER32' undeclared (first use in this function); did you mean 'PNG_NORETURN'?
                     png_set_option(read_ptr, PNG_IGNORE_ADLER32,
                                              ^~~~~~~~~~~~~~~~~~
                                              PNG_NORETURN
pngcrush.c:5523:46: note: each undeclared identifier is reported only once for each function it appears in

[Thomas Klausner]

That should have been 'pngcrush 1.8.13 does not build against png 1.6.42' in the subject, sorry.

[Nils Philippsen]

There’s a PR on GitHub with a fix (though it’s closed and not applied because the contributor deleted their fork): https://github.com/glennrp/pmt/pull/2

[Thomas Klausner]

In pkgsrc, we just remove the call completely:

--- pngcrush.c.orig     2024-02-01 09:09:19.207140753 +0000
+++ pngcrush.c
@@ -5520,8 +5520,6 @@ int main(int argc, char *argv[])

                      * they were already checked in the pngcrush_measure_idat
                      * function
                      */
-                    png_set_option(read_ptr, PNG_IGNORE_ADLER32,
-                        PNG_OPTION_ON);
                     png_set_crc_action(read_ptr, PNG_CRC_QUIET_USE,
                                        PNG_CRC_QUIET_USE);
                 }