#76 pngcrush -version behavior different in 1.8.12

[Peter Hagen]

This is the output of pngcrush -version with 1.8.11 for me:

pngcrush 1.8.11, uses libpng 1.6.28 and zlib 1.2.11
 Check http://pmt.sf.net/
 for the most recent version.
CPU time decode 0.000000, encode 0.000000, other 0.000002, total 0.000005 sec

In 1.8.12 there is a different output printed and it has an exit code of 1 (instead of 0 previously). Output:

pngcrush 1.8.12, uses libpng 1.6.31 and zlib 1.2.11
 Check http://pmt.sf.net/
 for the most recent version.

usage: pngcrush [options except for -e -d] infile.png outfile.png
       pngcrush -e ext [other options] file.png ...
       pngcrush -d dir/ [other options] file.png ...
       pngcrush -ow [other options] file.png [tempfile.png]
       pngcrush -h or -v -v -h (for help or verbose help) 
       pngcrush -n -v file.png ... (to list chunks)

This breaks trimage for me.

[Glenn Randers-Pehrson]

Your pngcrush has been modified downstream. Where did you get it?
(The pngcrush distributed from here does not say "Check http://pmt.sf.net
for the most recent version.")

[Glenn Randers-Pehrson]

You can try using "pngcrush -v ...." to get the same output (more or less) as pngcrush-1.8.11

[Peter Hagen]

I've used the versions from here (https://sourceforge.net/projects/pmt/files/pngcrush/).

[Glenn Randers-Pehrson]

Did you add the "Check ..for the most recent version" yourself, then? It isn't coming from the pngcrush that I'm distributing.

[Peter Hagen]

...no? :)
I may not have made it clear that I'm talking about "pngcrush -version".

[Glenn Randers-Pehrson]

Ah, thanks. I'll take care of it soon.

Glenn

[Glenn Randers-Pehrson]

Fixed in the GIT repos. Just add "exit (0);" around line 4478
in pngcrush.c until I push 1.8.13 out soon with the fix.
The "CPU time" line will not appear.