Revision: 114
Author: sucknblow
Date: 2006-07-03 11:05:50 -0700 (Mon, 03 Jul 2006)
ViewCVS: http://svn.sourceforge.net/pmplib/?rev=114&view=rev
Log Message:
-----------
Kester's problem seems to be caused by using
--strip-words in conjuction with an mp3 file
that has some tags, but no artist tag.
This lead to a null pointer being dereferenced:
#0 0xb7fe28c3 in ucs2incmp (x=0x0, y=0x8062df8, n=7) at ucs2char.c:198
#1 0xb7fdc83e in gmi_get (info=0x97c5728, filename=0xbfdf1f00,
path_to_music=0x806b190, flag=Variable "flag" is not available.
) at gmi.c:226
#2 0x08049784 in easypmp_database (fl=0xbfdf9004, pmp=0x8068f00,
opt=0xbfdf3f5c, ptr_records=0xbfdf9010, ptr_num_records=0xbfdf900c,
progress=0x804af00 <easypmp_progress>, instance=0x0)
at ../common/database.c:194
#3 0x0804b67d in main (argc=5, argv=0xbfdf90b4) at main.c:330
Modified Paths:
--------------
trunk/lib/gmi/gmi.c
Modified: trunk/lib/gmi/gmi.c
===================================================================
--- trunk/lib/gmi/gmi.c 2006-07-03 06:57:30 UTC (rev 113)
+++ trunk/lib/gmi/gmi.c 2006-07-03 18:05:50 UTC (rev 114)
@@ -220,7 +220,7 @@
}
/* Strip specific words in artist names. */
- if ((flag & GMIF_STRIP_ARTIST) && strip_words) {
+ if ((flag & GMIF_STRIP_ARTIST) && strip_words && info->artist) {
int i;
for (i = 0;i < num_strip_words;++i) {
if (ucs2incmp(info->artist, strip_words[i], ucs2len(strip_words[i])) == 0) {
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|