#48 Fix read problem on SIBO

None
closed-fixed
None
9
2014-07-05
2001-06-29
Jim Hague
No

rfsv16::fread is horribly broken. Using it to read
more 852 bytes at one time will cause data loss.

To be precise, the point in the receiving buffer to
which received data is copied is never advanced. Thus
the buffer will contain the contents of the last
packet read at the start of the buffer, the rest of
the previous packet up to 852 bytes after that if the
last was < 852, and garbage thereafter.

This patch brings the code into line with that in
rfsv32::fread.

Discussion

  • Jim Hague

    Jim Hague - 2001-06-29

    SIBO file read patch

     
  • Jim Hague

    Jim Hague - 2001-06-29
    • priority: 5 --> 9
     
  • Fritz Elfert

    Fritz Elfert - 2001-06-29

    Logged In: YES
    user_id=3401

    Thanks.

    Applied to CVS

     
  • Fritz Elfert

    Fritz Elfert - 2001-06-29
    • assigned_to: nobody --> felfert
    • status: open --> closed-fixed
     
  • Reuben Thomas

    Reuben Thomas - 2014-07-05

    Ticket moved from /p/plptools/patches/3/

     

Log in to post a comment.