From: Joao C. <jc...@fe...> - 2002-01-21 17:10:51
|
On Sunday 20 January 2002 4:00 am, Maurice LeBrun wrote: > Alan W. Irwin writes: > > > | Could somebody please volunteer to do a final comprehensive chec= k > > > | that the C code is ansi-compliant? This would take some release > > > | burden off me. (I think I can recall how to check it, but if th= ere > > > | are warnings, I wouldn't know how to fix up the problems except = for > > > | the // commentary that screws up the Slowaris compiler.) > > > > > > I'm afraid that tk.c, around line 1229, uses some POSIX, non-ansi > > > system calls, such as sigemptyset(), sigaddset() and sigprocmask()= =2E > > > It's only purpose is to "Don't kill plserver on a ^C if > > > pls->server_nokill is set", and can safely be conditionaly compile= d > > > within a #ifndef __STRICT_ANSI__/#endif block. I don't commit thi= s > > > as I'm no ansi/posix expert, and it might be gcc (linux) specific. > > > > > > All other source files compiled OK, except for two warnings in > > > plframe.c. It looks like that fdopen() and fileno() are not ansi > > > compliant? > > > > Thanks very much for that comprehensive check. I am particularly gl= ad > > there are no // commentary issues this time. Could a C expert here = deal > > with the remaining non-ANSI problems that Joao has found? > > There's no problem with non-ANSI, but POSIX, function calls AFAIK. The problem is that the compiler can't find the function prototypes, but=20 worse, the "sigset_t" type does not exists in ansi, and the compilation f= ails. Joao |