From: Alan W. I. <ir...@be...> - 2013-03-12 18:28:25
|
To Phil and Arjen: I have read all your recent e-mails on this subject, and here is a summary of where I think we stand. @Arjen: I ascribe the symptoms you found for my original patch to the static/dynamic inconsistency between the C and C++ run times caused by the known issue with my original patch. So please try my latest patch instead (and especially the variant of it I describe below). > On 2013-03-12 12:08, phil rosenberg wrote: >> Alan, regarding your patch - some good news and some bad. The good news is that the patch now gives the correct flags to provide the static build. >> However the bad news is that it seems to have brocken something in the wxwidgets cmake module. Previously I could use set CXXFLAGS=/DUNICODE /D_UNICODE set CFLAGS=/DUNICODE /D_UNICODE before calling cmake to use unicode. Now if i do this the unicode option is still set in plplot, however the wxWidgets module no longer finds the unicode version of the wxWidgets libraries so I get linker errors for all the examples. This is because wxString is different for unicode and non-unicode builds. @Both: Please try a variant of my latest patch with set(${flag_var} "${${flag_var}}" CACHE STRING "Flags used by the compiler" FORCE) commented out in cmake/modules/plplot.cmake. That line forces the cached form of those variables to have the same contents as the uncached version, but I don't think that is necessary, and forcing cached variables can have some side effects (perhaps like Phil encountered above) which we want to avoid. The only downside of commenting out the above line that I am aware of is a cosmetic one. With that line commented out, CMakeCache.txt will contain the unchanged cached variables (with /MD rather than /MT) , and you will have to look at the exact commands generated by nmake at run time to see whether the /MT flags have been applied properly in all cases. By the way, I think commenting out the above line will make my patch equivalent to Phil's original patch (except that my patch does the changes in the correct location so that the logic doesn't have to be repeated for all the different subdirectories). @Phil: so let me know if there is any difference at all between results for my patch (with the above line commented out) and your original patch. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ |