Since this program came in handy when I wanted to digitize some images (mostly plots), I thought of
contributing to this project in any kind of way.
A while ago I started using a bad smell detector in order to refactor and fix my java projects' source code, so I decided to evaluate this project's code and detect any possible "bad smell".
I created a concise online presentation which includes a short introduction to the bad smell detector's features, the steps I followed throughout the testing and JDeodorant's results (http://slides.com/paulgogoussis/deck-2-3/fullscreen).
My only intention is to help the project and reassure of its source code propriety.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Thank you very much! This is fascinating. I agree with the assessments that you highlighted. Much of the Plot Digitizer code base is nearly 15 years old now and I haven't even reviewed some of the code in many, many years. It is embarrassing how JDeodorant picked out the really stinky code! I may have to install Eclipse and JDeodorant and give it a try myself.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I donwloaded the code (svn checkout through the Eclipse IDE) in order to apply the suggested corrections/fixes, but I cannot commit my changes to any branch. Is there any way to commit to a testing branch so that you can get my modifications?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Since this program came in handy when I wanted to digitize some images (mostly plots), I thought of
contributing to this project in any kind of way.
A while ago I started using a bad smell detector in order to refactor and fix my java projects' source code, so I decided to evaluate this project's code and detect any possible "bad smell".
I created a concise online presentation which includes a short introduction to the bad smell detector's features, the steps I followed throughout the testing and JDeodorant's results (http://slides.com/paulgogoussis/deck-2-3/fullscreen).
My only intention is to help the project and reassure of its source code propriety.
Thank you very much! This is fascinating. I agree with the assessments that you highlighted. Much of the Plot Digitizer code base is nearly 15 years old now and I haven't even reviewed some of the code in many, many years. It is embarrassing how JDeodorant picked out the really stinky code! I may have to install Eclipse and JDeodorant and give it a try myself.
I donwloaded the code (svn checkout through the Eclipse IDE) in order to apply the suggested corrections/fixes, but I cannot commit my changes to any branch. Is there any way to commit to a testing branch so that you can get my modifications?