Thread: [Plib-devel] Re: [Plib-cvs] plib/src/ssg ssgLoadAC.cxx,1.36,1.37
Brought to you by:
sjbaker
Menu
▾
▴
plib-devel
|
From: steve <sjb...@ai...> - 2005-12-07 01:24:39
|
Bram Stolk wrote: > Update of /cvsroot/plib/plib/src/ssg > In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv8823 > > Modified Files: > ssgLoadAC.cxx > Log Message: > Avoid append flag. Fix by Mathias - loader_fd = fopen ( filename, "ra" ) ; + loader_fd = fopen ( filename, "r" ) ; Wooaaahhhhhh. That's not right! The 'a' flag only means 'append' if it's the first character in the mode string. In the second position, it should be ignored. On some systems, an 'a' in the second position means "ASCII" (as opposed to 'b' for binary). I'm sceptical about this patch. |
|
From: Melchior F. <mf...@us...> - 2005-12-07 09:30:40
|
* Bram Stolk -- Wednesday 07 December 2005 10:24 > What happens if you read a file as binary, when in fact it's ascii? You have to deal with both \r and \n. But IIRC I submitted a fix for exactly this problem (r1.31, r1.32), and that although some plib developer claimed that this wouldn't be necessary because the ac3d spec *demands* that line ends are Unix-style. So there should really be no problem. m. |
|
From: Bram S. <br...@sa...> - 2005-12-07 09:42:15
|
Melchior FRANZ wrote: > * Bram Stolk -- Wednesday 07 December 2005 10:24 > >>What happens if you read a file as binary, when in fact it's ascii? > > > You have to deal with both \r and \n. But IIRC I submitted a fix for > exactly this problem (r1.31, r1.32), and that although some plib > developer claimed that this wouldn't be necessary because the ac3d > spec *demands* that line ends are Unix-style. So there should really > be no problem. Ah, ok... This issue has a history, I see. It looked like a no-brainer, but it is not. I'm sorry about that. So, what do you suggest now? Revert it back to "ra" ? Bram > > m. > > > ------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. Do you grep through log files > for problems? Stop! Download the new AJAX search engine that makes > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! > http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click > _______________________________________________ > plib-devel mailing list > pli...@li... > https://lists.sourceforge.net/lists/listinfo/plib-devel -- Bram Stolk, VR Engineer SARA, Amsterdam. tel +31 20 592 3000 "Windows is a 32-bit extension to a 16-bit graphical shell for an 8-bit operating system originally coded for a 4-bit microprocessor by a 2-bit company that can't stand 1 bit of competition." |
|
From: Melchior F. <mf...@us...> - 2005-12-07 09:50:26
|
* Bram Stolk -- Wednesday 07 December 2005 10:42: > > You have to deal with both \r and \n. But IIRC I submitted a fix for > > exactly this problem (r1.31, r1.32), > So, what do you suggest now? Revert it back to "ra" ? No, on the contrary. Mathias has apparently found out that "ra" leads to crashes. It isn't standard, and that ssgLoadAC.cxx wouldn't work without the "a" is (a) unproofed, and (b) unlikely (because the \r&\n issue *has* been dealt with already). Looks like the next release isn't urgent, as FlightGear 0.9.9 has been released without waiting for it, so I think we can wait until someone reports a problem. m. |
|
From: Bram S. <br...@sa...> - 2005-12-07 09:58:38
|
Melchior FRANZ wrote: > * Bram Stolk -- Wednesday 07 December 2005 10:42: > >>>You have to deal with both \r and \n. But IIRC I submitted a fix for >>>exactly this problem (r1.31, r1.32), > > >>So, what do you suggest now? Revert it back to "ra" ? > > > No, on the contrary. Mathias has apparently found out that "ra" leads > to crashes. It isn't standard, and that ssgLoadAC.cxx wouldn't work > without the "a" is (a) unproofed, and (b) unlikely (because the \r&\n > issue *has* been dealt with already). Looks like the next release isn't > urgent, as FlightGear 0.9.9 has been released without waiting for it, > so I think we can wait until someone reports a problem. Ok, thanks for explaining. A shame about missing the FG release though :-( Bram -- Bram Stolk, VR Engineer SARA, Amsterdam. tel +31 20 592 3000 "Windows is a 32-bit extension to a 16-bit graphical shell for an 8-bit operating system originally coded for a 4-bit microprocessor by a 2-bit company that can't stand 1 bit of competition." |
|
From: Melchior F. <mf...@us...> - 2005-12-07 10:23:10
|
* Bram Stolk -- Wednesday 07 December 2005 10:59: > Ok, thanks for explaining. I had missed that "steve" in this thread is *the* Steve. I would have been more hesitant with my comments otherwise. Anyway: * Steve Baker -- Thursday 03 July 2003 05:36: | '.ac' files don't have DOS line endings - even the ones written | by the Windoze version of AC3D. This was in thread "[PATCH] ssg/ssgLoadAC.cxx: fix potential crash; accept DOS line endings", which for some reason isn't in the sf archive. The patch was applied nevertheless. There are probably Windows people subscribed here who can easily test the current version and report any problems. > A shame about missing the FG release though :-( There will be other releases. :-) m. |
|
From: Martin S. <Mar...@mg...> - 2005-12-07 10:43:29
|
Melchior FRANZ wrote: > * Bram Stolk -- Wednesday 07 December 2005 10:59: >> A shame about missing the FG release though :-( > > There will be other releases. :-) Well, for PLIB this still has to be proven .... Martin. -- Unix _IS_ user friendly - it's just selective about who its friends are ! -------------------------------------------------------------------------- |
|
From: Frederic B. <fre...@fr...> - 2005-12-07 13:38:16
|
> > A shame about missing the FG release though :-( > > There will be other releases. :-) Perhaps in the meantime, puAuxList.cxx would find its way to the CVS repo= sitory ? -Fred |
|
From: Bram S. <br...@sa...> - 2005-12-08 09:48:58
|
Frederic Bouvier wrote: >>>A shame about missing the FG release though :-( >> >>There will be other releases. :-) > > > Perhaps in the meantime, puAuxList.cxx would find its way to the CVS repository > ? What's the status on this? Wasn't there an issue that someone forget to check in, and is now having cvs troubles? Bram > > -Fred > > > ------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. Do you grep through log files > for problems? Stop! Download the new AJAX search engine that makes > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! > http://ads.osdn.com/?ad_idv37&alloc_id865&op=click > _______________________________________________ > plib-devel mailing list > pli...@li... > https://lists.sourceforge.net/lists/listinfo/plib-devel -- Bram Stolk, VR Engineer SARA, Amsterdam. tel +31 20 592 3000 "Windows is a 32-bit extension to a 16-bit graphical shell for an 8-bit operating system originally coded for a 4-bit microprocessor by a 2-bit company that can't stand 1 bit of competition." |
|
From: Erik H. <er...@eh...> - 2006-01-06 09:40:53
Attachments:
puAuxList.cxx
|
Bram Stolk wrote: > What's the status on this? I't not yet committed. > Wasn't there an issue that someone forget to check in, and is now > having cvs troubles? Yep, if you would want to do this for me. After that, wouldn't it be time for the new release to happen, that way you might not miss the next release of FlightGear. Erik |
|
From: Frederic B. <fre...@fr...> - 2006-01-06 09:47:47
|
Quoting Erik Hofman : > Bram Stolk wrote: > > > What's the status on this? > > I't not yet committed. > > > Wasn't there an issue that someone forget to check in, and is now > > having cvs troubles? > > Yep, if you would want to do this for me. > > After that, wouldn't it be time for the new release to happen, that way > you might not miss the next release of FlightGear. Erik, to my knowledge, it *is* committed : http://cvs.sourceforge.net/viewcvs.py/plib/plib/src/puAux/puAuxList.cxx?r= ev=3D1.1&view=3Dlog -Fred |
|
From: Erik H. <er...@eh...> - 2006-01-06 09:57:56
|
Frederic Bouvier wrote: > Erik, to my knowledge, it *is* committed : > http://cvs.sourceforge.net/viewcvs.py/plib/plib/src/puAux/puAuxList.cxx?rev=1.1&view=log That's odd, I've first checked this before sending the message and it wasn't according to CVS. But after checking it again I got a conflicting file ??!? Anyhow, it it already committed indeed. Erik |
|
From: Erik H. <er...@eh...> - 2006-01-06 10:13:43
|
It might be a good idea to fix this first: Running automake src/js/Makefile.am:4: UL_BSD does not appear in AM_CONDITIONAL Erik |
|
From: Martin S. <Mar...@mg...> - 2006-01-09 13:25:51
|
Erik Hofman wrote: > After that, wouldn't it be time for the new release to happen, that way > you might not miss the next release of FlightGear. Good idea, but not in this case :-) Last week I was able to build PLIB on FreeBSD, after recent changes I am not. While running 'configure' I see this message: [...] checking for socklen_t... yes configure: creating ./config.status config.status: creating Makefile config.status: error: cannot find input file: Makefile.in I'm currently investigating. Please hold the release back until this obvious bug is fixed, Martin. -- Unix _IS_ user friendly - it's just selective about who its friends are ! -------------------------------------------------------------------------- |
|
From: Norman V. <nh...@ca...> - 2006-01-09 13:32:26
|
Martin Spott writes: > > Last week I was able to build PLIB on FreeBSD, after recent changes I > am not. While running 'configure' I see this message: > > [...] > checking for socklen_t... yes > configure: creating ./config.status > config.status: creating Makefile > config.status: error: cannot find input file: Makefile.in > When working with the CVS files run autogen.sh before configure HTH Norman |
|
From: Martin S. <Mar...@mg...> - 2006-01-09 13:46:47
|
Martin Spott wrote: > I'm currently investigating. Please hold the release back until this > obvious bug is fixed, Now here it is, 'automake19' exits with: src/js/Makefile.am:4: UL_BSD does not appear in AM_CONDITIONAL This error is triggered by the following change: diff ~/CVS/FlightGear/plib/src/js/Makefile.am ./src/js/Makefile.am --- /home/mas/CVS/FlightGear/plib/src/js/Makefile.am Mon Jan 9 14:35:24 2006 +++ ./src/js/Makefile.am Mon Jan 9 14:34:04 2006 @@ -1,5 +1,10 @@ if BUILD_JS +# FIXME set the UL_BSD conditional using AM_CONDITIONAL in configure.ac +if UL_BSD +bin_PROGRAMS = plib-jscal +plib_jscal_SOURCES = jsBSDCal.c +endif lib_LIBRARIES = libplibjs.a include_HEADERS = js.h Does anyone need this ? If not, then I'd suggest to back it out ASAP. Does PLIB have a mailing list that enables me to track CVS changes ? I didn't find such a list Thanks, Martin. -- Unix _IS_ user friendly - it's just selective about who its friends are ! -------------------------------------------------------------------------- |
|
From: Frederic B. <fre...@fr...> - 2006-01-09 13:59:24
|
> Does PLIB have a mailing list that enables me to track CVS changes ? I > didn't find such a list http://sourceforge.net/mailarchive/forum.php?forum_id=3D7201 -Fred |
|
From: Norman V. <nh...@ca...> - 2006-01-09 14:04:56
|
Martin Spott writes: > > Does PLIB have a mailing list that enables me to track CVS changes ? I > didn't find such a list http://lists.sourceforge.net/lists/listinfo/plib-cvs |
|
From: Martin S. <Mar...@mg...> - 2006-01-09 14:17:42
|
"Norman Vine" wrote: > http://lists.sourceforge.net/lists/listinfo/plib-cvs Thanks to you both, Frederic and Norman, Martin. -- Unix _IS_ user friendly - it's just selective about who its friends are ! -------------------------------------------------------------------------- |
|
From: Martin S. <Mar...@mg...> - 2006-01-09 13:58:32
|
Ni Norman ! "Norman Vine" wrote: > When working with the CVS files > run autogen.sh before configure The stock 'autogen.sh' does not work on FreeBSD. I'm typically using this set with FreeBSD for a very long time and I've been happy with it ever since, not only for PLIB but for every package that is required in order to build FlightGear: # ~> libtoolize15 --copy --force; aclocal19 -I .; autoheader259; automake19 -a -i; autoconf259 Cheers, Martin. -- Unix _IS_ user friendly - it's just selective about who its friends are ! -------------------------------------------------------------------------- |
|
From: Jean-Yves L. <jyl...@Fr...> - 2006-01-09 14:09:12
|
On Mon, 9 Jan 2006 13:58:07 +0000 (UTC) Martin Spott <Mar...@mg...> wrote: > "Norman Vine" wrote: >=20 > > When working with the CVS files=20 > > run autogen.sh before configure >=20 > The stock 'autogen.sh' does not work on FreeBSD. I'm typically using > this set with FreeBSD for a very long time and I've been happy with it > ever since, not only for PLIB but for every package that is required > in order to build FlightGear: >=20 > # ~> libtoolize15 --copy --force; aclocal19 -I .; autoheader259; automake= 19 -a -i; autoconf259 Install devel/gnu-autoconf, devel/gnu-automake and devel/gnu-libtool, then add /usr/local/gnu-autotools/bin to your PATH (preferably before /usr/local/bin). It will allow you to use SimGear's and FlightGear's autogen.sh without modifications (I didn't test PLIB's). --=20 Jean-Yves Lefort jyl...@Fr... http://lefort.be.eu.org/ |
|
From: Martin S. <Mar...@mg...> - 2006-01-09 15:10:49
|
Hello Jean-Yves, Jean-Yves Lefort wrote: > Install devel/gnu-autoconf, devel/gnu-automake and devel/gnu-libtool, > then add /usr/local/gnu-autotools/bin to your PATH (preferably before > /usr/local/bin). It will allow you to use SimGear's and FlightGear's > autogen.sh without modifications (I didn't test PLIB's). This sounds like a nice idea but I hope I don't have to install these packages in order to be able to build PLIB after your recent changes !? Do I or could we abandon the change to src/js/Makefile.am ? Cheers, Martin. -- Unix _IS_ user friendly - it's just selective about who its friends are ! -------------------------------------------------------------------------- |
|
From: Jean-Yves L. <jyl...@Fr...> - 2006-01-09 15:53:46
|
On Mon, 9 Jan 2006 15:10:26 +0000 (UTC) Martin Spott <Mar...@mg...> wrote: > Jean-Yves Lefort wrote: >=20 > > Install devel/gnu-autoconf, devel/gnu-automake and devel/gnu-libtool, > > then add /usr/local/gnu-autotools/bin to your PATH (preferably before > > /usr/local/bin). It will allow you to use SimGear's and FlightGear's > > autogen.sh without modifications (I didn't test PLIB's). >=20 > This sounds like a nice idea but I hope I don't have to install these > packages in order to be able to build PLIB after your recent changes !? No, these ports have nothing to do with my changes. > Do I or could we abandon the change to src/js/Makefile.am ? Up to you to decide. --=20 Jean-Yves Lefort jyl...@Fr... http://lefort.be.eu.org/ |
|
From: Martin S. <Mar...@mg...> - 2006-01-11 13:05:18
|
Jean-Yves Lefort wrote: >> Do I or could we abandon the change to src/js/Makefile.am ? > > Up to you to decide. So I'd propose to revert the recent patch to src/js/Makefile.am as long as there's no clean solution, Martin. -- Unix _IS_ user friendly - it's just selective about who its friends are ! -------------------------------------------------------------------------- |
|
From: Mathias <Mat...@gm...> - 2005-12-07 16:40:33
|
Whoow,
What a huge thread for that. The fact that I read my private mail only at h=
ome=20
and not during the daytime takes me totally off such discussions ...
On Mittwoch 07 Dezember 2005 10:50, Melchior FRANZ wrote:
> * Bram Stolk -- Wednesday 07 December 2005 10:42:
> > > You have to deal with both \r and \n. But IIRC I submitted a fix for
> > > exactly this problem (r1.31, r1.32),
> >
> > So, what do you suggest now? Revert it back to "ra" ?
>
> No, on the contrary. Mathias has apparently found out that "ra" leads
> to crashes. It isn't standard, and that ssgLoadAC.cxx wouldn't work
> without the "a" is (a) unproofed, and (b) unlikely (because the \r&\n
> issue *has* been dealt with already). Looks like the next release isn't
> urgent, as FlightGear 0.9.9 has been released without waiting for it,
> so I think we can wait until someone reports a problem.
Almost exactly true, except that credits should be forwarded to my chief Ol=
af=20
=46lebbe who appears to be infected by the flightgear virus by me :)
He just forwarded that to me and I was searching for a plausible explanatio=
n=20
in between breakfast and traveling to work ...
So sorry for the false explanation by me and many thanks for applying!
Greetings
Mathias
=2D-=20
Mathias Fr=F6hlich, email: Mat...@gm...
|
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X