Thread: Re: [Plib-devel] Re: Release !?
Brought to you by:
sjbaker
Menu
▾
▴
plib-devel
|
From: Christopher B. <cx...@ee...> - 2005-11-14 01:02:47
|
Could someone take a look at my proposed patch for ssgLoadBMP.cxx? http://sourceforge.net/tracker/index.php?func=detail&aid=1275291&group_id=382&atid=100382 The problem is that bitmaps are flipped. _Christopher Christopher Brooks (cxh at eecs berkeley edu) University of California Programmer/Analyst Chess/Ptolemy/Trust US Mail: 558 Cory Hall #1770 ph: 510.643.9841 fax:510.642.2739 Berkeley, CA 94720-1770 home: (F-Tu) 707.665.0131 (W-F) 510.655.5480 (office: 400A Cory) -------- * Melchior FRANZ -- Sunday 13 November 2005 23:48: > * steve -- Sunday 13 November 2005 23:44: > > Where is everyone regarding committing patches and such? > > The network patches applied last, a few days ago, crash for me. > I'd revert them. Apart from that everything was fine. (Linux) See thread "netSocket patch" from Fri, 21 Oct 2005 12:38:24 +0200 (applied to net/netSocket.cxx and net/netSocket.h) m. ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Downloa d it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php _______________________________________________ plib-devel mailing list pli...@li... https://lists.sourceforge.net/lists/listinfo/plib-devel -------- |
|
From: Fay J. F C. AFSEO/SK <joh...@eg...> - 2005-11-16 14:23:46
|
Gentlemen, I believe I put the offending piece of code into the "netSocket.cxx" file; I was doing it for somebody else. I don't have the details at my fingertips, but if you check the e-mail traffic from the last week or two you should find a notice of it, including a reference to the person for whom I was doing this. If I remember correctly, I changed something from the person's original patch and asked if I had done it correctly. Apparently I didn't. Definitely the issue needs to be resolved before any release. John F. Fay Technical Fellow, Jacobs/Sverdrup TEAS Group joh...@eg... 850-729-6330 -----Original Message----- From: pli...@li... [mailto:pli...@li...] On Behalf Of Bram Stolk Sent: Wednesday, November 16, 2005 4:31 AM To: pli...@li... Subject: Re: [Plib-devel] Re: Release !? Martin Spott wrote: > Melchior FRANZ wrote: > >>* Melchior FRANZ -- Sunday 13 November 2005 23:48: >> >>>* steve -- Sunday 13 November 2005 23:44: >>> >>>>Where is everyone regarding committing patches and such? >>> >>>The network patches applied last, a few days ago, crash for me. >>>I'd revert them. Apart from that everything was fine. (Linux) >> >>See thread "netSocket patch" from Fri, 21 Oct 2005 12:38:24 +0200 >>(applied to net/netSocket.cxx and net/netSocket.h) > > > Steve, do you think you can have a look at this _before_ end of this > week and issue a release ? The following seems to happen: In version 1.31 an early return was introduced "return (-2);" and "return (-1)" which causes a skipping of the 'remove sockets that had no activity'. My guess is that this could cause an fd of -1 to be used in FD_SET during the next run of select. Offending code is here: (line 405) http://cvs.sourceforge.net/viewcvs.py/plib/plib/src/net/netSocket.cxx?annota te=1.31 Three options: (1) Replace 1.31 with the old 1.30 version, undoing the patch (2) Fix the early return (3) Check for fd==-1 before doing FD_SET I would advice agaist (3) as it masks a problem. For (2), I think it suffices to move the returns down, just before the return num; I tried this: net_echo no longer crashes, and other net examples still work. If you want, I'll commit, but: someone may want to test with a non-trivial fully networked plib app, before the release? Bram > > Thanks, > Martin. -- Bram Stolk, VR Engineer SARA, Amsterdam. tel +31 20 592 3000 "Windows is a 32-bit extension to a 16-bit graphical shell for an 8-bit operating system originally coded for a 4-bit microprocessor by a 2-bit company that can't stand 1 bit of competition." ------------------------------------------------------- This SF.Net email is sponsored by the JBoss Inc. Get Certified Today Register for a JBoss Training Course. Free Certification Exam for All Training Attendees Through End of 2005. For more info visit: http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click _______________________________________________ plib-devel mailing list pli...@li... https://lists.sourceforge.net/lists/listinfo/plib-devel |
|
From: Bram S. <br...@sa...> - 2005-11-16 15:24:09
|
Fay John F Contr AFSEO/SK wrote: > > Definitely the issue needs to be resolved before any release. I committed the change I proposed earlier. I believe the issue to be resolved. If someone still has problems with net/ let me know. A test other than those in examples/src/net would be useful. Bram -- Bram Stolk, VR Engineer SARA, Amsterdam. tel +31 20 592 3000 "Windows is a 32-bit extension to a 16-bit graphical shell for an 8-bit operating system originally coded for a 4-bit microprocessor by a 2-bit company that can't stand 1 bit of competition." |
|
From: Melchior F. <mf...@us...> - 2005-11-16 22:31:38
|
* Bram Stolk -- Wednesday 16 November 2005 16:24: [crash due to broken netSocket code] > I committed the change I proposed earlier. > I believe the issue to be resolved. > If someone still has problems with net/ let me know. Works here in a situation where it crashed before. (Tested with FlightGear UDP & TCP on Linux.) m. |
|
From: Martin S. <Mar...@mg...> - 2005-11-17 22:13:46
|
Melchior FRANZ wrote: > Works here in a situation where it crashed before. > (Tested with FlightGear UDP & TCP on Linux.) Great. Steve, could we have a release now ? :-) Thanks, Martin. -- Unix _IS_ user friendly - it's just selective about who its friends are ! -------------------------------------------------------------------------- |
|
From: steve <sjb...@ai...> - 2005-11-17 22:38:19
|
Martin Spott wrote: > Melchior FRANZ wrote: > > >>Works here in a situation where it crashed before. >>(Tested with FlightGear UDP & TCP on Linux.) > > > Great. Steve, could we have a release now ? :-) Sure - I'll get on to that tomorrow. |
|
From: Fay J. F C. AFSEO/SK <joh...@eg...> - 2005-11-17 22:52:14
|
Hang on, I still need to get the "puAuxList.cxx" file up. Let me send it to Steve offline. John F. Fay Technical Fellow, Jacobs/Sverdrup TEAS Group 850-729-6330 joh...@eg... -----Original Message----- From: pli...@li... [mailto:pli...@li...] On Behalf Of steve Sent: Thursday, November 17, 2005 4:40 PM To: pli...@li... Subject: Re: [Plib-devel] Re: Release !? Martin Spott wrote: > Melchior FRANZ wrote: > > >>Works here in a situation where it crashed before. >>(Tested with FlightGear UDP & TCP on Linux.) > > > Great. Steve, could we have a release now ? :-) Sure - I'll get on to that tomorrow. ------------------------------------------------------- This SF.Net email is sponsored by the JBoss Inc. Get Certified Today Register for a JBoss Training Course. Free Certification Exam for All Training Attendees Through End of 2005. For more info visit: http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click _______________________________________________ plib-devel mailing list pli...@li... https://lists.sourceforge.net/lists/listinfo/plib-devel |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X