Thread: [Plib-devel] Release !?
Brought to you by:
sjbaker
From: Martin S. <Mar...@mg...> - 2005-11-13 17:53:44
|
Hello, as the FlightGear project is heading for a release it would help a lot to have the patches, that accumulated since PLIB-1.8.4, to finalize in a new PLIB release. Does this sound reasonable to you ? Regards, Martin. -- Unix _IS_ user friendly - it's just selective about who its friends are ! -------------------------------------------------------------------------- |
From: steve <sjb...@ai...> - 2005-11-13 22:44:06
|
Martin Spott wrote: > Hello, > as the FlightGear project is heading for a release it would help a lot > to have the patches, that accumulated since PLIB-1.8.4, to finalize in > a new PLIB release. > Does this sound reasonable to you ? Sure - seems like a good idea. Where is everyone regarding committing patches and such? |
From: Melchior F. <mf...@us...> - 2005-11-13 22:50:02
|
* steve -- Sunday 13 November 2005 23:44: > Where is everyone regarding committing patches and such? The network patches applied last, a few days ago, crash for me. I'd revert them. Apart from that everything was fine. (Linux) m. |
From: Melchior F. <mf...@us...> - 2005-11-13 22:53:13
|
* Melchior FRANZ -- Sunday 13 November 2005 23:48: > * steve -- Sunday 13 November 2005 23:44: > > Where is everyone regarding committing patches and such? > > The network patches applied last, a few days ago, crash for me. > I'd revert them. Apart from that everything was fine. (Linux) See thread "netSocket patch" from Fri, 21 Oct 2005 12:38:24 +0200 (applied to net/netSocket.cxx and net/netSocket.h) m. |
From: Martin S. <Mar...@mg...> - 2005-11-16 08:02:11
|
Melchior FRANZ wrote: > * Melchior FRANZ -- Sunday 13 November 2005 23:48: >> * steve -- Sunday 13 November 2005 23:44: >> > Where is everyone regarding committing patches and such? >> >> The network patches applied last, a few days ago, crash for me. >> I'd revert them. Apart from that everything was fine. (Linux) > > See thread "netSocket patch" from Fri, 21 Oct 2005 12:38:24 +0200 > (applied to net/netSocket.cxx and net/netSocket.h) Steve, do you think you can have a look at this _before_ end of this week and issue a release ? Thanks, Martin. -- Unix _IS_ user friendly - it's just selective about who its friends are ! -------------------------------------------------------------------------- |
From: Bram S. <br...@sa...> - 2005-11-16 10:31:31
|
Martin Spott wrote: > Melchior FRANZ wrote: > >>* Melchior FRANZ -- Sunday 13 November 2005 23:48: >> >>>* steve -- Sunday 13 November 2005 23:44: >>> >>>>Where is everyone regarding committing patches and such? >>> >>>The network patches applied last, a few days ago, crash for me. >>>I'd revert them. Apart from that everything was fine. (Linux) >> >>See thread "netSocket patch" from Fri, 21 Oct 2005 12:38:24 +0200 >>(applied to net/netSocket.cxx and net/netSocket.h) > > > Steve, do you think you can have a look at this _before_ end of this > week and issue a release ? The following seems to happen: In version 1.31 an early return was introduced "return (-2);" and "return (-1)" which causes a skipping of the 'remove sockets that had no activity'. My guess is that this could cause an fd of -1 to be used in FD_SET during the next run of select. Offending code is here: (line 405) http://cvs.sourceforge.net/viewcvs.py/plib/plib/src/net/netSocket.cxx?annotate=1.31 Three options: (1) Replace 1.31 with the old 1.30 version, undoing the patch (2) Fix the early return (3) Check for fd==-1 before doing FD_SET I would advice agaist (3) as it masks a problem. For (2), I think it suffices to move the returns down, just before the return num; I tried this: net_echo no longer crashes, and other net examples still work. If you want, I'll commit, but: someone may want to test with a non-trivial fully networked plib app, before the release? Bram > > Thanks, > Martin. -- Bram Stolk, VR Engineer SARA, Amsterdam. tel +31 20 592 3000 "Windows is a 32-bit extension to a 16-bit graphical shell for an 8-bit operating system originally coded for a 4-bit microprocessor by a 2-bit company that can't stand 1 bit of competition." |
From: Martin S. <Mar...@mg...> - 2005-11-14 06:12:34
|
steve wrote: > Where is everyone regarding committing patches and such? FreeBSD is fine, although I didn't test the networking stuff Melchir mentioned, Martin. -- Unix _IS_ user friendly - it's just selective about who its friends are ! -------------------------------------------------------------------------- |
From: Frederic B. <fre...@fr...> - 2005-11-14 16:51:58
|
Selon steve: > Martin Spott wrote: > > Hello, > > as the FlightGear project is heading for a release it would help a lo= t > > to have the patches, that accumulated since PLIB-1.8.4, to finalize i= n > > a new PLIB release. > > Does this sound reasonable to you ? > > Sure - seems like a good idea. > > Where is everyone regarding committing patches and such? puAuxList.cxx is still missing from the puAux directory -Fred |
From: Martin S. <Mar...@mg...> - 2005-11-23 20:09:59
|
Martin Spott wrote: > as the FlightGear project is heading for a release it would help a lot > to have the patches, that accumulated since PLIB-1.8.4, to finalize in > a new PLIB release. Now, I realize that the source tree didn't change for about one week. Wouldn't it be great to pick what's in _now_ and 'sell' it as 1.8.5 !? Thanks, Martin. -- Unix _IS_ user friendly - it's just selective about who its friends are ! -------------------------------------------------------------------------- |
From: Paolo L. <p.l...@ci...> - 2005-11-24 08:42:27
|
Please consider my patch post titled: [Plib-devel] Possible problem in Frustum calculation (new release?) for the new release - it has impact on the correctness of the aspect = ratio, and, if confirmed by your kind analysis, it's a quite serious issue. Furthermore I submitted patches for the 3DS loader and ssgaShapes (completely new Cube generation) time ago, which have been proven not breaking FG by Martin Spott. Could these be considered for inclusion = too? Greetings - Paolo Leoncini > -----Messaggio originale----- > Da: pli...@li...=20 > [mailto:pli...@li...] Per conto di=20 > Martin Spott > Inviato: mercoled=EC 23 novembre 2005 21.09 > A: pli...@li... > Oggetto: Re: [Plib-devel] Release !? >=20 >=20 > Martin Spott wrote: >=20 > > as the FlightGear project is heading for a release it would=20 > help a lot=20 > > to have the patches, that accumulated since PLIB-1.8.4, to=20 > finalize in=20 > > a new PLIB release. >=20 > Now, I realize that the source tree didn't change for about=20 > one week. Wouldn't it be great to pick what's in _now_ and=20 > 'sell' it as 1.8.5 !? >=20 > Thanks, > Martin. > --=20 > Unix _IS_ user friendly - it's just selective about who its=20 > friends are ! > -------------------------------------------------------------- > ------------ >=20 >=20 > ------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. Do you grep=20 > through log files for problems? Stop! Download the new AJAX=20 > search engine that makes searching your log files as easy as=20 > surfing the web. DOWNLOAD SPLUNK!=20 > http://ads.osdn.com/?ad_id=3D7637&alloc_id=3D16865&op=3Dclick > _______________________________________________ > plib-devel mailing list > pli...@li...=20 > https://lists.sourceforge.net/lists/listinfo/plib-devel >=20 |