plib-devel

Re: [Plib-devel] R: Texture loading problems (bmp/rgb)

[Fay J. F Dr C. U. AFSEO/SK <joh...@eg...>]

Paolo,

	It appears that nobody else has stepped forward so I will volunteer
to be the "good will man."  Bring on the patches!

John F. Fay
Technical Fellow
Jacobs/Sverdrup TEAS Group
850-883-1294=20

-----Original Message-----
From: pli...@li...
[mailto:pli...@li...] On Behalf Of Paolo
Leoncini
Sent: Wednesday, November 22, 2006 2:21 AM
To: 'PLIB Developers'
Subject: [Plib-devel] R: Texture loading problems (bmp/rgb)

> -----Messaggio originale-----
> Da: pli...@li...=20
> [mailto:pli...@li...] Per conto=20
> di Jan Reucker
> Inviato: marted=EC 21 novembre 2006 17.49
> A: pli...@li...
> Oggetto: Re: [Plib-devel] Texture loading problems (bmp/rgb)
>=20
[snip]
> I think I'll prepare a patch, but I guess this will breakt 3ds=20
> loading until we also remove the forced bmp texture flipping there...

I can supply the updated ssgload3ds.cxx also including other patches =
that
were tested time ago by someone in the FlightGear dev team but never =
put in
cvs since I'm not an official Plib developer. If agreed I'll send it to =
the
good will man...

> Kind regards,
> Jan R.

Greetings -

Paolo Leoncini


------------------------------------------------------------------------=
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share =
your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=3D=
DEVDEV
_______________________________________________
plib-devel mailing list
pli...@li...
https://lists.sourceforge.net/lists/listinfo/plib-devel

Re: [Plib-devel] R: Texture loading problems (bmp/rgb)

[Fay J. F Dr C. U. AFSEO/SK <joh...@eg...>]

Paolo,

	I have put your changes into SVN.  Please check out a new version
and make sure I have done it right.

John F. Fay
Technical Fellow
Jacobs/Sverdrup TEAS Group
850-883-1294 

-----Original Message-----
From: pli...@li...
[mailto:pli...@li...] On Behalf Of Paolo
Leoncini
Sent: Monday, December 11, 2006 8:22 AM
To: 'PLIB Developers'
Subject: [Plib-devel] R: Texture loading problems (bmp/rgb)

John,
 
following your kind offer, here are the patches for the 3DS loader/writer
against current SVN versions.
 
<snip>

Re: [Plib-devel] R: Texture loading problems (bmp/rgb)

[Fay J. F Dr C. U. AFSEO/SK <joh...@eg...>]

Jan,

	It is done.  As before, please check out the new changes to see if I
have done them correctly.

John F. Fay
Technical Fellow
Jacobs/Sverdrup TEAS Group
850-883-1294 

-----Original Message-----
From: pli...@li...
[mailto:pli...@li...] On Behalf Of Jan Reucker
Sent: Monday, December 11, 2006 1:40 PM
To: pli...@li...
Subject: Re: [Plib-devel] R: Texture loading problems (bmp/rgb)

Am Mon, 11 Dec 2006 15:22:27 +0100 schrieb "Paolo Leoncini"
<p.l...@ci...>:

> John,
>  
> following your kind offer, here are the patches for the 3DS loader/writer
> against current SVN versions.

Hello John,

and here's the matching BMP loader patch. Thanks again for your
kind offer to apply these.

The patch was made against the latest release candidate because I
couldn't access the SVN repo at this time, but nothing has changed
in this file for a long time so the patch should work fine with
the latest SVN revision.

Kind regards,
Jan R.

-- 
Jan Reucker
email: jan dot reucker at web dot de
web:   http://www.reucker-online.de

[Plib-devel] R: R: Texture loading problems (bmp/rgb)

[Paolo L. <p.l...@ci...>]

Thanks a lot.
=20
Jan Reucker (for the BMP loader) and I (for the 3DS loader) are going to
finalize the private thread on the impact of BMP loader patches on the =
3DS
one, then I'll send you the 3DS loader updates.
=20
Greetings -
=20
Paolo
=20
 -----Messaggio originale-----
Da: pli...@li...
[mailto:pli...@li...] Per conto di Fay John =
F Dr
CTR USAF AFSEO/SK
Inviato: marted=EC 28 novembre 2006 15.16
A: 'PLIB Developers'
Oggetto: Re: [Plib-devel] R: Texture loading problems (bmp/rgb)



Paolo,=20

        It appears that nobody else has stepped forward so I will =
volunteer
to be the "good will man."  Bring on the patches!

John F. Fay=20
Technical Fellow=20
Jacobs/Sverdrup TEAS Group=20
850-883-1294=20

-----Original Message-----=20
From: pli...@li...
[mailto:pli...@li...] On Behalf Of Paolo
Leoncini

Sent: Wednesday, November 22, 2006 2:21 AM=20
To: 'PLIB Developers'=20
Subject: [Plib-devel] R: Texture loading problems (bmp/rgb)=20

> -----Messaggio originale-----=20
> Da: pli...@li...=20
> [mailto:pli...@li...] Per conto=20
> di Jan Reucker=20
> Inviato: marted=EC 21 novembre 2006 17.49=20
> A: pli...@li...=20
> Oggetto: Re: [Plib-devel] Texture loading problems (bmp/rgb)=20
>=20
[snip]=20
> I think I'll prepare a patch, but I guess this will breakt 3ds=20
> loading until we also remove the forced bmp texture flipping there...=20

I can supply the updated ssgload3ds.cxx also including other patches =
that=20
were tested time ago by someone in the FlightGear dev team but never put =
in=20
cvs since I'm not an official Plib developer. If agreed I'll send it to =
the=20
good will man...=20

> Kind regards,=20
> Jan R.=20

Greetings -=20

Paolo Leoncini=20


-------------------------------------------------------------------------=
=20
Take Surveys. Earn Cash. Influence the Future of IT=20
Join SourceForge.net's Techsay panel and you'll get the chance to share =
your

opinions on IT & business topics through brief surveys - and earn cash=20
http://www.techsay.com/default.php?page=3Djoin.php
<http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=3D=
DEVDEV>
&p=3Dsourceforge&CID=3DDEVDEV=20
_______________________________________________=20
plib-devel mailing list=20
pli...@li...=20
https://lists.sourceforge.net/lists/listinfo/plib-devel=20

Re: [Plib-devel] R: Texture loading problems (bmp/rgb)

[Martin S. <Mar...@mg...>]

"Paolo Leoncini" wrote:

> Main modifications dealed the following points:
> 
> 
> ssgLoad3DS.cxx:
> 
> 1. removal of the y-tex coord flipping for BMPs - harmful after the Jan
> Reucker's patch to the BMP loader;
> 
> 2. support for the $$$DUMMY object name - it is part of the "standard"
> format definition, and occurs sometime in actual data files; when not
> managed it invalidates hierarchy reconstruction;
> 
> 3. split of large objects in leaves of max 10922 triangles each - in such a
> way that each vertex index doesn't exceed sizeof(short), putting in crisis
> SSG geom get functions;

I guess something's missing here - unfortunately I can't remember where
this 'min' is being declared:

make[2]: Entering directory `/usr/local/src/plib/src/ssg'
x86_64-linux-g++-3.4 -O3 -march=opteron -DPACKAGE_NAME=\"\"
  -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\"
  -DPACKAGE_BUGREPORT=\"\" -DPACKAGE=\"plib\" -DVERSION=\"1.8.4\"
  -DHAVE_LIBPTHREAD=1 -DHAVE_LIBGL=1 -DHAVE_LIBDL=1 -DSTDC_HEADERS=1
  -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1
  -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1
  -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -I. -I. 
  -I../../src/sg -I../../src/util -I/opt/gnu/include -I/usr/local/include
  -I/usr/X11R6/include -g -O2 -Wall -c ssgLoad3ds.cxx
ssgLoad3ds.cxx: In function `int parse_face_list(unsigned int)':
ssgLoad3ds.cxx:837: error: `min' undeclared (first use this function)
ssgLoad3ds.cxx:837: error: (Each undeclared identifier is reported only once for each function it appears in.)
ssgLoad3ds.cxx: In function `int parse_face_materials(unsigned int)':
ssgLoad3ds.cxx:1040: error: `min' undeclared (first use this function)
ssgLoad3ds.cxx: At global scope:
ssgLoad3ds.cxx:1117: warning: 'last_structure_id' defined but not used
make[2]: *** [ssgLoad3ds.o] Error 1


Martin.
-- 
 Unix _IS_ user friendly - it's just selective about who its friends are !
--------------------------------------------------------------------------

[Plib-devel] R: R: Texture loading problems (bmp/rgb)

[Paolo L. <p.l...@ci...>]

> -----Messaggio originale-----
> Da: pli...@li...=20
> [mailto:pli...@li...] Per conto=20
> di Martin Spott
> Inviato: marted=EC 12 dicembre 2006 11.25
> A: pli...@li...
> Oggetto: Re: [Plib-devel] R: Texture loading problems (bmp/rgb)
>=20
>=20
> "Paolo Leoncini" wrote:
>=20
> > Main modifications dealed the following points:
> >=20
> >=20
> > ssgLoad3DS.cxx:
> >=20
> > 1. removal of the y-tex coord flipping for BMPs - harmful after the=20
> > Jan Reucker's patch to the BMP loader;
> >=20
> > 2. support for the $$$DUMMY object name - it is part of the=20
> "standard"=20
> > format definition, and occurs sometime in actual data=20
> files; when not=20
> > managed it invalidates hierarchy reconstruction;
> >=20
> > 3. split of large objects in leaves of max 10922 triangles=20
> each - in=20
> > such a way that each vertex index doesn't exceed sizeof(short),=20
> > putting in crisis SSG geom get functions;
>=20
> I guess something's missing here - unfortunately I can't=20
> remember where this 'min' is being declared:
>=20
> make[2]: Entering directory `/usr/local/src/plib/src/ssg'=20
> x86_64-linux-g++-3.4 -O3 -march=3Dopteron -DPACKAGE_NAME=3D\"\"
>   -DPACKAGE_TARNAME=3D\"\" -DPACKAGE_VERSION=3D\"\" =
-DPACKAGE_STRING=3D\"\"
>   -DPACKAGE_BUGREPORT=3D\"\" -DPACKAGE=3D\"plib\" =
-DVERSION=3D\"1.8.4\"
>   -DHAVE_LIBPTHREAD=3D1 -DHAVE_LIBGL=3D1 -DHAVE_LIBDL=3D1 =
-DSTDC_HEADERS=3D1
>   -DHAVE_SYS_TYPES_H=3D1 -DHAVE_SYS_STAT_H=3D1 -DHAVE_STDLIB_H=3D1
>   -DHAVE_STRING_H=3D1 -DHAVE_MEMORY_H=3D1 -DHAVE_STRINGS_H=3D1
>   -DHAVE_INTTYPES_H=3D1 -DHAVE_STDINT_H=3D1 -DHAVE_UNISTD_H=3D1 -I. =
-I.=20
>   -I../../src/sg -I../../src/util -I/opt/gnu/include=20
> -I/usr/local/include
>   -I/usr/X11R6/include -g -O2 -Wall -c ssgLoad3ds.cxx
> ssgLoad3ds.cxx: In function `int parse_face_list(unsigned int)':
> ssgLoad3ds.cxx:837: error: `min' undeclared (first use this function)
> ssgLoad3ds.cxx:837: error: (Each undeclared identifier is=20
> reported only once for each function it appears in.)
> ssgLoad3ds.cxx: In function `int parse_face_materials(unsigned int)':
> ssgLoad3ds.cxx:1040: error: `min' undeclared (first use this function)
> ssgLoad3ds.cxx: At global scope:
> ssgLoad3ds.cxx:1117: warning: 'last_structure_id' defined but not used
> make[2]: *** [ssgLoad3ds.o] Error 1

Sorry, my fault. The include hierarchy here is:
ssgLoad3ds.cxx
- ssglocal.h=20
-- ssg.h=20
--- sg.h=20
---- ul.h
Under Win32/MSVC
----- windows.h
------ windef.h (which contains the min() macro)

For a local solution I kindly ask someone to apply the attached patch.

A general solution could be adding the two classic min/max macros in =
ul.h
once for all:

#define ulMax(a,b)	((a)>(b)?(a):(b))
#define ulMin(a,b)	((a)<(b)?(a):(b))

Furthermore still regarding the UL, by preceeding the windows.h include =
by
the symbol definition

WIN32_LEAN_AND_MEAN

makes such include much lighter, i.e. avoids including most of the =
non-basic
Windows declarations, which Plib does not need anyway.

> Martin.

Greetings -

Paolo