plib-devel

[Plib-devel] OpenGL 2.0

[Fay J. F C. AAC/W. <joh...@eg...>]

Gentlemen,

	I read on the "www.opengl.org" web site today that OpenGL 2.0 was
released last Tuesday.  I've not been following this.  Does it have any
relevance to us?  Or do we need to wait until somebody releases an
implementation of it?  Or has that already been done?

John F. Fay
joh...@eg...
850-729-6330 

[Plib-devel] A Second Look Into SSG

[Fay J. F C. AAC/W. <joh...@eg...>]

Gentlemen,

	I have been looking a bit farther into SSG and have some more
comments.

Trivial:

(1) More tabs that should be blank spaces in ssgSimpleState.cxx:545;
ssgStateSelector.cxx:44-46, 83; ssgVtxTable.cxx:31-56, 66-126, 319-322,
363-383, 418, 447-452, 796-798, 810-819

(2) In "ssgEntity.cxx" on lines 117 and 131, the words "gimbles,"
"seperate," and "seperated" should be "gimbals," "separate," and
"separated."

(3) In "ssgLeaf.cxx" we may want to check the indentation of lines 36, 51,
and 53 (two spaces instead of the usual four).

(4) In "ssgVtxTable.cxx" on lines 46-47 the same test is repeated.

(5) In "ssgVtxTable.cxx" on line 314, should we account for the GL_POINTS,
GL_LINES, GL_LINE_LOOP, and GL_LINE_STRIP cases inside the "switch"
statement?

Less Trivial:

(6) In "ssgEntity.cxx" on lines 80ff, the local variable "spherebotch" is
set to a pseudorandom (but repeatable) value from zero to nine and
incremented through a "switch" statement.  This is strange; each entity will
get its own value from zero to nine, but the same entity will always get the
same value.  Further, "spherebotch" is incremented on line 82 and reset to
zero on line 92.  It will be reinitialized each time through the function.
It should be added to the private variables of the "ssgEntity" class.

(7) In "ssgEntity.cxx" on line 432, we set the variable "bsphere_is_invalid"
to true.  Do we want to call "dirtyBSphere" instead, so that we set the
parent entities' b-spheres dirty as well?

(8) In "ssgList.cxx" on line 102 I think there is a bug.  The "if ( next >=
n )" should be "if ( next > n )".  In the extreme case, if both "next" and
"n" are zero, we will wind up pointing to "next" equal to -1.  In general,
if "next" is equal to "n", we wind up pointing at the element we just
processed.

(9) In "ssgSimpleList.cxx" on line 29, do we want to test for "if ( this ==
src ) return ;"?  The test is in "ssgBase.cxx" on line 41, also in the
"copy_from" function.

(10) In "ssgVTable.cxx" on line 41 there is a note that "ssgVTable" is
obsolete.  Do we want to put a copy of this note in "ssg.h" on line 1307?
Do we want to deprecate the class in favor of "ssgVtxTable"?

(11) In "ssgVtxTable.cxx" on lines 338 and 364, the formulae look good to
me.  Does somebody else want to check them and take out the comment?

(12) In "ssgVtxTable.cxx" on lines 346, 362, and 385, do we want to change
the "assert" calls to "ulError" with an error message?  This also holds,
perhaps a little less strongly, with lines 365, 370, and 378.

(13) In "ssgVtxTable.cxx" on line 540, what if "preDraw" is null?

(14) In "ssgVtxTable.cxx" on line 656ff, it would be more efficient to
transform the vertex array all at once and then "getTriangle" from the
transformed array.  I don't know whether this function is an execution time
driver.

(15) In "ssgVtxTable.cxx" on line 704ff, I can do this test with six
multiplies.  Is there enough of a demand for it that somebody is willing to
put it into CVS for me?

I have some more comments to "ssgVtxTable.cxx" and the geometry functions,
specifically in terms of making them more efficient; does anybody want to
hear them?

John F. Fay
joh...@eg...
850-729-6330 

RE: [Plib-devel] RE: Olivier's js code (LAVIGNE,ERIC), cygwin bui ld problem

[Fay J. F C. AAC/W. <joh...@eg...>]

Thank you very much!  I have downloaded and installed it and it is working
very nicely for me.

John F. Fay
joh...@eg...
850-729-6330 
-----Original Message-----
From: pli...@li...
[mailto:pli...@li...] On Behalf Of Norman Vine
Sent: Tuesday, August 17, 2004 9:06 AM
To: pli...@li...
Subject: RE: [Plib-devel] RE: Olivier's js code (LAVIGNE,ERIC), cygwin build
problem

<snip>

I suggest that those behind firewalls investigate this package
http://cvsgrab.sourceforge.net/

HTH

Norman







-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285
_______________________________________________
plib-devel mailing list
pli...@li...
https://lists.sourceforge.net/lists/listinfo/plib-devel

[Plib-devel] Re: Olivier's js code (LAVIGNE,ERIC), cygwin build problem

[Olivier A <oli...@wa...>]

> IRIX (jsNone.cxx) which indeed doesn't specify jsInit() ...
> It looks like it has to be added to jsNone.cxx instead.
>
> Erik
>

    Ooops! I forgot to add it to jsNone... Sorry.

Olivier A.

[Plib-devel] Re: Olivier's js code (LAVIGNE,ERIC), cygwin build

[Olivier A <oli...@wa...>]

> On Sat Aug 28 09:34:47 EDT 2004, Erik Hofman <er...@eh...>
> wrote:
>
>
> I just noticed that jsInit() is commented out in js.cxx. This
> function is needed for platforms that don't have joystick support
> (IRIX).

   The jsInit() function is now in the platform dependant code 
(jsWindows.cxx, jsMacOSX.cxx, ...) in order to perform initialisation 
(it previously was in the jsJoystick class constructor). If your 
platform has no support for joystick, you should use the jsNone.cxx 
file.
   Perhaps a change in the makefile will fix that issue...

Olivier.

Re: [Plib-devel] RE: Olivier's js code (LAVIGNE,ERIC), cygwin bui ld problem

[Erik H. <er...@eh...>]

LAVIGNE,ERIC wrote:
> 
> I am smokydiamond, and I committed only Olivier's changes, not John 
> Fay's. The line "void jsInit(){}" does not appear in the cvs version of 
> jsNone.cxx. I could add that one line to fix the problem we have now, or 
> I could just commit all of John's changes at once.

For me there is no hurry. I would add them all at once if I were you.

Erik

RE: [Plib-devel] RE: Olivier's js code (LAVIGNE,ERIC), cygwin bui ld problem

[LAVIGNE,ERIC <la...@uf...>]

I am smokydiamond, and I committed only Olivier's changes, not 
John Fay's. The line "void jsInit(){}" does not appear in the cvs 
version of jsNone.cxx. I could add that one line to fix the 
problem we have now, or I could just commit all of John's changes 
at once.

Eric Lavigne

On Mon Aug 30 22:22:41 EDT 2004, "James 'J.C.' Jones" 
<jc...@uf...> wrote:

> On Mon, 2004-08-30 at 10:33, Fay John F Contr AAC/WMG wrote:
>> OK, this is one more of my fixes to Olivier's code that didn't 
>> make it
>> into CVS.  The function does indeed need to be inserted into
>> "jsNone.cxx".  My version has on line 56 of that file:
>> 
>>   void jsJoystick::rawRead ( int *buttons, float *axes )
>>   {
>>     if ( buttons != NULL ) *buttons = 0 ;
>>   }
>> 
>> + void jsInit ()  {}
>> +
>>   #endif
>>  So if somebody will please put that into CVS post-haste it will 
>> be a
>> Very Good Thing.
> 
> That's already in CVS, courtesy of smokydiamond on 15 August:
> 
> revision 1.3
> date: 2004/08/15 00:12:32;  author: smokydiamond;  state: Exp;  
> lines:
> +8 -4
> Olivier A's js rewrite
> 
> 
> --  James 'J.C.' Jones - <jc...@uf...> - 
> http://pug.ibu02.com/
>   Television has proved that people will look at anything   
> rather than each other.
>          -- Ann Landers
> 

RE: [Plib-devel] RE: Olivier's js code (LAVIGNE,ERIC), cygwin bui ld problem

[James 'J.C.' J. <jc...@uf...>]

On Mon, 2004-08-30 at 10:33, Fay John F Contr AAC/WMG wrote:
> OK, this is one more of my fixes to Olivier's code that didn't make it
> into CVS.  The function does indeed need to be inserted into
> "jsNone.cxx".  My version has on line 56 of that file:
>=20
>   void jsJoystick::rawRead ( int *buttons, float *axes )
>   {
>     if ( buttons !=3D NULL ) *buttons =3D 0 ;
>   }
>=20
> + void jsInit ()  {}
> +
>   #endif
> =20
> So if somebody will please put that into CVS post-haste it will be a
> Very Good Thing.

That's already in CVS, courtesy of smokydiamond on 15 August:

revision 1.3
date: 2004/08/15 00:12:32;  author: smokydiamond;  state: Exp;  lines:
+8 -4
Olivier A's js rewrite


--=20
 James 'J.C.' Jones - <jc...@uf...> - http://pug.ibu02.com/
  Television has proved that people will look at anything=20
  rather than each other.
         -- Ann Landers

RE: [Plib-devel] RE: Olivier's js code (LAVIGNE,ERIC), cygwin bui ld problem

[Fay J. F C. AAC/W. <joh...@eg...>]

OK, this is one more of my fixes to Olivier's code that didn't make it into
CVS.  The function does indeed need to be inserted into "jsNone.cxx".  My
version has on line 56 of that file:

  void jsJoystick::rawRead ( int *buttons, float *axes )
  {
    if ( buttons != NULL ) *buttons = 0 ;
  }

+ void jsInit ()  {}
+
  #endif
 
So if somebody will please put that into CVS post-haste it will be a Very
Good Thing.

John F. Fay
joh...@eg...
850-729-6330 
-----Original Message-----
From: pli...@li...
[mailto:pli...@li...] On Behalf Of Erik Hofman
Sent: Monday, August 30, 2004 8:46 AM
To: pli...@li...
Subject: Re: [Plib-devel] RE: Olivier's js code (LAVIGNE,ERIC), cygwin bui
ld problem

Fay John F Contr AAC/WMG wrote:
> Wait, not so fast!  While "jsInit" is commented out in "js.cxx", it is 
> defined in all of the "js<operatingsytem>.cxx" files.  What operating 
> system are you using, and what files are you including in the library?

IRIX (jsNone.cxx) which indeed doesn't specify jsInit() ...
It looks like it has to be added to jsNone.cxx instead.

Erik


-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
_______________________________________________
plib-devel mailing list
pli...@li...
https://lists.sourceforge.net/lists/listinfo/plib-devel

Re: [Plib-devel] RE: Olivier's js code (LAVIGNE,ERIC), cygwin bui ld problem

[Erik H. <er...@eh...>]

Fay John F Contr AAC/WMG wrote:
> Wait, not so fast!  While "jsInit" is commented out in "js.cxx", it is 
> defined in all of the "js<operatingsytem>.cxx" files.  What operating 
> system are you using, and what files are you including in the library?

IRIX (jsNone.cxx) which indeed doesn't specify jsInit() ...
It looks like it has to be added to jsNone.cxx instead.

Erik

RE: [Plib-devel] RE: Olivier's js code (LAVIGNE,ERIC), cygwin bui ld problem

[Fay J. F C. AAC/W. <joh...@eg...>]

Wait, not so fast!  While "jsInit" is commented out in "js.cxx", it is
defined in all of the "js<operatingsytem>.cxx" files.  What operating system
are you using, and what files are you including in the library?

John F. Fay
joh...@eg...
850-729-6330 
-----Original Message-----
From: pli...@li...
[mailto:pli...@li...] On Behalf Of Erik Hofman
Sent: Saturday, August 28, 2004 3:28 PM
To: pli...@li...
Subject: Re: [Plib-devel] RE: Olivier's js code (LAVIGNE,ERIC), cygwin build
problem

LAVIGNE,ERIC wrote:
> 
> My computer is packed for moving right now, but I'll probably take care 
> of this within a week if no one else does.

That would be great. Thanks!

Erik

  > On Sat Aug 28 09:34:47 EDT 2004, Erik Hofman <er...@eh...> wrote:
> 
>>
>> I just noticed that jsInit() is commented out in js.cxx. This function 
>> is needed for platforms that don't have joystick support (IRIX).
>>
>> Could someone uncomment the line and put it in CVS?
>>
>> Erik


-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
_______________________________________________
plib-devel mailing list
pli...@li...
https://lists.sourceforge.net/lists/listinfo/plib-devel

Re: [Plib-devel] RE: Olivier's js code (LAVIGNE,ERIC), cygwin build problem

[Erik H. <er...@eh...>]

LAVIGNE,ERIC wrote:
> 
> My computer is packed for moving right now, but I'll probably take care 
> of this within a week if no one else does.

That would be great. Thanks!

Erik

  > On Sat Aug 28 09:34:47 EDT 2004, Erik Hofman <er...@eh...> wrote:
> 
>>
>> I just noticed that jsInit() is commented out in js.cxx. This function 
>> is needed for platforms that don't have joystick support (IRIX).
>>
>> Could someone uncomment the line and put it in CVS?
>>
>> Erik

Re: [Plib-devel] RE: Olivier's js code (LAVIGNE,ERIC), cygwin build problem

[LAVIGNE,ERIC <la...@uf...>]

My computer is packed for moving right now, but I'll probably take 
care of this within a week if no one else does.

Eric Lavigne

On Sat Aug 28 09:34:47 EDT 2004, Erik Hofman <er...@eh...> 
wrote:

> 
> I just noticed that jsInit() is commented out in js.cxx. This 
> function is needed for platforms that don't have joystick support 
> (IRIX).
> 
> Could someone uncomment the line and put it in CVS?
> 
> Erik
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by BEA Weblogic Workshop
> FREE Java Enterprise J2EE developer tools!
> Get your free copy of BEA WebLogic Workshop 8.1 today.
> http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
> _______________________________________________
> plib-devel mailing list
> pli...@li...
> https://lists.sourceforge.net/lists/listinfo/plib-devel
> 
> 

Re: [Plib-devel] RE: Olivier's js code (LAVIGNE,ERIC), cygwin build problem

[Erik H. <er...@eh...>]

I just noticed that jsInit() is commented out in js.cxx. This function 
is needed for platforms that don't have joystick support (IRIX).

Could someone uncomment the line and put it in CVS?

Erik

[Plib-devel] Corrections to "puaComboBox"

[Fay J. F C. AAC/W. <joh...@eg...>]

Gentlemen,

	In my application I just tried to put in a call to the "setSize"
function for a "puaComboBox" and found that it has absolutely no effect.  In
an effort to fix this, I added the following to the following files:

puAux.h, starting at line 252:
      /* Ensure that popup menu will show up at the right place */
      newList ( list ) ;
    }

+   void setSize ( int w, int h ) ;
+
    void draw ( int dx, int dy ) ;

puaComboBox.cxx, starting at line 269:
    newList ( entries ) ;
  }

+ void puaComboBox::setSize ( int w, int h )
+ {
+   int arrow_width = (int) ( float(h) / 1.5f ) ;
+   input->setSize ( w - arrow_width, h ) ;
+   arrow_btn->setPosition ( w - arrow_width, 0 ) ;
+   arrow_btn->setSize ( arrow_width, h ) ;
+ }
+

If somebody could please put this into CVS I would deeply appreciate it.
Similar changes may also be necessary for other compound widgets but I
cannot say for sure.

John F. Fay
joh...@eg...

[Plib-devel] Sub-submenus in PUI

[Fay J. F C. AAC/W. <joh...@eg...>]

I should probably be answering this question instead of asking it, but does
PUI have the capability of having multiple levels of submenu in its menu
widgets?  The main question is in the "puPopupMenu"; if that has it, I would
guess that all the others have it as well since they use that.

John F. Fay
joh...@eg...

RE: [Plib-devel] RE: Olivier's js code (LAVIGNE,ERIC), cygwin build problem

[Norman V. <nh...@ca...>]

Fay John F Contr writes:

>  For someone else, the nightly tarball still isn't working.

following snipped from SourceForge.net Site Status Page
http://sourceforge.net/docman/display_doc.php?docid=2352&group_id=1

"""
(  2004-07-29 05:23:35 - Project Shell Service  )   As of 2004-07-22, cron has been taken offline on the project shell servers. We
are currently pursuing a resolution to a significant performance problem on the shell servers related to cron jobs. At this time,
the project shell server is typically handling more than 1000 crontabs, many with poorly-scheduled cronjobs; we are working to
determine a way to reduce system performance impact of these cronjobs (through better management) as to make this particular service
offering (cron service) continue to be viable.
"""

So it appears as if the nightly tarball won't be generated
automagically until this issue is ironed out.

Note I just manually triggered the tarball script
622827 Aug 17 06:57 /home/groups/p/pl/plib/htdocs/dist/current.tgz
but .........

I suggest that those behind firewalls investigate this package
http://cvsgrab.sourceforge.net/

HTH

Norman

RE: [Plib-devel] RE: Olivier's js code (LAVIGNE,ERIC), cygwin bui ld problem

[Fay J. F C. AAC/W. <joh...@eg...>]

Eric,

	I also thank you for putting this into CVS.

	I'm also glad that you survived the hurricane.

	For someone else, the nightly tarball still isn't working.

John F. Fay
joh...@eg...

<snip>

[Plib-devel] Re: RE: Olivier"s js code (LAVIGNE,ERIC), cygwin build problem

[Ima S. <ima...@ve...>]

Eric,=20

Yes, your changes on a fresh cvs checkout of plib js fix all three build =
problems. (My change was unnecessary).

Sorry for the trouble!

Norman,=20

Your attachments weren't available via the web interface so I couldn't =
test them (I'm a digest subscriber, and haven't gotten a new digest =
yet).

Thanks to both of you!

Ima

RE: [Plib-devel] RE: Olivier's js code (LAVIGNE,ERIC), cygwin build problem

[LAVIGNE,ERIC <la...@uf...>]

0 errors, 0 warnings, on MSVC.net.

Eric


On Sun Aug 15 10:01:08 EDT 2004, Norman Vine <nh...@ca...> 
wrote:
> 
> Could Windows users please try the attached files
> and report back any problems
> 
> Norman

Re: [Plib-devel] RE: Olivier's js code (LAVIGNE,ERIC), cygwin build problem

[LAVIGNE,ERIC <la...@uf...>]

Ima,

I found these two bug fixes in John Fay's version of 
jsWindows.cxx. Please let me know if it compiles in Cygwin after 
making these changes.

1) line 44
static bool getOEMProductName
changes to
bool os_specific_s::getOEMProductName

2) line 119
getOEMProductName
changes to
os->getOEMProductName

Eric Lavigne



On Sun Aug 15 09:09:01 EDT 2004, Ima Sudonim 
<ima...@ve...> wrote:

> Eric,
> 
> Thank you very much for putting this fix in.
> 
> Sorry, I said cygwin works, but it doesn't.
> 
> I am getting a build break under cygwin as shown here:
> 
> if g++ -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" 
> -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" 
> -DPACKAGE_BUGREPORT=\"\
> -DPACKAGE=\"plib\" -DVERSION=\"1.8.4\" -DSTDC_HEADERS=1 
> -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DH
> E_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
> -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DWIN32=1 
>  -
>  -I. -I../../src/util    -g -O2 -Wall -MT jsWindows.o -MD -MP -MF 
> ".deps/jsWindows.Tpo" \
>   -c -o jsWindows.o `test -f 'jsWindows.cxx' || echo 
> './'`jsWindows.cxx; \
> then mv ".deps/jsWindows.Tpo" ".deps/jsWindows.Po"; \
> else rm -f ".deps/jsWindows.Tpo"; exit 1; \
> fi
> js.h: In function `bool getOEMProductName(jsJoystick*, char*, 
> int)':
> js.h:47: error: `int jsJoystick::error' is protected
> jsWindows.cxx:46: error: within this context
> js.h:45: error: `os_specific_s*jsJoystick::os' is protected
> jsWindows.cxx:61: error: within this context
> js.h:45: error: `os_specific_s*jsJoystick::os' is protected
> jsWindows.cxx:72: error: within this context
> 
> I have updated cygwin to the latest cygwin GCC:
> 
> $ gcc --version
> gcc (GCC) 3.3.3 (cygwin special)
> Copyright (C) 2003 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  
> There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A 
> PARTICULAR PURPOSE.
> 
> and the problem still occurs.
> 
> I can fix the first problem by adding an accessor function in 
> js.h like:
> 
>   int   getError      () const { return error ;    }
> 
> that is called from within jsWindows.cxx as:
> 
>   if ( joy->getError() )  return false ;
> 
> but I am not sure how to fix the other two. Can anyone please 
> help?  Do non-Cygwin users on windows also see this problem?
> 
> How can we safely access os-specific protected data?  Do we need 
> to do all of the getOEMProductName() os-specific processing 
> within a jsJoystick class member function as is done within 
> jsJoystick::jsJoystick ( int ident ) in jsLinux.cxx?
> 
> Thanks, Eric, for putting this fix in, and thanks to any 
> C++/Cygwin experts that can fix it!
> 
> Ima

RE: [Plib-devel] RE: Olivier's js code (LAVIGNE,ERIC), cygwin build problem

[Norman V. <nh...@ca...>]

LAVIGNE,ERIC writes:
> 
> I get the same set of errors under MSVC++.net (but with different 
> wording). Two ideas:

Could Windows users please try the attached files
and report back any problems

Norman 

Re: [Plib-devel] RE: Olivier's js code (LAVIGNE,ERIC), cygwin build problem

[LAVIGNE,ERIC <la...@uf...>]

Ima,

I get the same set of errors under MSVC++.net (but with different 
wording). Two ideas:

1) This shouldn't be happening. GetOEMProductName is a member of 
struct os_specific_s which is a friend of jsJoystick. Therefore 
GetOEMProductName should be able to access protected (and even 
private) members of jsJoystick directly. All three errors complain 
about GetOEMProductName accessing protected members of 
jsJoystick.

2) You fixed one of the three problems by creating a getter 
method. As far as I can tell, the three problems are essentially 
identical. So getter methods should work on them too. As I 
mentioned in (1), though, getters shouldn't be necessary.

I would prefer to figure out why we are running into this problem, 
but it is more important to get plib working again quickly. If we 
can't fix this problem for real by tonight, I will write some 
getters.

Eric Lavigne


On Sun Aug 15 09:09:01 EDT 2004, Ima Sudonim 
<ima...@ve...> wrote:

> Eric,
> 
> Thank you very much for putting this fix in.
> 
> Sorry, I said cygwin works, but it doesn't.
> 
> I am getting a build break under cygwin as shown here:
> 
> if g++ -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" 
> -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" 
> -DPACKAGE_BUGREPORT=\"\
> -DPACKAGE=\"plib\" -DVERSION=\"1.8.4\" -DSTDC_HEADERS=1 
> -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DH
> E_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
> -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DWIN32=1 
>  -
>  -I. -I../../src/util    -g -O2 -Wall -MT jsWindows.o -MD -MP -MF 
> ".deps/jsWindows.Tpo" \
>   -c -o jsWindows.o `test -f 'jsWindows.cxx' || echo 
> './'`jsWindows.cxx; \
> then mv ".deps/jsWindows.Tpo" ".deps/jsWindows.Po"; \
> else rm -f ".deps/jsWindows.Tpo"; exit 1; \
> fi
> js.h: In function `bool getOEMProductName(jsJoystick*, char*, 
> int)':
> js.h:47: error: `int jsJoystick::error' is protected
> jsWindows.cxx:46: error: within this context
> js.h:45: error: `os_specific_s*jsJoystick::os' is protected
> jsWindows.cxx:61: error: within this context
> js.h:45: error: `os_specific_s*jsJoystick::os' is protected
> jsWindows.cxx:72: error: within this context
> 
> I have updated cygwin to the latest cygwin GCC:
> 
> $ gcc --version
> gcc (GCC) 3.3.3 (cygwin special)
> Copyright (C) 2003 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  
> There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A 
> PARTICULAR PURPOSE.
> 
> and the problem still occurs.
> 
> I can fix the first problem by adding an accessor function in 
> js.h like:
> 
>   int   getError      () const { return error ;    }
> 
> that is called from within jsWindows.cxx as:
> 
>   if ( joy->getError() )  return false ;
> 
> but I am not sure how to fix the other two. Can anyone please 
> help?  Do non-Cygwin users on windows also see this problem?
> 
> How can we safely access os-specific protected data?  Do we need 
> to do all of the getOEMProductName() os-specific processing 
> within a jsJoystick class member function as is done within 
> jsJoystick::jsJoystick ( int ident ) in jsLinux.cxx?
> 
> Thanks, Eric, for putting this fix in, and thanks to any 
> C++/Cygwin experts that can fix it!
> 
> Ima

[Plib-devel] RE: Olivier's js code (LAVIGNE,ERIC), cygwin build problem

[Ima S. <ima...@ve...>]

Eric,

Thank you very much for putting this fix in.

Sorry, I said cygwin works, but it doesn't.

I am getting a build break under cygwin as shown here:

if g++ -DPACKAGE_NAME=3D\"\" -DPACKAGE_TARNAME=3D\"\" =
-DPACKAGE_VERSION=3D\"\" -DPACKAGE_STRING=3D\"\" =
-DPACKAGE_BUGREPORT=3D\"\
-DPACKAGE=3D\"plib\" -DVERSION=3D\"1.8.4\" -DSTDC_HEADERS=3D1 =
-DHAVE_SYS_TYPES_H=3D1 -DHAVE_SYS_STAT_H=3D1 -DHAVE_STDLIB_H=3D1 -DH
E_STRING_H=3D1 -DHAVE_MEMORY_H=3D1 -DHAVE_STRINGS_H=3D1 =
-DHAVE_INTTYPES_H=3D1 -DHAVE_STDINT_H=3D1 -DHAVE_UNISTD_H=3D1 =
-DWIN32=3D1  -
 -I. -I../../src/util    -g -O2 -Wall -MT jsWindows.o -MD -MP -MF =
".deps/jsWindows.Tpo" \
  -c -o jsWindows.o `test -f 'jsWindows.cxx' || echo './'`jsWindows.cxx; =
\
then mv ".deps/jsWindows.Tpo" ".deps/jsWindows.Po"; \
else rm -f ".deps/jsWindows.Tpo"; exit 1; \
fi
js.h: In function `bool getOEMProductName(jsJoystick*, char*, int)':
js.h:47: error: `int jsJoystick::error' is protected
jsWindows.cxx:46: error: within this context
js.h:45: error: `os_specific_s*jsJoystick::os' is protected
jsWindows.cxx:61: error: within this context
js.h:45: error: `os_specific_s*jsJoystick::os' is protected
jsWindows.cxx:72: error: within this context

I have updated cygwin to the latest cygwin GCC:

$ gcc --version
gcc (GCC) 3.3.3 (cygwin special)
Copyright (C) 2003 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is =
NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR =
PURPOSE.

and the problem still occurs.

I can fix the first problem by adding an accessor function in js.h like:

  int   getError      () const { return error ;    }

that is called from within jsWindows.cxx as:

  if ( joy->getError() )  return false ;

but I am not sure how to fix the other two. Can anyone please help?  Do =
non-Cygwin users on windows also see this problem?

How can we safely access os-specific protected data?  Do we need to do =
all of the getOEMProductName() os-specific processing within a =
jsJoystick class member function as is done within =
jsJoystick::jsJoystick ( int ident ) in jsLinux.cxx?

Thanks, Eric, for putting this fix in, and thanks to any C++/Cygwin =
experts that can fix it!

Ima

RE: [Plib-devel] Olivier's js code

[LAVIGNE,ERIC <la...@uf...>]

I put the changes in last night. Now they are available by 
anonymous cvs also.

Eric Lavigne

On Sat Aug 14 10:59:03 EDT 2004, "LAVIGNE,ERIC" <la...@uf...> 
wrote:

> 
> 
> When I submit this to cvs, I will be giving credit to Olivier as 
> the author. With that in mind, I would prefer to use Olivier's 
> version of the files from
> http://perso.wanadoo.fr/oliver77-htm/plib/liste.htm.
> 
> I found two problems with Olivier's version: (1) Steve Baker made 
> a change to jsMacOSX.cxx on Mar 18, 2004, and that change is not 
> reflected in Olivier's file. (2) Most plib files have an 18 line 
> copyright/license comment at the top. Olivier's jsMacOSX.cxx does 
> not, and neither does the CVS version.
> 
> John Fay's version of jsMacOSX.cxx does not have either of these 
> problems and is otherwise very similar to Olivier's version. I 
> propose committing John Fay's version of jsMacOSX.cxx and 
> Olivier's version of everything else.
> 
> I will commit the files on Saturday evening if there are no 
> objections before that time.
> 
> Eric Lavigne
> 
> 
> On Fri Aug 13 09:53:16 EDT 2004, Fay John F Contr AAC/WMG 
> <joh...@eg...> wrote:
> 
>> Folks,
>> 
>> 	To provide more info on the compiler error, here is what I got 
>> from
>> Mr. Jones:
>> 
>> <begin quote>
>> Black flag on the first lap...
>> 
>> jsLinuxOld.cxx: In constructor `jsJoystick::jsJoystick(int)':
>> jsLinuxOld.cxx:97: error: `num_hats' undeclared (first use this
>> function)
>> jsLinuxOld.cxx:97: error: (Each undeclared identifier is 
>> reported only
>> once for
>>    each function it appears in.)
>> make: *** [jsLinuxOld.o] Error 1
>>  (undoubtedly a simple fix, but I'll look at it after checking 
>> in your
>> other dozen changes. ;) )
>> <end quote>
>> 
>> If you look at line 97 of "jsLinuxOld.cxx", you will find that 
>> the variable
>> "num_hats" does not appear there.  In fact, it does not appear 
>> anywhere in
>> the file!  So I do not think the problem was with Olivier's code.
>> 
>> 	I've checked Olivier's code against what I submitted and there 
>> are a
>> few differences, some formatting and some significant.  I can 
>> forward a copy
>> of what I have to any interested parties.
>> 
>> John F. Fay
>> joh...@eg...
>> 
>> 
>> 
>> -----Original Message-----
>> From: pli...@li...
>> [mailto:pli...@li...]On Behalf Of 
>> LAVIGNE,ERIC
>> Sent: Thursday, August 12, 2004 4:47 PM
>> To: pli...@li...
>> Subject: [Plib-devel] Olivier's js code
>> 
>> 
>> 
>> I am willing and able to commit the files from
>> http://perso.wanadoo.fr/oliver77-htm/plib/liste.htm
>> 
>> I'm holding off for now, though, because it's not clear that
>> we're done discussing it. John and Ima seem certain that it's
>> an improvement, but JC couldn't even compile it (more details
>> on that anyone?).
>> 
>> Eric Lavigne
>> 
>> <snip>
>> 
> 
> 
> 
> 
> 
> 
> -------------------------------------------------------
> SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank 
> Media
> 100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
> Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
> http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285
> _______________________________________________
> plib-devel mailing list
> pli...@li...
> https://lists.sourceforge.net/lists/listinfo/plib-devel
> 
>